On 31 December 2014 at 01:22, Bin Meng bmeng.cn@gmail.com wrote:
Hi Simon,
On Wed, Dec 31, 2014 at 7:02 AM, Simon Glass sjg@chromium.org wrote:
Hi Bin,
On 30 December 2014 at 01:02, Bin Meng bmeng.cn@gmail.com wrote:
Remove the troublesome union hob_pointers so that some annoying casts are no longer needed in those hob access routines. This also improves the readability.
Signed-off-by: Bin Meng bmeng.cn@gmail.com
arch/x86/cpu/queensbay/fsp_support.c | 95 ++++++++++++---------- arch/x86/cpu/queensbay/tnc_dram.c | 39 +++++---- arch/x86/include/asm/arch-queensbay/fsp/fsp_hob.h | 46 ++++------- .../include/asm/arch-queensbay/fsp/fsp_support.h | 5 +- arch/x86/lib/cmd_hob.c | 16 ++-- 5 files changed, 101 insertions(+), 100 deletions(-)
Yes a big improvement - see a few additional ideas for a follow-on patch below.
Acked-by: Simon Glass sjg@chromium.org
Applied to u-boot-x86/next, thanks!