Re: [PATCH v3 3/3] pinctrl: single: Add tests for request API

+Bharat Gooty

On Tue, Oct 5, 2021 at 9:50 AM Roman Bacik roman.bacik@broadcom.com wrote:

Add request tests to dm_test_pinctrl_single with corresponding node in test.dts

Signed-off-by: Roman Bacik roman.bacik@broadcom.com

---

Changes in v3:

• Add request API test to dm_test_pinctrl_single

arch/sandbox/dts/test.dts | 17 +++++++++++++++++ test/dm/pinmux.c | 13 +++++++++++++ 2 files changed, 30 insertions(+)

diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts index e27d106466b4..0a9f24092eb6 100644 --- a/arch/sandbox/dts/test.dts +++ b/arch/sandbox/dts/test.dts @@ -1517,6 +1517,23 @@ }; };

•   pinctrl-single-gpio-range {
  

•           compatible = "pinctrl-single";
  

•           reg = <0x0000 0x238>;
  

•           #address-cells = <1>;
  

•           #size-cells = <1>;
  

•           ranges;
  

•           pinctrl-single,register-width = <32>;
  

•           pinctrl-single,function-mask = <7>;
  

•           pinctrl-single,gpio-range = <&range 0 2 1 &range 2 3 0>;
  

•           range: gpio-range {
  

•                   #pinctrl-single,gpio-range-cells = <3>;
  

•           };
  

•   };
  

•   hwspinlock@0 {
            compatible = "sandbox,hwspinlock";
    };
  

diff --git a/test/dm/pinmux.c b/test/dm/pinmux.c index 265df4ccb979..d4a8a7907006 100644 --- a/test/dm/pinmux.c +++ b/test/dm/pinmux.c @@ -132,6 +132,19 @@ static int dm_test_pinctrl_single(struct unit_test_state *uts) test_muxing(159, "0x0000004c 0x00000000 UNCLAIMED"); ret = pinctrl_get_pin_muxing(dev, 160, buf, sizeof(buf)); ut_asserteq(-EINVAL, ret);

•   ut_assertok(uclass_get_device_by_name(UCLASS_PINCTRL,
  

•                                         "pinctrl-single-gpio-range", &dev));
  

•   ut_asserteq(142, pinctrl_get_pins_count(dev));
  

•   ut_assertok(pinctrl_request(dev, 0, 0));
  

•   test_muxing(0, "0x00000000 0x00000001 UNCLAIMED");
  

•   ut_assertok(pinctrl_request(dev, 1, 0));
  

•   test_muxing(1, "0x00000004 0x00000001 UNCLAIMED");
  

•   ut_assertok(pinctrl_request(dev, 2, 0));
  

•   test_muxing(2, "0x00000008 0x00000000 UNCLAIMED");
  

•   ut_assertok(pinctrl_request(dev, 3, 0));
  

•   test_muxing(3, "0x0000000c 0x00000000 UNCLAIMED");
  

•   ut_assertok(pinctrl_request(dev, 4, 0));
  

•   test_muxing(4, "0x00000010 0x00000000 UNCLAIMED");
    return 0;
  

}

-- 2.17.1