Wolfgang Denk wd@denx.de wrote:
But I guess there's another side-effect from this patch which is somewhat more nasty: The user can _also_ disable the debug port by simply setting an environment variable. That might be a bad idea, and probably not even necessary for Mark's purposes.
Now you get it. That's what the whole discussion is about. See Detlev's posting that started it.
Right. I was only thinking about the original purpose of the patch and forgot that the environment variable wasn't really a necessary part of the solution.
So how about introducing a new flag, e.g. GD_FLG_DISABLE_CONSOLE, and use that instead? If set, it will disable both input and output, while GD_FLG_SILENT will just disable console output.
Sounds much better to me.
Ok, great. Mark, does this sound good to you?
Haavard