Hi Ilias and Simon,
On Wed, 27 Dec 2023 at 03:30, Ilias Apalodimas ilias.apalodimas@linaro.org wrote:
Hi Raymond,
On Fri, 22 Dec 2023 at 23:31, Raymond Mao raymond.mao@linaro.org wrote:
Save boot arguments r[0-3] into an array for handover of bloblist from previous boot stage.
Signed-off-by: Raymond Mao raymond.mao@linaro.org
Changes in v2
- New patch file created for v2.
Changes in v3
- Swap value of r0 with r2.
arch/arm/cpu/armv7/start.S | 13 +++++++++++++ 1 file changed, 13 insertions(+)
diff --git a/arch/arm/cpu/armv7/start.S b/arch/arm/cpu/armv7/start.S index 69e281b086..2ca63ca32c 100644 --- a/arch/arm/cpu/armv7/start.S +++ b/arch/arm/cpu/armv7/start.S @@ -152,9 +152,22 @@ ENDPROC(c_runtime_cpu_setup)
*************************************************************************/
WEAK(save_boot_params) +#if (IS_ENABLED(CONFIG_OF_BOARD) && IS_ENABLED(CONFIG_BLOBLIST))
ldr r12, =saved_args/* Intentionally swapping r0 with r2 */That isn't very helpful. It's obvious what the code does here. Add a comment on *why* (to keep the c function simpler etc)
Yes. I will update the comment.
[...]
Regards, Raymond