Hi Marek,
Thanks for the reply.
Subject: Re: [PATCH v7 1/4] arm: rmobile: Add RZ/G2[HMNE] SoC support
On 11/27/20 3:52 PM, Biju Das wrote:
Sorry for the late reply.
[...]
diff --git a/arch/arm/mach-rmobile/cpu_info-rcar.c b/arch/arm/mach-rmobile/cpu_info-rcar.c index 5bde24ae0e..08345503a2 100644 --- a/arch/arm/mach-rmobile/cpu_info-rcar.c +++ b/arch/arm/mach-rmobile/cpu_info-rcar.c @@ -6,6 +6,7 @@ */ #include <common.h> #include <asm/io.h> +#include <soc.h>
#define PRR_MASK 0x7fff #define R8A7796_REV_1_0 0x5200 @@ -21,9 +22,28 @@ static u32 rmobile_get_prr(void) #endif }
+static bool is_rzg_family(void) +{
- bool rzg_family_type = false;
- struct udevice *soc;
- char name[16];
- if (!(soc_get(&soc) || soc_get_family(soc, name, 16))) {
This depends on some other patchset, right ? I will wait for that to land and then apply this one.
Yes, Simon have reviewed this patches and not sure who needs to pick this up. So I have sent a gentle remainder for picking this patches [1] [1] http://u-boot.10912.n7.nabble.com/PATCH-v4-0-4-Add-Renesas-SoC-identificatio...
Did you check that this is still OK on RCar Gen2 with its size-limited SPL?
Unfortunately I do not have access currently to RCar Gen2 boards.
Shall we enable "is_rzg_family" as a weekfunction and override it for RCar Gen3? or it will be grateful, please could you test this on RCar Gen2 boards, if you have any?
Please let us know.
Also, do you have a git tree with all the remaining patches applied on top? It would be useful to get an overview what's still pending for mainline.
We have an internal private u-boot repository, where we run mainline u-boot CI job as part of patch submission.
Regarding status wise, all the patches required for boot RZ/G2[HMN] boards are submitted to mainline and is in review state.
For RZ/G2E, some patches are pending because of the dependency with RZ/G2[HMN]. We created a public repo[1] to get an overview what is still pending for mainline.
[1] https://github.com/prabhakarlad/u-boot-rzg2
Regards, Biju
Thanks
if (!strcmp(name, "RZ/G2"))rzg_family_type = true;- }
[...]