Dear Alessandro,
In message 20091129222444.2e454083@wker Anatolij Gustschin wrote:
Hello Alessandro,
Alessandro Rubini rubini-list@gnudd.com wrote:
<snip> > diff --git a/include/amba_clcd.h b/include/amba_clcd.h > new file mode 100644 > index 0000000..09c9aa2 > --- /dev/null > +++ b/include/amba_clcd.h > @@ -0,0 +1,85 @@ ... > +/* > + * CLCD Controller Internal Register addresses > + */ > +#define CLCD_TIM0 0x00000000 > +#define CLCD_TIM1 0x00000004 > +#define CLCD_TIM2 0x00000008 > +#define CLCD_TIM3 0x0000000c > +#define CLCD_UBAS 0x00000010 > +#define CLCD_LBAS 0x00000014
CLCD_LBAS isn't used in the code, please remove it.
...
+#define CLCD_STAT 0x00000020 +#define CLCD_INTR 0x00000024 +#define CLCD_UCUR 0x00000028 +#define CLCD_LCUR 0x0000002C
Actually such a register descriptiion must not be implemented by offset definitions at all. Please define a C struct, and access it using appropriate accessor functions only.
Best regards,
Wolfgang Denk