Hi Ben and Wolfgang,
In message d4fd46d3b2d27747b728da37fad3ebca3732d837.1231154122.git.monstr@monstr.eu you wrote:
From: Michal Simek monstr@monstr.eu
Signed-off-by: Michal Simek monstr@monstr.eu
drivers/net/Makefile | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/Makefile b/drivers/net/Makefile index 631336a..128dc11 100644 --- a/drivers/net/Makefile +++ b/drivers/net/Makefile @@ -26,6 +26,7 @@ include $(TOPDIR)/config.mk LIB := $(obj)libnet.a
COBJS-$(CONFIG_DRIVER_3C589) += 3c589.o +COBJS-$(CONFIG_PPC4xx_EMAC) += 4xx_enet.o COBJS-$(CONFIG_DRIVER_AX88180) += ax88180.o
What makes you think that CONFIG_PPC4xx_EMAC has a good place between CONFIG_DRIVER_3C589 and CONFIG_DRIVER_AX88180?
From my point of view make me more sense to rename 4xx_enec.c file to correspond
with driver name. I mean if the config is CONFIG_PPC4xx_EMAC the filename should be ppc4xx_emac.c or in second case CONFIG_4XX_ENET for current 4xx_enet.c file.
From these two choices I like the first one.
COBJS-$(CONFIG_BFIN_MAC) += bfin_mac.o @@ -54,11 +55,11 @@ COBJS-$(CONFIG_NS8382X) += ns8382x.o COBJS-$(CONFIG_DRIVER_NS9750_ETHERNET) += ns9750_eth.o COBJS-$(CONFIG_PCNET) += pcnet.o COBJS-$(CONFIG_PLB2800_ETHER) += plb2800_eth.o -COBJS-$(CONFIG_PPC4xx_EMAC) += 4xx_enet.o
that was ok here.
COBJS-$(CONFIG_DRIVER_RTL8019) += rtl8019.o
...while this isn't.
COBJS-$(CONFIG_RTL8139) += rtl8139.o COBJS-$(CONFIG_RTL8169) += rtl8169.o COBJS-$(CONFIG_DRIVER_S3C4510_ETH) += s3c4510b_eth.o +COBJS-$(CONFIG_SH_ETHER) += sh_eth.o COBJS-$(CONFIG_DRIVER_SMC91111) += smc91111.o COBJS-$(CONFIG_DRIVER_SMC911X) += smc911x.o COBJS-$(CONFIG_TIGON3) += tigon3.o bcm570x_autoneg.o 5701rls.o @@ -68,7 +69,6 @@ COBJS-$(CONFIG_ULI526X) += uli526x.o COBJS-$(CONFIG_VSC7385_ENET) += vsc7385.o COBJS-$(CONFIG_XILINX_EMAC) += xilinx_emac.o COBJS-$(CONFIG_XILINX_EMACLITE) += xilinx_emaclite.o -COBJS-$(CONFIG_SH_ETHER) += sh_eth.o
Actually we should perform a global s/CONFIG_DRIVER_/CONFIG_/, me thinks.
Agreed. Can you do it Michal, or should I (for net, anyway)?
I would like to describe what happen. I sent to mailing list two patches. One with Makefile sort and second with LL_TEMAC. First patch just sort some labels in drivers/net/Makefile. Wolfgang sent that he don't like it and he reject this patch. I haven't wanted to sort any Makefile labels I just wanted to add LL_TEMAC driver. Makefile sort was not my point. Then Ben add only Makefile sort patch (because of some small drivers violations) to net repo and send pull request to Wolfgang and he merged it to his repo.
My point was and is only add LL_TEMAC driver to u-boot not sorting labels in net repo. BEN: Could you please add that driver to your repo? and if you can please sort labels to correct way.
Thanks, Michal
Best regards,
Wolfgang Denk
regards, Ben