Re: [U-Boot-Users] [Patch]IntegratorAP & CP multi core module support

In message 89A528FE6DB0FA44877BB2F05B84671801C12D3C@ZIPPY.Emea.Arm.com you wrote:

Please inform me of any defects found.

See below :-(

CHANGELOG:

• Patch by Peter Pearse, 2 Feb 2005
  • add core module targets
  • add ARM946E cpu support
  • remap memory to 0x00000000

I finally added this patch, but just because it's been on my queue for so long without any real progress. I hope this is the easiest way to get things going.

But PLEASE don't even think of submitting such a monster again.

Most of your files violate the Coding Style. Trailing white space, indentation, etc.

What you do tho the Makefile is horror. Adding 170+ lines just for a few boards? There should be a cleaner way! Please provide a (incremental) patch to get rid of this mess! The Makefile is a Makefile, and no place to add hundrets of lines of source code.

Your board config names are unacceptable. "integratorcp_CM922T_XA10". Who is supposed to type something like this? Please provide a (incremental) patch to use sensible, *much* shorter names. Instead of "integratorcp_CM922T_XA10" it should be sufficient to write "cm922t_xa10", right?

Best regards,

Wolfgang Denk