Re: [U-Boot] [PATCH] test/py: Add option to skip SPL signature checking

On 02/22/2016 05:52 AM, Michal Simek wrote:

Provide user option to skip SPL signature verification for cases where u-boot is build with SPL support but full U-Boot is also verified without SPL. If you want to support this feature please add env__spl_skipped = True to your boardenv configuration file.

Nit: Blank line between those paragraphs?

For example Xilinx Zynq is using this feature where the same u-boot binary is checked with SPL and without SPL(with FSBL).

Nit: U-Boot not u-boot?

diff --git a/test/py/u_boot_console_base.py b/test/py/u_boot_console_base.py

          config_spl = bcfg.get('config_spl', 'n') == 'y'
          config_spl_serial_support = bcfg.get('config_spl_serial_support',
                                               'n') == 'y'

•        if config_spl and config_spl_serial_support:
  

•        config_spl_skip = self.config.env.get('env__spl_skipped',
  

•                                              False)
  

That's not a config file (.config or autoconf.mk), but a boardenv value. I'd suggest renaming it boardenv_spl_skipped or env_spl_skipped.

Tested-by: Stephen Warren swarren@nvidia.com

Once renamed, Acked-by: Stephen Warren swarren@nvidia.com