On Wed, Oct 20, 2021 at 3:18 PM Zhaofeng Li hello@zhaofeng.li wrote:
Hi Simon,
Thanks for your review! I have added a second patch to perform the cleanup that you mentioned in the review, so the actual "fix" patch stays minimal and easy to review.
I agree that calling the bootm and zboot code directly is the real solution to go. The current method is inherently error-prone, and I wonder how many cases of "kinda works but not really" [1] like this are there in U-Boot.
Thanks, Zhaofeng Li
[1] Without the patch, the kernel would boot with the U-Boot log showing initrd being loaded. However, the kernel wouldn't actually get the initrd.
This patch series fixes the issue that incorrect arguments are passed to x86 zboot in pxe_utils (pxe/extlinux-like config). See the commit message of the first patch for details.
Changes since v1:
- Added patch to clean up argv generation
Zhaofeng Li (2): pxe_utils: Fix arguments to x86 zboot pxe_utils: Clean up {bootm,zboot}_argv generation
cmd/pxe_utils.c | 45 ++++++++++++++++++++++++++++++++------------- 1 file changed, 32 insertions(+), 13 deletions(-)
series applied to u-boot-x86, thanks!