Re: [PATCH 3/4] clk: add clock driver for SCMI agents

Hi Peng,

On Mon, 20 Jul 2020 at 04:06, Peng Fan peng.fan@nxp.com wrote:

...

Subject: [PATCH 3/4] clk: add clock driver for SCMI agents

This change introduces a clock driver for SCMI agent devices. When SCMI agent and SCMI clock drivers are enabled, SCMI agent binds a clock device for each SCMI clock protocol devices enabled in the FDT.

(...)

+static ulong scmi_clk_set_rate(struct clk *clk, ulong rate) {

• struct scmi_clk_rate_set_in in = {
  

•         .clock_id = clk->id,
  

•         .flags = SCMI_CLK_RATE_ASYNC_NORESP |
  

This will use async, but how if sync?

Thanks, you're right, i made it wrong. Considering u-boot sequential execution, synchronous rate setting is prefered. I'll remove SCMI_CLK_RATE_ASYNC_NORESP from .flags value.

Etienne

Thanks, Peng.

...

•                  SCMI_CLK_RATE_ROUND_CLOSEST,
  

•         .rate_lsb = (u32)rate,
  

•         .rate_msb = (u32)((u64)rate >> 32),
  

• };
  
  

(...)