Re: [PATCH 1/3] cli_hush.c: refactor handle_dollar() to prepare for cmd_call

Dear Rasmus,

In message 20200925111942.4629-2-rasmus.villemoes@prevas.dk you wrote:

A later patch will add handling of $1 through $9 as well as $#, using the same SPECIAL_VAR_SYMBOL handling as is currently used for $?. So move that case to an explicit #ifdef __U_BOOT__ branch, and consolidate a few of the #ifndef __U_BOOT__ cases, making it easier to see the original hush code.

I won't comment on these and the other patches - you know my opinion: instead of hacking the current code, we should 1) come up with a plan and 2) update.

Please consider this a soft-NAK ;-)

Best regards,

Wolfgang Denk