Re: inconsistent wget behavior

Hi Fabio

On Sun, Jan 7, 2024 at 5:19 PM Michael Nazzareno Trimarchi michael@amarulasolutions.com wrote:

Hi

Il dom 7 gen 2024, 17:08 Fabio Estevam festevam@gmail.com ha scritto:

...

Hi Michael,

On Sat, Jan 6, 2024 at 5:49 AM Michael Nazzareno Trimarchi michael@amarulasolutions.com wrote:

...

Hi

Is this code correct?

if (tcp_seq_num >= initial_data_seq_num &&
                store_block(pkt, tcp_seq_num - initial_data_seq_num,
                            len) != 0) {
                    wget_fail("wget: store error\n",
                              tcp_seq_num, tcp_ack_num, action);
                    return;
            }

Can not be seq_num wrap around? Another point seems that is not guarantee packet reassembly

If you submit a patch, I will be glad to test it.

Cheers

I have already wrote something but I can not test. Will send tonight. My feeling is that sometime the initial sequence number of TCP ip is next to wrap around but not sure.

I have sent but not sure about it, just compile for now ;)

Michael