On 07/05/2011 05:44 AM, Mike Frysinger wrote:
On Monday, July 04, 2011 06:29:51 helmut.raiger@hale.at wrote:
eth_get_dev_by_name() is not safe to use for devname being NULL as it uses strcmp. This patch makes it return NULL if devname NULL is passed.
i'm not sure about this. passing NULL is wrong, and the caller should catch that shouldnt it ? -mike
So what is your suggestion how to deal with it?
It returns: "There is no ethernet device with name NULL"
This is pretty much the only thing it can return. The user of the function may handle this situation individually like:
printf("ethernet device '%s' not found\n, devname); --> "ethernet device '(NULL)' not found".
A panic on a NULL pointer de-reference is probably not helpful either.
Helmut
-- Scanned by MailScanner.