14 Feb
2012
14 Feb
'12
7:51 a.m.
On Monday 13 February 2012 18:54:46 Joe Hershberger wrote:
On Fri, Feb 3, 2012 at 6:07 AM, Mike Frysinger wrote:
hmm, thinking a bit more, i wonder if it makes more sense to split all of icmp out of net.c
This would also be fine. Are you thinking that icmp would include all of icmp or would we still have ping separate? Does this need to be done now? It would be quite a bit of churn to move ping changes to a different file first since the changes after the move would have to be manually recreated.
keeping ping.c is fine, but i think we should also have icmp.c broken out of net.c. since we're keeping ping.c, no need to rebase onto a new patch. icmp.c can come after these. -mike