Re: [U-Boot-Users] [PATCH] update for CSB226

On Monday 04 November 2002 01:59 pm, Wolfgang Denk wrote:

In message 20021104121905.GC21366@pengutronix.de you wrote:

...

here is an updated patch for the Cogent CSB226 board (PXA250). Some details which might require discussion:

arminfrastructure

• The "reset" code didn't work for me in the version which was in the repository. I've added a reset routine which works on the PXA250, but I suspect the old variant might have run on some other XScale processor? If yes, we should sort it out to some processor specific file, if no my code can simply go in.

Let's keep at least a minimum of technical stuff going on...

Any comments about this patch? Should I merge it?

Looks OK to me. This should work for all Xscale.

On a side note Wolfgang. Have you ever considered supporting the

if (machine_is_board_x()) {}

I know you're busy and this kind of thing is low priority. But it does make code, IMHO, more readable and cleaner.

Kyle.