Hello Viresh,
Am 19.05.2016 um 04:59 schrieb Viresh Kumar:
Sorry, I had to drop the extremely long cc list, otherwise I wasn't able to reply to this email. Mutt was rejecting it for some reason.
Any anyway, you should have put all those people in bcc rather.
Sorry for that ... I used patman and forgot the "-m" no maintainer option ... Hmmm... on the other side, all involved people should be informed ... added Simon to Cc ... Simon?
patman may create a big cc list, for example when moving config options to Kconfig ...
Makes it sense to add them all into bcc? At least the ones the maintainer script finds? Is this easy to adapt in patman?
Hmm.. a problem is may "git send-mail", as there is no "--bcc-cmd" option ... So, all bcc addresses must be added with the "--bcc=address" option ...
On 18-05-16, 16:18, Heiko Schocher wrote:
diff --git a/include/configs/spear-common.h b/include/configs/spear-common.h index c4b6234..5e2e2b1 100644 --- a/include/configs/spear-common.h +++ b/include/configs/spear-common.h @@ -106,9 +106,7 @@
- Default Environment Varible definitions
*/ #if defined(CONFIG_SPEAR_USBTTY) -#define CONFIG_BOOTDELAY -1 #else -#define CONFIG_BOOTDELAY 1 #endif
Doesn't this ifdef look strange now ? :)
Indeed ... I have no such hw ... could you prepare a patch, which moves CONFIG_SPEAR_USBTTY to Kconfig, so if this option is selected, it set CONFIG_BOOTDELAY to -1 ?
OK ... looking into the code ...
$ grep -lr CONFIG_SPEAR_USBTTY include/ include/configs/spear-common.h include/configs/spear6xx_evb.h include/configs/spear3xx_evb.h $
In include/configs/spear3xx_evb.h and include/configs/spear6xx_evb.h:
#if defined(CONFIG_usbtty) #define CONFIG_SPEAR_USBTTY #endif
Grrr... ugly style: CONFIG_usbtty
$ grep -lr CONFIG_usbtty . ./include/configs/spear6xx_evb.h ./include/configs/spear3xx_evb.h $
Hmm... did not find CONFIG_usbtty somewhere defined ... is this is all dead code?
So, in the first step I want to remove the lines #if defined(CONFIG_SPEAR_USBTTY) -#define CONFIG_BOOTDELAY -1 #else -#define CONFIG_BOOTDELAY 1 #endif
in include/configs/spear-common.h complete. But there are more places in this file with a "#if defined(CONFIG_SPEAR_USBTTY)" ... As it is currently dead code in mainline ... it needs a cleanup.
I remove the above lines in a v2 version of my patch. Done. Waiting for more comments on this patch, before posting.
Thanks!
bye, Heiko