Am Sonntag, 31. März 2019, 21:45:15 CEST schrieb Urja Rannikko:
Hi,
On Fri, Mar 29, 2019 at 2:09 PM Heiko Stübner heiko@sntech.de wrote:
+#ifdef CONFIG_DM_REGULATOR
this should be #if CONFIG_IS_ENABLED(DM_REGULATOR)
Ok, just FYI that fragment was based on the one in tmio-common.c, so maybe that should also be fixed(?).
yep, looks like it. While it doesn't cause compile errors right now, it might after all create runtime errors otherwise.
Heiko
because otherwise an SPL-build using the mmc driver may fail with
drivers/mmc/dw_mmc.c: In function ‘dwmci_set_ios’: drivers/mmc/dw_mmc.c:475:9: error: ‘struct mmc’ has no member named ‘vqmmc_supply’ if (mmc->vqmmc_supply) { ^~ drivers/mmc/dw_mmc.c:477:27: error: ‘struct mmc’ has no member named ‘vqmmc_supply’ regulator_set_value(mmc->vqmmc_supply, 1800000); ^~ drivers/mmc/dw_mmc.c:479:27: error: ‘struct mmc’ has no member named ‘vqmmc_supply’ regulator_set_value(mmc->vqmmc_supply, 3300000); ^~ drivers/mmc/dw_mmc.c:481:44: error: ‘struct mmc’ has no member named ‘vqmmc_supply’ ret = regulator_set_enable_if_allowed(mmc->vqmmc_supply, true);
if (mmc->vqmmc_supply) {if (mmc->signal_voltage == MMC_SIGNAL_VOLTAGE_180)regulator_set_value(mmc->vqmmc_supply, 1800000);elseregulator_set_value(mmc->vqmmc_supply, 3300000);ret = regulator_set_enable_if_allowed(mmc->vqmmc_supply, true);if (ret)return ret;}+#endif
return 0;}