Re: [U-Boot-Users] [PATCH v4] ppc: Add CFG_MEM_TOP_HIDE option to hide memory area that doesn't get "touched"

On Thursday 27 March 2008, Larry Johnson wrote:

...

+- CFG_MEM_TOP_HIDE (PPC only):

• If CFG_MEM_TOP_HIDE is defined in the board config header,
  

• this specified memory area will get subtracted from the top
  

• (end) of ram and won't get "touched" at all by U-Boot. By
  

• fixing up gd->ram_size the Linux kernel should gets passed
  

• the now "corrected" memory size and won't touch it either.
  

• This should work for arch/ppc and arch/powerpc. Only Linux
  

• board ports in arch/powerpc with bootwrapper support, that
  

• recalculate the memory size from the SDRAM controller setup
  

• will have to get fixed.
  

[...]

Hi Stefan,

I also have a nit to pick :-) . It's not clear to me whether the clause in the last sentence is meant to be restrictive or non-restrictive. If restrictive, I recommend removing the comma before the word "that". If non-restrictive, I recommend replacing the word "that" with the word "which".

Thanks. Its sometimes helpful if native English speakers helps out here. I have to admit that I don't really get the difference of both versions you mention above. In this sentense I refer to Linux board ports which need *additional* fixes in Linux. I'll send the changed patch in a few minutes with this sentence:

" Only Linux board ports in arch/powerpc with bootwrapper support, which recalculate the memory size from the SDRAM controller setup, will have to get fixed in Linux additionally. "

I hope its clear now.

Best regards, Stefan

===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================