Re: [U-Boot] [PATCH 2/2] ARM: omap3: add support to Technexion twister board

Dear Stefano Babic,

In message 1322040416-11751-3-git-send-email-sbabic@denx.de you wrote:

The twister board is a development board using the TAM3517 SOM.

Support for NAND, 2 Ethernet (EMAC and SMC911), USB (EHCI_OMAP).

Signed-off-by: Stefano Babic sbabic@denx.de CC: Tapani Utrianen tapani@technexion.com CC: Tom Rini tom.rini@gmail.com CC: Sandeep Paulraj s-paulraj@ti.com

...

+/*

• • Initializes on-chip ethernet controllers.
• • to override, implement board_eth_init()
• */

+int board_eth_init(bd_t *bis)

What exactly is the meaning of the above comment?

+#if defined(CONFIG_DRIVER_TI_EMAC)

• davinci_emac_initialize();

+#endif

We always want this, don't we?

+#define V_PROMPT "twister => " +#define CONFIG_SYS_PROMPT V_PROMPT

What is this V_PROMPT thing needed for? Please scrap it.

Best regards,

Wolfgang Denk