Re: [U-Boot-Users] FIX: dataflash.c

Dear Ulf,

in message 1187587574.31921.58.camel@elrond.sweden.atmel.com you wrote:

...

...

Why not call it dataflash_cs[] and move it into the board code? It already pollutes the namespace, is already board-dependent (hence the #ifdefs) and is apparently buggy?

Excellent idea.

...

Then the board code is responsible for defining a CFG_MAX_DATAFLASH_BANKS symbol which corresponds with the actual number of entries in the array. Of course, it can still be buggy, but at least it's contained within the board code.

I agree completely.

Who will provide such a patch?

I can do it, in a week or two.

Just to make sure I understand correctly: are you working on this? Any estimates when it might be ready?

Thanks in advance.

Best regards,

Wolfgang Denk