On Thu, 10 Jun 2021 16:07:05 +0200 Pali Rohár pali@kernel.org wrote:
On Thursday 10 June 2021 07:12:53 Stefan Roese wrote:
Hi Pali,
On 08.06.21 11:51, Pali Rohár wrote:
On Monday 07 June 2021 16:34:50 Marek Behún wrote:
Add nodes for SPI NOR partitions to the device tree of Turris MOX, as are in Linux' device tree.
This patch is not needed (for now) as U-Boot cannot parse SPI NOR partitions from DT yet. U-Boot for SPI NOR currently supports specifying partitions only via CONFIG_MTDPARTS_DEFAULT compile option.
But do you agree that this patch "does not hurt"? I'm asking to check, if I should include this patch in a potential pull request.
Yes. This does not hurt and currently does nothing. And after patches for SPI NOR parsing are merged then this patch can be useful.
So if you are fine with merging which which currently does noting and in future is useful then there is no problem with it.
Moreover this definition is also in kernel's DTS. I am going to try to work on the U-Boot's A3720 comphy driver so that we can completely align U-Boot's A3720 DTS files with kernel's.
Marek