On Tue, Apr 07, 2020 at 09:00:57PM -0600, Simon Glass wrote:
Each ACPI table has its own version number. Add the version numbers in a single function so we can keep them consistent and easily see what versions are supported.
Start a new acpi_table file in a generic directory to house this function. We can move things over to this file from x86 as needed.
...
+/* FADT TABLE Revision values */
Same comment?
+#define ACPI_FADT_REV_ACPI_1_0 1 +#define ACPI_FADT_REV_ACPI_2_0 3 +#define ACPI_FADT_REV_ACPI_3_0 4 +#define ACPI_FADT_REV_ACPI_4_0 4 +#define ACPI_FADT_REV_ACPI_5_0 5 +#define ACPI_FADT_REV_ACPI_6_0 6
+/* MADT TABLE Revision values - note these do not match the ACPI revision */ +#define ACPI_MADT_REV_ACPI_3_0 2 +#define ACPI_MADT_REV_ACPI_4_0 3 +#define ACPI_MADT_REV_ACPI_5_0 3 +#define ACPI_MADT_REV_ACPI_6_0 5
/* MCFG TABLE Revision values */
+#define ACPI_MCFG_REV_ACPI_3_0 1
...
+enum acpi_tables {
- ACPITAB_BERT,
- ACPITAB_DBG2,
- ACPITAB_DMAR,
- ACPITAB_DSDT,
- ACPITAB_ECDT,
- ACPITAB_FACS,
- ACPITAB_FADT,
- ACPITAB_HEST,
- ACPITAB_HPET,
- ACPITAB_IVRS,
- ACPITAB_MADT,
- ACPITAB_MCFG,
- ACPITAB_RSDP,
- ACPITAB_RSDT,
- ACPITAB_SLIT,
- ACPITAB_SPCR,
- ACPITAB_SRAT,
- ACPITAB_SSDT,
- ACPITAB_TCPA,
- ACPITAB_TPM2,
- ACPITAB_XSDT,
- /* Additional proprietary tables */
- ACPITAB_NHLT,
I didn't get the division. What proprietary means? For example NHLT spec is public now AFAIK. But SPCR, for instance, is an extension by Microsoft.
Perhaps the division can be 1st group: ACPI spec defined 2nd: PCI SIG defined 3rd: UEFI ACPI extensions
?
- ACPITAB_SPMI,
- ACPITAB_VFCT,
- ACPITAB_COUNT,
Comma at the end, if it is a terminator line, is redundant.
+};