On 01/17/2014 02:14 AM, Hector Palacios wrote:
This complements commit 9404a5fc7cb58 "env_mmc: allow environment to be in an eMMC partition" by allowing boards to accommodate the partition to use for the environment in different scenarios (similarly to what is done with the mmc dev number). Depending on the detected boot media, boards may decide to store the environment in a different partition.
The __weak function also allows to remove some ifdefs from the code. If CONFIG_SYS_MMC_ENV_PART is not defined, partition 0 is assumed (default value for U-Boot when a partition is not provided).
diff --git a/common/env_mmc.c b/common/env_mmc.c
__weak int mmc_get_env_devno(void) { return CONFIG_SYS_MMC_ENV_DEV;
+#if !defined(CONFIG_SYS_MMC_ENV_PART)
Isn't the trailing } for that function missing?
+#define CONFIG_SYS_MMC_ENV_PART 0 +#endif
+__weak int mmc_get_env_partno(void) +{
- return CONFIG_SYS_MMC_ENV_PART;
}