Re: [U-Boot] [PATCH 6/9] mx1: improve PLL freq computation

On 08/12/2011 02:03 AM, Eric Jarrige wrote:

Hi Stefano,

On 11 août 2011, at 11:22, Stefano Babic wrote:

...

On 08/10/2011 10:33 PM, Eric Jarrige wrote:

...

Improve PLL freq computation by using the full resolution of the PLL registers

Hi Eric,

...

• return (2*(u64)sys_clk_freq * (mfi*(mfd+1) + mfn))/((mfd+1)*(pd+1));

+}

• return (2*(CONFIG_SYSPLL_CLK_FREQ>>10)*( (mfi<<10) + (mfn<<10)/(mfd+1)))/(pd+1);

Please run checkpatch on your patches for V2. I have not yet done, but this line will report missing spaces.

I did it and had no error and no warning:

Here is the ourput of checkpatch.pl: < armadeus/buildroot/output/build/linux-3.0.1/scripts/checkpatch.pl ../../../target/u-boot/git/09-arm920t-relocation.patch total: 0 errors, 0 warnings, 10 lines checked

Then forget my comment. I did not yet run checkpatch on your patches.

Best regards, Stefano Babic