-----Original Message----- From: Jagdish Gediya Sent: 2019年8月16日 16:26 To: Z.q. Hou zhiqiang.hou@nxp.com; u-boot@lists.denx.de; sjg@chromium.org; Prabhakar Kushwaha prabhakar.kushwaha@nxp.com; Shengzhou Liu shengzhou.liu@nxp.com; bmeng.cn@gmail.com; Jiafei Pan jiafei.pan@nxp.com; Priyanka Jain priyanka.jain@nxp.com Subject: RE: [PATCH 00/13] powerpc: Enable device tree support
Hi Zhiqiang,
-----Original Message----- From: Z.q. Hou Sent: Friday, August 16, 2019 11:58 AM To: Jagdish Gediya jagdish.gediya@nxp.com; u-boot@lists.denx.de; sjg@chromium.org; Prabhakar Kushwaha
Shengzhou Liu shengzhou.liu@nxp.com; bmeng.cn@gmail.com; Jiafei
Pan
jiafei.pan@nxp.com; Priyanka Jain priyanka.jain@nxp.com Subject: RE: [PATCH 00/13] powerpc: Enable device tree support
Hi Jagdish,
Thanks a lot for your comments!
-----Original Message----- From: Jagdish Gediya Sent: 2019年8月16日 14:05 To: Z.q. Hou zhiqiang.hou@nxp.com; u-boot@lists.denx.de; sjg@chromium.org; Prabhakar Kushwaha
Shengzhou Liu shengzhou.liu@nxp.com; bmeng.cn@gmail.com; Jiafei
Pan
jiafei.pan@nxp.com; Priyanka Jain priyanka.jain@nxp.com Subject: RE: [PATCH 00/13] powerpc: Enable device tree support
Hi Zhiqiang,
-----Original Message----- From: Z.q. Hou Sent: Thursday, June 20, 2019 1:49 PM To: u-boot@lists.denx.de; sjg@chromium.org; Prabhakar Kushwaha prabhakar.kushwaha@nxp.com; Shengzhou Liu
bmeng.cn@gmail.com; Jagdish Gediya jagdish.gediya@nxp.com; Jiafei Pan jiafei.pan@nxp.com; Priyanka Jain priyanka.jain@nxp.com Cc: Z.q. Hou zhiqiang.hou@nxp.com Subject: [PATCH 00/13] powerpc: Enable device tree support
From: Hou Zhiqiang Zhiqiang.Hou@nxp.com
This patch is to enable device tree support for the Freescale PowerPC platforms below.
Hou Zhiqiang (13): powerpc: Enable device tree support for T2080RDB powerpc: Enable device tree support for T4240RDB powerpc: Enable device tree support for T1024RDB powerpc: Enable device tree support for T1042D4RDB powerpc: Enable device tree support for P1020RDB powerpc: Enable device tree support for P2020RDB powerpc: Enable device tree support for P2041RDB powerpc: Enable device tree support for P3041DS powerpc: Enable device tree support for P4080DS powerpc: Enable device tree support for P5040DS powerpc: dts: add default definition of
CONFIG_RESET_VECTOR_ADDRESS
powerpc: mpc8548cds: extend the reserved length for monitor powerpc: Enable device tree support for MPC8548CDS
arch/powerpc/dts/Makefile | 12 +++ arch/powerpc/dts/e500mc_power_isa.dtsi | 33 ++++++ arch/powerpc/dts/e500v2_power_isa.dtsi | 26 +++++ arch/powerpc/dts/e5500_power_isa.dtsi | 34 +++++++ arch/powerpc/dts/mpc8548-post.dtsi | 27 +++++ arch/powerpc/dts/mpc8548.dtsi | 27 +++++ arch/powerpc/dts/mpc8548cds.dts | 23 +++++ arch/powerpc/dts/mpc8548cds_36b.dts | 23 +++++ arch/powerpc/dts/p1020-post.dtsi | 27 +++++ arch/powerpc/dts/p1020.dtsi | 31 ++++++ arch/powerpc/dts/p1020rdb-pc.dts | 23 +++++ arch/powerpc/dts/p1020rdb-pc_36b.dts | 23 +++++ arch/powerpc/dts/p1020rdb-pd.dts | 23 +++++ arch/powerpc/dts/p2020-post.dtsi | 27 +++++ arch/powerpc/dts/p2020.dtsi | 31 ++++++ arch/powerpc/dts/p2020rdb-pc.dts | 23 +++++ arch/powerpc/dts/p2020rdb-pc_36b.dts | 23 +++++ arch/powerpc/dts/p2041.dtsi | 63
++++++++++++
arch/powerpc/dts/p2041rdb.dts | 18 ++++ arch/powerpc/dts/p3041.dtsi | 63
++++++++++++
arch/powerpc/dts/p3041ds.dts | 18 ++++ arch/powerpc/dts/p4080.dtsi | 83
+++++++++++++++
arch/powerpc/dts/p4080ds.dts | 18 ++++ arch/powerpc/dts/p5040.dtsi | 62
+++++++++++
arch/powerpc/dts/p5040ds.dts | 18 ++++ arch/powerpc/dts/t1024rdb.dts | 17 ++++ arch/powerpc/dts/t102x.dtsi | 52
++++++++++
arch/powerpc/dts/t1042d4rdb.dts | 17 ++++ arch/powerpc/dts/t104x.dtsi | 62
+++++++++++
arch/powerpc/dts/t2080rdb.dts | 17 ++++ arch/powerpc/dts/t4240.dtsi | 102
+++++++++++++++++++
arch/powerpc/dts/t4240rdb.dts | 17 ++++ arch/powerpc/dts/u-boot.dtsi | 3 + board/freescale/p1_p2_rdb_pc/README | 19 ++++ board/freescale/p2041rdb/README | 18 ++++ board/freescale/t102xrdb/README | 19 ++++ board/freescale/t104xrdb/README | 19 ++++ board/freescale/t208xrdb/README | 19 ++++ configs/MPC8548CDS_36BIT_defconfig | 3 + configs/MPC8548CDS_defconfig | 3 + configs/MPC8548CDS_legacy_defconfig | 3 + configs/P1020RDB-PC_36BIT_NAND_defconfig | 2 + configs/P1020RDB-PC_36BIT_SDCARD_defconfig | 2 + configs/P1020RDB-PC_36BIT_SPIFLASH_defconfig | 2 + configs/P1020RDB-PC_36BIT_defconfig | 3 + configs/P1020RDB-PC_NAND_defconfig | 2 + configs/P1020RDB-PC_SDCARD_defconfig | 2 + configs/P1020RDB-PC_SPIFLASH_defconfig | 2 + configs/P1020RDB-PC_defconfig | 3 + configs/P1020RDB-PD_NAND_defconfig | 2 + configs/P1020RDB-PD_SDCARD_defconfig | 2 + configs/P1020RDB-PD_SPIFLASH_defconfig | 2 + configs/P1020RDB-PD_defconfig | 3 + configs/P2020RDB-PC_36BIT_NAND_defconfig | 2 + configs/P2020RDB-PC_36BIT_SDCARD_defconfig | 2 + configs/P2020RDB-PC_36BIT_SPIFLASH_defconfig | 2 + configs/P2020RDB-PC_36BIT_defconfig | 3 + configs/P2020RDB-PC_NAND_defconfig | 2 + configs/P2020RDB-PC_SDCARD_defconfig | 2 + configs/P2020RDB-PC_SPIFLASH_defconfig | 2 + configs/P2020RDB-PC_defconfig | 3 + configs/P2041RDB_NAND_defconfig | 3 + configs/P2041RDB_SDCARD_defconfig | 3 + configs/P2041RDB_SPIFLASH_defconfig | 3 + configs/P2041RDB_defconfig | 3 + configs/P3041DS_NAND_defconfig | 3 + configs/P3041DS_SDCARD_defconfig | 3 + configs/P3041DS_SPIFLASH_defconfig | 3 + configs/P3041DS_defconfig | 3 + configs/P4080DS_SDCARD_defconfig | 3 + configs/P4080DS_SPIFLASH_defconfig | 3 + configs/P4080DS_defconfig | 3 + configs/P5040DS_NAND_defconfig | 3 + configs/P5040DS_SDCARD_defconfig | 3 + configs/P5040DS_SPIFLASH_defconfig | 3 + configs/P5040DS_defconfig | 3 + configs/T1024RDB_NAND_defconfig | 2 + configs/T1024RDB_SDCARD_defconfig | 2 + configs/T1024RDB_SPIFLASH_defconfig | 2 + configs/T1024RDB_defconfig | 3 + configs/T1042D4RDB_NAND_defconfig | 2 + configs/T1042D4RDB_SDCARD_defconfig | 2 + configs/T1042D4RDB_SPIFLASH_defconfig | 2 + configs/T1042D4RDB_defconfig | 3 + configs/T2080RDB_NAND_defconfig | 2 + configs/T2080RDB_SDCARD_defconfig | 2 + configs/T2080RDB_SPIFLASH_defconfig | 2 + configs/T2080RDB_defconfig | 3 + configs/T4240RDB_SDCARD_defconfig | 2 + configs/T4240RDB_defconfig | 3 + include/configs/MPC8548CDS.h | 2 +-
These changes looks good to me however I am concerned about the
testing.
Can you please tell what testing you did to verify these changes?
The NOR boot have been verified on all platforms.
Can you please verify the NAND, SD and SPIFLASH boot on at-least one of the platform where you have defined CONFIG_MPC85XX_HAVE_RESET_VECTOR for NAND, SD and SPIFLASH configs e.g. P2041RDB. I think this testing should be done on at least one of the platforms to eliminate any possibility of breaking the booting.
Reviewed u-boot main Makefile, and found a problem: for platforms P2041RDB, P3041DS, P4080DS, and P5040DS, the SD/NAND/SPIFLASH boot should not work, as the final image u-boot-with-dtb.bin does NOT include RCW and PBIs. Will fix this problem in next version.
Thanks, Zhiqiang
Thanks, Jagdish