12 Oct
2010
12 Oct
'10
11:33 p.m.
On Tue, Oct 12, 2010 at 3:24 PM, Wolfgang Denk wd@denx.de wrote:
Dear John Rigby,
In message 1285775292-15060-4-git-send-email-john.rigby@linaro.org you wrote:
All arches except nios2 and microblaze call boot_get_fdt from bootm_start in common/cmd_bootm.c.
....
- /* find flattened device tree */
- ret = boot_get_fdt (flag, argc, argv, images, &of_flat_tree, &of_size);
- if (ret)
- return 1;
- /* did generic code already find a device tree? */
- if (images->ft_len)
- of_flat_tree = images->ft_addr;
#endif
So what if the generic code did NOT find a device tree?
Before, there was an error return. And now?
I'll fix this.
- /* find flattened device tree */
- if (boot_get_fdt(flag, argc, argv, images, &of_flat_tree, &of_size))
- return 1;
- /* did generic code already find a device tree? */
- if (images->ft_len)
- of_flat_tree = images->ft_addr;
Ditto.
And this.
On which nios2 and microblaze has this been tested?
It hasn't that is why the custodians were CC'd.
You may want to put the NIOS and MB custodians on Cc:
I just checked my original message. They were CC'd unless I am very confused.
Thanks, John