Hi Dinh,
On 1 March 2016 at 15:16, Dinh Nguyen dinguyen@opensource.altera.com wrote:
Hi Simon,
On 02/29/2016 08:03 PM, Simon Glass wrote:
I think going forward, it would make sense to place the driver to be of UCLASS_CLK and would go into drivers/clk/, instead of under arch/arm/mach-socfpga directory, Am I correct in assuming that?
Yes.
Do you see any benefits to moving an existing clock driver that is in arch/ to drivers/clk and making it UCLASS_CLK?
It moves it to the new world, so some benefit there.
Do you have a driver for altr,clk-mgr? If not you could add a driver, or maybe "simple-bus" to the compatible string.
If you add a driver, see simple_bus_post_bind() for the function you need to call to bind devices in sub-nodes.
The reason I ask is that I think I will have to create a driver for "altr,clk-mgr" for the Arria10 platform, so I'm just wondering if I should do the same for a legacy clock manager.
What do you mean by legacy clock manager?
You'll only need this for driver model. Also, the driver can be very simple, like simple-bus.
Regards, Simon