
On 01/09/2018 13:37, Tom Rini wrote:
On Fri, Aug 31, 2018 at 03:04:31PM +0200, Stefano Babic wrote:
Hi Tom,
please pull from u-boot-imx, thanks !
The following changes since commit 11ed312896c5f5814064c5d45dcb2f53dc121437:
configs: am57xx: change default board name to beagle_x15 (2018-08-26 12:26:16 -0400)
are available in the Git repository at:
git://www.denx.de/git/u-boot-imx.git master
for you to fetch changes up to 2846e663fd62200a189bba357135e284a379a38b:
imx: missing CONFIG_MII in mx7dsabresd_qspi_defconfig (2018-08-31 12:08:43 +0200)
OK, NAK for the following problems:
- Fail to build: https://travis-ci.org/trini/u-boot/jobs/423197300 The failing board is ids8313 and it's failing to configure as CONFIG_SYS_BOOTCOUNT_I2C_BUS needs to be set, and isn't
It looks wrong how I verify the whole build. Running buildman on my host, all boards were built. I will
- In looking into the above I see configs/ge_bx50v3_defconfig and configs/mx53ppd_defconfig and a few more have a bunch of comments added to it. These will be blown away on the next re-sync. Comments need to go into the board README or something not an auto-generated file.
I saw this, but if the board maintainer won't use "make savedefonfig" to generate its own defconfig, I have not blocked this if this lead to a successful build.
- So I start reading the whole diff and I see:
commit 8e00d802e402d2a6734a88ebeb77a70efcfc354c Author: Sébastien Szymanski sebastien.szymanski@armadeus.com Date: Wed Jul 25 14:47:53 2018 +0200
ARM: opos6ul: make the board boot again
Which is wrong. The -u-boot.dtsi file is automatically included and should have all of the U-Boot specific DTS changes.
I have to understand why my build was successful...
- And since the above big real problems exist I'm going to point out for you to fix:
WARNING: no status info for 'mx7dsabresd_qspi' WARNING: no maintainers for 'mx7dsabresd_qspi'
Note this, they will be fixed.
Rather than fix it myself like I was going to before I found the other issues.
Regards, Stefano