Re: [U-Boot] [PATCH 4/5] cmd: bcb: Use strcmp() instead of strncmp() for string literals

Hi Igor,

On Fri, Jul 12, 2019 at 02:54:19PM +0300, Igor Opaniuk wrote:

...

static int bcb_field_get(char *name, char **field, int *size) {

•   if (!strncmp(name, "command", sizeof("command"))) {
  

•           *field = bcb.command;
  

•   if (!strcmp(name, "command")) {
  

•           *fieldp = bcb.command;
  

Many thanks for the recent reviews!

There is a small issue committed by my autopilot, i.e. I didn't do the best partitioning of the patches, such that they could provoke a build breakage during git bisecting (see the intermixed usage of field and fieldp variables above). I will fix it in v2, adding your Reviewed-by in the other patches.

Thanks again!