28 Jan
2020
28 Jan
'20
2:53 p.m.
Dear Keerthy,
In message 927f859e-9c93-2731-c69e-e491219a818a@ti.com you wrote:
--- a/env/nowhere.c +++ b/env/nowhere.c @@ -23,6 +23,7 @@ static int env_nowhere_init(void) { gd->env_addr = (ulong)&default_environment[0]; gd->env_valid = ENV_INVALID;
- (NULL, 0);
^^^^^^^^^^^^^^^^^^^^^^ You are inserting this line of "C code" only.
I think something got ate along the way. The patch is at http://patchwork.ozlabs.org/patch/1226946/ and the full line is:
- env_set_default(NULL, 0);
env_set_default(NULL, 0); sets the required flag for us in the nowhere path as well.
I see. Sorry, I didn't read the original patch. As you see in the quote above, the "env_set_default" somehow got lost, and this was what triggered my comment.
Feel free to ignore it.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Love all, trust a few. - William Shakespeare