On Tue, May 28, 2019 at 10:26 AM Thierry Reding thierry.reding@gmail.com wrote:
On Mon, May 20, 2019 at 05:59:57PM +0200, Thierry Reding wrote:
From: Thierry Reding treding@nvidia.com
Add the standard Ethernet device tree bindings (imported from v5.0 of the Linux kernel) and implement support for reading the MAC address for Ethernet devices in the Ethernet uclass. If the "mac-address" property exists, the MAC address will be parsed from that. If that property does not exist, the "local-mac-address" property will be tried as fallback.
MAC addresses from device tree take precedence over the ones stored in a network interface card's ROM.
Acked-by: Joe Hershberger joe.hershberger@ni.com Reviewed-by: Grygorii Strashko grygorii.strashko@ti.com Signed-off-by: Thierry Reding treding@nvidia.com
Changes in v4:
- do not clear MAC address on failure to avoid overwriting existing MAC
- fix build on xtensa (missing CONFIG_OF_CONTROL)
Changes in v3:
- add additional check to make sure the MAC address read from device tree is a valid MAC address
Changes in v2:
- use dev_read_u8_array_ptr()
.../devicetree/bindings/net/ethernet.txt | 66 +++++++++++++++++++ net/eth-uclass.c | 30 ++++++++- 2 files changed, 93 insertions(+), 3 deletions(-) create mode 100644 Documentation/devicetree/bindings/net/ethernet.txt
Hi Joe,
did you have a chance to look at this updated version? I've manually verified that the qemu-x86_64 test failure is no longer there and the build failure for xtensa is also gone.
A fairly largish series for Tom's Tegra tree is currently blocked on this because without these two patches it will cause a test failure.
I'll be build testing this soon.
Cheers, -Joe