Hi Sean,
On 1/24/20 9:27 AM, Lukasz Majewski wrote:
I saw your patches. Unfortunately, there was the Christmas/New year's break and afterwards I had some more urgent tasks to do. Apologize for that...
What I would like to see here is to reuse (or better - make the code less confusing) the code.
Rationale - the CCF was ported from iMX6Q Linux code from the outset.
Then Peng (CC'ed) wanted to adjust it to support composite clocks from i.MX8.
As a result the CCF drifted to be an iMX aligned, but the goal is to have it usable for other archs as well (and reuse from Linux as much as possible).
Ok, so I believe that these patches are a step in that direction. Is there any specific feedback you would like to give regarding them? I've tried to infer what good default behaviour should be. However, I'm sure there are places where someone more familiar with the CCF would be able to comment on.
I will do the review by the end of the weekend.
--Sean
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de