Re: [U-Boot] A minor question on a Driver Model function

Hi,

On 09/14/14 21:28, Simon Glass wrote:

Hi Masahiro,

On 12 September 2014 05:25, Masahiro Yamada yamada.m@jp.panasonic.com wrote:

...

Hi Simon,

I have a qustion about lists_driver_lookup_name() function.

    for (entry = drv; entry != drv + n_ents; entry++) {
            if (strncmp(name, entry->name, len))
                    continue;

            /* Full match */
            if (len == strlen(entry->name))
                    return entry;
    }

Why is this not like follows?

    for (entry = drv; entry != drv + n_ents; entry++) {
            if (!strcmp(name, entry->name))
                    return entry;
    }

I would suggest still using strncmp as it is safer, but count also the '\0', so something like:

for (entry = drv; entry != drv + n_ents; entry++) { if (!strncmp(name, entry->name, len + 1)) return entry; }

[...]