Re: [U-Boot] [PATCH v2 5/6] phylib: Add a bunch of PHY drivers from tsec

Hi Andy,

The tsec driver had a bunch of PHY drivers already written. This converts them all into PHY Lib drivers, and serves as the first set of PHY drivers for PHY Lib.

While doing that, cleaned up a number of magic numbers (though not all of them, as PHY vendors like to keep their numbers as magical as possible). Also, noticed that almost all of the vitesse/cicada PHYs had the same config/parse/startup functions, so those have been collapsed into one.

Signed-off-by: Andy Fleming afleming@freescale.com

• Added teranetics_init() to init function
• Sorted init functions in phy_init and in phy.h
• Sorted PHYs in drivers/net/phy/Makefile
• GPL v2+ on all new files
• Left the 500ms delay after autonegotiation for PHY drivers that had it, as I don't want to break the driver-specific functionality. I suspect that either we've already fixed the bug this was really working around, or we will need a bug fix in the generic code. Either way, this code doesn't change the previous behavior, and can always be fixed at a later date, when one of us has time to actually test it out.
• Added many constants and consolidated the vitesse functions

Thanks for the changes, especially for the tedious constants stuff. This looks really good now.

Acked-by: Detlev Zundel dzu@denx.de

Cheers Detlev