Hi Pali,
On 2/23/23 08:55, Pali Rohár wrote:
<snip>
This #ifdef usage really gets out of hand IMHO. Yes I know, you did not introduce it here. Still, perhaps some of this can be moved to using IS_ENABLED or CONFIG_IS_ENABLED instead?
And I just checked that "bubt" is not compiled for CONFIG_BLK not defined. So please depend this file on CONFIG_BLK in Kconfig and remove the non CONFIG_BLK code here.
bubt is used for at least 4 different mvebu platforms (AXP, A38x, A3720, A7K) and every one has slightly different code and configuration.
I really do not know if all those configurations support CONFIG_BLK, so I decided to let it as it was before to eliminate possible issues.
As mentioned above, I've checked this myself before sending the suggestion yesterday. No platform compiling this cmd has CONFIG_BLK disabled.
OK! In this case I would rather send an additional cleanup patch which removes usage of non-CONFIG_BLK code from the whole command. As it does not make sense to not-have it in MMC and have it in SATA.
Handling this via a follow-up patch is even better. Thanks for working on this.
Thanks, Stefan