Larry Johnson wrote:
This patch adds a new switch: "CONFIG_PHY_DYNAMIC_ANEG". When this symbol is defined, the PHY will advertise it's capabilities for autonegotiation based on the capabilities shown in the PHY's status registers, including 1000BASE-X. When "CONFIG_PHY_DYNAMIC_ANEG" is not defined, the PHY will advertise hard-coded capabilities, as before.
I won't address the content yet, just the cosmetic changes that make up the bulk of this patch. I think you've done a good thing by running Lindent (or whatever) on all the files you've touched, but it has the effect of obscuring the meat of your work. No need to re-do it this time, but IMHO, purely cosmetic changes should be separate patches and labeled as such.
Of course, that's just MHO, and others may feel differently. Thoughts?
regards, Ben