Hi Fabio,
-----Original Message----- From: Fabio Estevam [mailto:festevam@gmail.com] Sent: 2018年11月1日 20:18 To: Peng Fan peng.fan@nxp.com Cc: Stefano Babic sbabic@denx.de; Fabio Estevam fabio.estevam@nxp.com; U-Boot-Denx u-boot@lists.denx.de; dl-linux-imx linux-imx@nxp.com Subject: Re: [U-Boot] [PATCH 1/4] tools: imx8image: check lseek return value
Hi Peng,
On Thu, Nov 1, 2018 at 9:15 AM Peng Fan peng.fan@nxp.com wrote:
lseek only returns -1 when error. Is the coding style you proposed is preferred than what this patch has?
In case lseek changes someday to return something else, checking for (ret < 0) will still work, so it is a more robust error handling.
lseek prototype, return value, in the spec http://pubs.opengroup.org/onlinepubs/9699919799/ Understand (ret < 0) is a good practice, but I do not think lseek return value will change.
Thanks, Peng.