On Wed, Apr 24, 2013 at 2:14 AM, Po Liu Po.Liu@freescale.com wrote:
From: Mingkai Hu Mingkai.Hu@freescale.com
C29XPCIE board is a series of Freescale PCIe add-in cards to perform as public key crypto accelerator or secure key management module. It includes C293PCIE board, C293PCIE board and C291PCIE board.
- 512KB platform SRAM in addition to 512K L2 Cache/SRAM
- 512MB soldered DDR3 32bit memory
- CPLD System Logic
- 64MB x16 NOR flash and 4GB x8 NAND flash
- 16MB SPI flash
Signed-off-by: Mingkai Hu Mingkai.Hu@freescale.com Singed-off-by: Po Liu Po.Liu@freescale.com
[...]
diff --git a/boards.cfg b/boards.cfg index 8b7933f..c35c9bf 100644 --- a/boards.cfg +++ b/boards.cfg @@ -758,6 +758,12 @@ MPC8569MDS_NAND powerpc mpc85xx mpc8569mds freesca MPC8572DS powerpc mpc85xx mpc8572ds freescale - MPC8572DS MPC8572DS_36BIT powerpc mpc85xx mpc8572ds freescale - MPC8572DS:36BIT MPC8572DS_NAND powerpc mpc85xx mpc8572ds freescale - MPC8572DS:NAND +C291PCIE powerpc mpc85xx c29xpcie freescale - C29XPCIE:C291PCIE,36BIT +C291PCIE_SPIFLASH powerpc mpc85xx c29xpcie freescale - C29XPCIE:C291PCIE,36BIT,SPIFLASH +C292PCIE powerpc mpc85xx c29xpcie freescale - C29XPCIE:C292PCIE,36BIT +C292PCIE_SPIFLASH powerpc mpc85xx c29xpcie freescale - C29XPCIE:C292PCIE,36BIT,SPIFLASH +C293PCIE powerpc mpc85xx c29xpcie freescale - C29XPCIE:C293PCIE,36BIT +C293PCIE_SPIFLASH powerpc mpc85xx c29xpcie freescale - C29XPCIE:C293PCIE,36BIT,SPIFLASH
There's no reason to create 6 different build targets for these boards. Just use the two:
C29XPCIE C29XPCIE_SPIFLASH
P1010RDB_36BIT_NAND powerpc mpc85xx p1010rdb freescale - P1010RDB:P1010RDB,36BIT,NAND P1010RDB_36BIT_NAND_SECBOOT powerpc mpc85xx p1010rdb freescale - P1010RDB:P1010RDB,36BIT,NAND_SECBOOT,SECURE_BOOT P1010RDB_36BIT_NOR powerpc mpc85xx p1010rdb freescale - P1010RDB:P1010RDB,36BIT diff --git a/include/configs/C29XPCIE.h b/include/configs/C29XPCIE.h new file mode 100644 index 0000000..0061426 --- /dev/null +++ b/include/configs/C29XPCIE.h @@ -0,0 +1,562 @@ +/*
- Copyright 2013 Freescale Semiconductor, Inc.
- See file CREDITS for list of people who contributed to this
- project.
- This program is free software; you can redistribute it and/or
- modify it under the terms of the GNU General Public License as
- published by the Free Software Foundation; either version 2 of
- the License, or (at your option) any later version.
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
- GNU General Public License for more details.
- You should have received a copy of the GNU General Public License
- along with this program; if not, write to the Free Software
- Foundation, Inc., 59 Temple Place, Suite 330, Boston,
- MA 02111-1307 USA
- */
+/*
- C29XPCIE board configuration file
- */
+#ifndef __CONFIG_H +#define __CONFIG_H
+#ifdef CONFIG_36BIT +#define CONFIG_PHYS_64BIT +#endif
+#ifdef CONFIG_C291PCIE +#define CONFIG_C291 +#endif
+#ifdef CONFIG_C292PCIE +#define CONFIG_C292 +#endif
+#ifdef CONFIG_C293PCIE +#define CONFIG_C293 +#endif
+#if defined(CONFIG_C291) || defined(CONFIG_C292) || defined(CONFIG_C293) +#define CONFIG_C29X +#endif
Here's just one reason why all those targets are excessive. Especially since there's only *one* consumer of CONFIG_C291/2/3, and that consumer just defines a constant that currently has no consumers.
Andy