Hi Philipp,
On Fri, 2018-11-30 at 22:13 +0100, Philipp Tomsich wrote:
The NAND driver of AXS10x depends on the availability of the bounce buffer. As the NAND driver is gated by CMD_NAND only, we need to select BOUNCE_BUFFER conditionally (on CMD_NAND) for TARGET_AXS101 and TARGET_AXS103.
Signed-off-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com
Changes in v3: None Changes in v2: None
arch/arc/Kconfig | 2 ++ include/configs/axs10x.h | 4 ---- 2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig index fa6b344..50369d5 100644 --- a/arch/arc/Kconfig +++ b/arch/arc/Kconfig @@ -146,9 +146,11 @@ config TARGET_NSIM
config TARGET_AXS101 bool "Support Synopsys Designware SDP board AXS101"
- select BOUNCE_BUFFER if CMD_NAND
config TARGET_AXS103 bool "Support Synopsys Designware SDP board AXS103"
- select BOUNCE_BUFFER if CMD_NAND
I'd say that more appropriate place is "board/synopsys/axs10x/Kconfig". Because: - This is related to the particular board, architecture has nothing to do with this - Only 1 line of change will be required as both boards use the same Kconfig file
config TARGET_EMSDP bool "Synopsys EM Software Development Platform" diff --git a/include/configs/axs10x.h b/include/configs/axs10x.h index 8febe09..bd1c902 100644 --- a/include/configs/axs10x.h +++ b/include/configs/axs10x.h @@ -82,8 +82,4 @@
- Console configuration
*/
-/*
- Misc utility configuration
- */
#endif /* _CONFIG_AXS10X_H_ */
As already mentioned maybe move it to the patch which moves the option to Kconfig?
-Alexey