20 Oct
2014
20 Oct
'14
9:39 p.m.
On Mon, Oct 20, 2014 at 03:17:13PM -0400, Tom Rini wrote:
You shouldn't have to add this to avoid a warning I think. And frankly, if it does for some reason since 3/3 makes use of dev, I'm OK with a bisect adding a trivial warning like this, rather than do compiler games.
Fair enough, the more I look at it, the more it looks like I probably missed a warning on this patch + CONFIG_DM9000_NO_SROM (defined but not used) so it is still pretty easy to trigger a warning on this patch. I'll just remove the indicated parts in v2 of the series and let the warnings get cleaned up in 3/3 as you have suggested.
Will send a v2 of series in a bit after seeing if there is any feedback on the approaches used in 3/3.
- Andy