August 2024 - U-Boot

[PATCH] i2c: mux: Fix error path in i2c-arb-gpio
by Michal Simek 01 Aug '24

01 Aug '24

There is no reason to use goto and just call return. Better is to call return directly which is done for some if/else parts. Also make no sense to setup ret to -ETIMEDOUT and then to 0. Return timeout directly. Signed-off-by: Michal Simek <michal.simek(a)amd.com> --- drivers/i2c/muxes/i2c-arb-gpio-challenge.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/i2c/muxes/i2c-arb-gpio-challenge.c b/drivers/i2c/muxes/i2c-arb-gpio-challenge.c index a83d7cb0829d..3d2ce0ca705d 100644 --- a/drivers/i2c/muxes/i2c-arb-gpio-challenge.c +++ b/drivers/i2c/muxes/i2c-arb-gpio-challenge.c @@ -54,7 +54,7 @@ int i2c_arbitrator_select(struct udevice *mux, struct udevice *bus, /* Indicate that we want to claim the bus */ ret = dm_gpio_set_value(&priv->ap_claim, 1); if (ret) - goto err; + return ret; udelay(priv->slew_delay_us); /* Wait for the EC to release it */ @@ -62,7 +62,7 @@ int i2c_arbitrator_select(struct udevice *mux, struct udevice *bus, while (get_timer(start_retry) < priv->wait_retry_ms) { ret = dm_gpio_get_value(&priv->ec_claim); if (ret < 0) { - goto err; + return ret; } else if (!ret) { /* We got it, so return */ return 0; @@ -75,17 +75,14 @@ int i2c_arbitrator_select(struct udevice *mux, struct udevice *bus, /* It didn't release, so give up, wait, and try again */ ret = dm_gpio_set_value(&priv->ap_claim, 0); if (ret) - goto err; + return ret; mdelay(priv->wait_retry_ms); } while (get_timer(start) < priv->wait_free_ms); /* Give up, release our claim */ printf("I2C: Could not claim bus, timeout %lu\n", get_timer(start)); - ret = -ETIMEDOUT; - ret = 0; -err: - return ret; + return -ETIMEDOUT; } static int i2c_arbitrator_probe(struct udevice *dev) -- 2.43.0

2 3

[PATCH] i2c: pca954x: Remove pointer to GD
by Michal Simek 01 Aug '24

01 Aug '24

There is no reason to have any pointer to GD that's why remove it. Signed-off-by: Michal Simek <michal.simek(a)amd.com> --- drivers/i2c/muxes/pca954x.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/i2c/muxes/pca954x.c b/drivers/i2c/muxes/pca954x.c index b4e3e16a9764..795288fe2e94 100644 --- a/drivers/i2c/muxes/pca954x.c +++ b/drivers/i2c/muxes/pca954x.c @@ -10,12 +10,9 @@ #include <i2c.h> #include <log.h> #include <malloc.h> -#include <asm/global_data.h> #include <asm-generic/gpio.h> -DECLARE_GLOBAL_DATA_PTR; - enum pca_type { PCA9543, PCA9544, -- 2.43.0

2 1

[PATCH v2] doc: document the pwm command
by Emil Kronborg 01 Aug '24

01 Aug '24

Signed-off-by: Emil Kronborg <emil.kronborg(a)protonmail.com> --- Changes in v2: - Fixed 'pwm enable' appearing twice in the examples section. - Rebased on top of master. doc/usage/cmd/pwm.rst | 80 +++++++++++++++++++++++++++++++++++++++++++ doc/usage/index.rst | 1 + 2 files changed, 81 insertions(+) create mode 100644 doc/usage/cmd/pwm.rst diff --git a/doc/usage/cmd/pwm.rst b/doc/usage/cmd/pwm.rst new file mode 100644 index 000000000000..3562e50280e6 --- /dev/null +++ b/doc/usage/cmd/pwm.rst @@ -0,0 +1,80 @@ +.. SPDX-License-Identifier: GPL-2.0+: + +.. index:: + single: pwm (command) + +pwm command +=========== + +Synopsis +-------- + +:: + + pwm invert <pwm_dev_num> <channel> <polarity> - invert polarity + pwm config <pwm_dev_num> <channel> <period_ns> <duty_ns> - config PWM + pwm enable <pwm_dev_num> <channel> - enable PWM output + pwm disable <pwm_dev_num> <channel> - disable PWM output + + +Description +----------- + +The ``pwm`` command is used to access and configure PWM (Pulse Width Modulation) +signals. For all subcommands, the following arguments are common: + +pwm_dev_num + device number + +channel + channel on chosen device + +pwm invert +---------- + +The signal's active and inactive states are swapped. + +pwm config +---------- + +Configure the period and duty cycle in nanoseconds. + +pwm enable +---------- + +Enable output on the configured device and channel. + +pwm disable +----------- + +Disable output on the configured device and channel. + +Examples +-------- + +Configure device 0 channel 0 to 50 kHz period and 70% duty cycle:: + + => pwm config 0 0 20000 14000 + +Enable output on the configured device and channel:: + + => pwm enable 0 0 20000 14000 + +Disable output on the configured device and channel:: + + => pwm disable 0 0 20000 14000 + +Invert the signal on the configured device and channel:: + + => pwm invert 0 0 1 + +Configuration +------------- + +The ``pwm`` command is only available if CONFIG_CMD_PWM=y. + +Return value +------------ + +If the command succeeds, the return value ``$?`` is set to 0. If an error occurs, the +return value ``$?`` is set to 1. diff --git a/doc/usage/index.rst b/doc/usage/index.rst index 49b354e6ffd2..1adab5283950 100644 --- a/doc/usage/index.rst +++ b/doc/usage/index.rst @@ -92,6 +92,7 @@ Shell commands cmd/pinmux cmd/printenv cmd/pstore + cmd/pwm cmd/qfw cmd/read cmd/reset base-commit: 8877bc51a8a4d921ba2f163208b8b1a57ba47c18 -- 2.46.0

2 2

[PATCH v2] cmd: led: fix led command usage for the LED_SW_BLINK enabled case
by Mikhail Kshevetskiy 01 Aug '24

01 Aug '24

CONFIG_LED_BLINK and CONFIG_LED_SW_BLINK can be defined independently. Led blinking works if any (or both) of them is enabled. Unfortunately the led command help does not display blinking option if only CONFIG_LED_SW_BLINK is enabled. This is definitely wrong. This patch fix an issue. Changes v2: * patch description added Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy(a)iopsys.eu> Reviewed-by: Simon Glass <sjg(a)chromium.org> --- cmd/led.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/led.c b/cmd/led.c index 2f786f34c67..91fb856ee59 100644 --- a/cmd/led.c +++ b/cmd/led.c @@ -118,7 +118,7 @@ int do_led(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) return 0; } -#ifdef CONFIG_LED_BLINK +#if defined(CONFIG_LED_BLINK) || defined(CONFIG_LED_SW_BLINK) #define BLINK "|blink [blink-freq in ms]" #else #define BLINK "" -- 2.39.2

2 1

[PATCH v1 0/1] disk: add TegraPT support
by Svyatoslav Ryhel 01 Aug '24

01 Aug '24

Production Tegra20/30/114/124/132 devices use Nvidia's own partition table, which makes them a bit complicated to deal with. Luckily, it is compatible with the existing EFI partition already available in U-Boot, apart from the fact that it cannot pass Protective MBR check. In order to address this without unwanted code additions, I have come up with this solution. Svyatoslav Ryhel (1): disk: add TegraPT support disk/Kconfig | 8 ++++++++ disk/part_efi.c | 13 +++++++++++++ 2 files changed, 21 insertions(+) -- 2.43.0

1 1

[PATCH v1 0/3] video: tegra: implement ganged dsi mode
by Svyatoslav Ryhel 01 Aug '24

01 Aug '24

This patchset implements DSI ganged mode and basically implements the same ideas introduced by Thierry Reding for Linux Tegra DSI driver. The Sharp LQ101R1SX01 driver is both an example of a panel that supports ganged mode and a preparation for upstreaming the ASUS Transformer TF701T which uses both this panel and DSI mode. Patches were tested on ASUS TF701T which benefits most from this change, along with other Tegra114 and Tegra30 devices. No regressions were found; U-Boot CI passed successfully. Svyatoslav Ryhel (3): video: tegra20: dc: remove DECLARE_GLOBAL_DATA_PTR use video: tegra20: dsi: add ganged mode support video: panel: add Sharp LQ101R1SX01 MIPI DSI panel driver drivers/video/Kconfig | 9 + drivers/video/Makefile | 1 + drivers/video/sharp-lq101r1sx01.c | 282 ++++++++++++++++++++++++++++++ drivers/video/tegra20/tegra-dc.c | 2 - drivers/video/tegra20/tegra-dsi.c | 95 +++++++++- drivers/video/tegra20/tegra-dsi.h | 15 +- 6 files changed, 396 insertions(+), 8 deletions(-) create mode 100644 drivers/video/sharp-lq101r1sx01.c -- 2.43.0

1 3