April 2024 - U-Boot

[PATCH 0/4] smpi: msm: fix version 5 and add version 7 support
by Neil Armstrong 23 Apr '24

23 Apr '24

First, fix version 5 support by using the right ch_offset in then msm_spmi_write() reg accesses. Then: - properly format command by importing helpers from Linux driver and use a switch/case to handle all versions in msm_spmi_write/read() command. - handle peripheral ownership by poking into the cnfg registers and mark periperal as read-only when the owner id doesn't match - finally add version 7 defines SPMI Arbiter Version 7 is present on SM8450, SM8550 and SM8650 SoC. Signed-off-by: Neil Armstrong <neil.armstrong(a)linaro.org> --- Neil Armstrong (4): spmi: msm: fix version 5 support spmi: msm: properly format command spmi: msm: handle peripheral ownership spmi: msm: support controller version 7 drivers/spmi/spmi-msm.c | 148 +++++++++++++++++++++++++++++++++++++----------- 1 file changed, 116 insertions(+), 32 deletions(-) --- base-commit: f0e6aba1218bca578605697eed8aa94582bf57bb change-id: 20240404-topic-sm8x50-spmi-fixes-aec9b392813b Best regards, -- Neil Armstrong <neil.armstrong(a)linaro.org>

2 6

[PATCH v2] mach-snapdragon: Allow other board vendors apart from Qcom
by Sumit Garg 23 Apr '24

23 Apr '24

Qcom SoCs derived boards can come from various OEMs/ODMs and not just Qcom itself. So allow CONFIG_SYS_VENDOR to be set correctly corressponding to the actual board vendor. Suggested-by: Stephan Gerhold <stephan(a)gerhold.net> Reviewed-by: Caleb Connolly <caleb.connolly(a)linaro.org> Signed-off-by: Sumit Garg <sumit.garg(a)linaro.org> --- Changes in v2: - Retained default vendor being "qualcomm". - Collected review tag. arch/arm/mach-snapdragon/Kconfig | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-snapdragon/Kconfig b/arch/arm/mach-snapdragon/Kconfig index 96e44e2c549..536960b83c3 100644 --- a/arch/arm/mach-snapdragon/Kconfig +++ b/arch/arm/mach-snapdragon/Kconfig @@ -4,7 +4,12 @@ config SYS_SOC default "snapdragon" config SYS_VENDOR + string "Snapdragon board vendor" default "qualcomm" + help + Allows to specify vendor for the Snapdragon SoCs based boards. + Based on this option board/<CONFIG_SYS_VENDOR>/<CONFIG_SYS_BOARD> + will be used as the custom board directory. config SYS_MALLOC_F_LEN default 0x2000 @@ -19,12 +24,11 @@ config LNX_KRNL_IMG_TEXT_OFFSET_BASE default 0x80000000 config SYS_BOARD - string "Qualcomm custom board" + string "Snapdragon SoCs based board" help - The Dragonboard 410c and 820c have additional board init - code that isn't shared with other Qualcomm boards. - Based on this option board/qualcomm/<CONFIG_SYS_BOARD> will - be used. + Allows to specify the Snapdragon SoCs based board name. + Based on this option board/<CONFIG_SYS_VENDOR>/<CONFIG_SYS_BOARD> + will be used as the custom board directory. config SYS_CONFIG_NAME string "Board configuration name" -- 2.34.1

2 2

[PATCH v2 1/5] pinctrl: qcom: allow selecting with ARCH_IPQ40XX
by Robert Marko 23 Apr '24

23 Apr '24

IPQ4019 pinctrl driver was moved to the dedicated Qualcomm pinctrl directory, but the KConfig depends on ARCH_SNAPDRAGON only and thus PINCTRL_QCOM_IPQ4019 cannot be selected when ARCH_IPQ40XX is used. Fixes: 24d2908e987a ("pinctrl: qcom: move ipq4019 driver from mach-ipq40xx") Signed-off-by: Robert Marko <robert.marko(a)sartura.hr> Reviewed-by: Caleb Connolly <caleb.connolly(a)linaro.org> --- drivers/pinctrl/qcom/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig index 2fe6398147..bd2019c866 100644 --- a/drivers/pinctrl/qcom/Kconfig +++ b/drivers/pinctrl/qcom/Kconfig @@ -1,4 +1,4 @@ -if ARCH_SNAPDRAGON +if ARCH_SNAPDRAGON || ARCH_IPQ40XX config PINCTRL_QCOM depends on PINCTRL_GENERIC -- 2.44.0

2 5

[PATCH] arm: mach-ipq40xx: dont select SMEM by default
by Robert Marko 23 Apr '24

23 Apr '24

IPQ40xx SoC-s dont have proper SMEM support like more modern Qualcomm SoC-s so there is no point in selecting the required drivers. Signed-off-by: Robert Marko <robert.marko(a)sartura.hr> --- arch/arm/Kconfig | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 23ee25269a..922c28cca9 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -762,10 +762,8 @@ config ARCH_IPQ40XX select DM_SERIAL select DM_RESET select GPIO_EXTRA_HEADER - select MSM_SMEM select PINCTRL select CLK - select SMEM select OF_CONTROL select CLK_QCOM_IPQ4019 select PINCTRL_QCOM_IPQ4019 -- 2.44.0

2 1

[PATCH 0/3] qcom: switch to OF_UPSTREAM
by Caleb Connolly 23 Apr '24

23 Apr '24

This series does the initial switch to OF_UPSTREAM for Qualcomm platforms. The DT files we have in U-Boot are outdated by now, so drop them and move to upstream. Patch 2 drops all the Qualcomm dts files that are now provided in dts/upstream. As some of the files exceed the 100k size limit by themselves I thought it would be easier to just lump them together rather than trying to split them up. The associated qcom headers will be cleaned up in future patches. --- Caleb Connolly (3): mach-snapdragon: use OF_UPSTREAM arm: dts: drop qcom dts files qcom_defconfig: set SYS_INIT_SP_BSS_OFFSET MAINTAINERS | 4 - arch/arm/Kconfig | 1 + arch/arm/dts/apq8016-sbc.dts | 729 ---- arch/arm/dts/apq8096-db820c.dts | 1137 ------ arch/arm/dts/msm8916-pm8916.dtsi | 157 - arch/arm/dts/msm8916.dtsi | 2702 ------------- arch/arm/dts/msm8996.dtsi | 3884 ------------------ arch/arm/dts/pm8916.dtsi | 178 - arch/arm/dts/pm8994.dtsi | 152 - arch/arm/dts/pm8998.dtsi | 130 - arch/arm/dts/pmi8994.dtsi | 65 - arch/arm/dts/pmi8998.dtsi | 98 - arch/arm/dts/pms405.dtsi | 149 - arch/arm/dts/qcs404-evb-4000.dts | 96 - arch/arm/dts/qcs404-evb.dtsi | 389 -- arch/arm/dts/qcs404.dtsi | 1829 --------- arch/arm/dts/sdm845-db845c.dts | 1190 ------ arch/arm/dts/sdm845-samsung-starqltechn.dts | 460 --- arch/arm/dts/sdm845-wcd9340.dtsi | 86 - arch/arm/dts/sdm845.dtsi | 5752 --------------------------- configs/dragonboard410c_defconfig | 2 +- configs/dragonboard820c_defconfig | 2 +- configs/qcom_defconfig | 3 +- 23 files changed, 5 insertions(+), 19190 deletions(-) --- base-commit: d5460b082cd6afd0e07c0ec0e5a82d1af8dc09f7 // Caleb (they/them)

3 8

[PATCH v3] rockchip: px30-board-tpl: Sync ifdef guards with full TPL
by lukasz.czechowski＠thaumatec.com 23 Apr '24

23 Apr '24

From: Lukasz Czechowski <lukasz.czechowski(a)thaumatec.com> Display TPL init information message only when TPL_BANNER_PRINT configuration entry is set. This allows to disable information message in case logs on UART are unwanted. Update parent ifdef condition to check also CONFIG_TPL_SERIAL to match logic of the non-PX30 TPL implementation. Signed-off-by: Lukasz Czechowski <lukasz.czechowski(a)thaumatec.com> --- Changes for v2: - Updated parent ifdef condition Changes for v3: - Updated commit title --- arch/arm/mach-rockchip/px30-board-tpl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-rockchip/px30-board-tpl.c b/arch/arm/mach-rockchip/px30-board-tpl.c index 637a5e1b18..db368a7b8c 100644 --- a/arch/arm/mach-rockchip/px30-board-tpl.c +++ b/arch/arm/mach-rockchip/px30-board-tpl.c @@ -36,7 +36,7 @@ void board_init_f(ulong dummy) { int ret; -#ifdef CONFIG_DEBUG_UART +#if defined(CONFIG_DEBUG_UART) && defined(CONFIG_TPL_SERIAL) debug_uart_init(); /* * Debug UART can be used from here if required: @@ -46,7 +46,9 @@ void board_init_f(ulong dummy) * printhex8(0x1234); * printascii("string"); */ +#if CONFIG_TPL_BANNER_PRINT printascii("U-Boot TPL board init\n"); +#endif #endif secure_timer_init(); -- 2.34.1

3 2

[RESEND PATCH v2] configs: rk3588-turing-rk1: disable SPI flash by default
by Sam Edwards 23 Apr '24

23 Apr '24

While the Turing RK1 board has a pad on the PCB for SPI flash, it is not populated at the factory: supporting SPI flash boot is a user modification, not an out-of-the-box feature. The defconfig for this board should therefore not be enabling the SPI flash image nor SPI support in the SPL, as it causes confusion among downstream users as to whether the SPI image needs to be distributed. Fixes: 153ac950a599 ("board: rockchip: Add the Turing RK1 SoM") Suggested-by: Florian Klink <flokli(a)flokli.de> Signed-off-by: Sam Edwards <CFSworks(a)gmail.com> Acked-by: Joshua Riek <jjriek(a)verizon.net> Reviewed-by: Jonas Karlman <jonas(a)kwiboo.se> --- Changes v1->v2 (both requested by Jonas): - Added back (i.e. made unremoved by patch) CONFIG_USB_GADGET_PRODUCT_NUM value previously automatically removed by savedefconfig. - Also disable SPI/SFC driver entirely until SPI/SFC lands in the DT (if ever). --- configs/turing-rk1-rk3588_defconfig | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/configs/turing-rk1-rk3588_defconfig b/configs/turing-rk1-rk3588_defconfig index 07f7b84852..f500b0cf75 100644 --- a/configs/turing-rk1-rk3588_defconfig +++ b/configs/turing-rk1-rk3588_defconfig @@ -4,17 +4,12 @@ CONFIG_SYS_HAS_NONCACHED_MEMORY=y CONFIG_COUNTER_FREQUENCY=24000000 CONFIG_ARCH_ROCKCHIP=y CONFIG_NR_DRAM_BANKS=2 -CONFIG_SF_DEFAULT_SPEED=24000000 -CONFIG_SF_DEFAULT_MODE=0x2000 CONFIG_DEFAULT_DEVICE_TREE="rk3588-turing-rk1" CONFIG_ROCKCHIP_RK3588=y -CONFIG_ROCKCHIP_SPI_IMAGE=y CONFIG_SPL_SERIAL=y CONFIG_TARGET_TURINGRK1_RK3588=y CONFIG_DEBUG_UART_BASE=0xFEBC0000 CONFIG_DEBUG_UART_CLOCK=24000000 -CONFIG_SPL_SPI_FLASH_SUPPORT=y -CONFIG_SPL_SPI=y CONFIG_SYS_LOAD_ADDR=0xc00800 CONFIG_PCI=y CONFIG_DEBUG_UART=y @@ -31,8 +26,6 @@ CONFIG_DISPLAY_BOARDINFO_LATE=y CONFIG_SPL_MAX_SIZE=0x40000 CONFIG_SPL_PAD_TO=0x7f8000 # CONFIG_SPL_RAW_IMAGE_SUPPORT is not set -CONFIG_SPL_SPI_LOAD=y -CONFIG_SYS_SPI_U_BOOT_OFFS=0x60000 CONFIG_SPL_ATF=y CONFIG_CMD_GPIO=y CONFIG_CMD_GPT=y @@ -66,11 +59,7 @@ CONFIG_MMC_DW_ROCKCHIP=y CONFIG_MMC_SDHCI=y CONFIG_MMC_SDHCI_SDMA=y CONFIG_MMC_SDHCI_ROCKCHIP=y -CONFIG_SF_DEFAULT_BUS=5 -CONFIG_SPI_FLASH_SFDP_SUPPORT=y -CONFIG_SPI_FLASH_MACRONIX=y -CONFIG_SPI_FLASH_XMC=y -CONFIG_SPI_FLASH_XTX=y +# CONFIG_SPI_FLASH is not set CONFIG_PHY_REALTEK=y CONFIG_DWC_ETH_QOS=y CONFIG_DWC_ETH_QOS_ROCKCHIP=y @@ -87,7 +76,6 @@ CONFIG_SPL_RAM=y CONFIG_SCSI=y CONFIG_DEBUG_UART_SHIFT=2 CONFIG_SYS_NS16550_MEM32=y -CONFIG_ROCKCHIP_SFC=y CONFIG_SYSRESET=y CONFIG_USB=y CONFIG_USB_XHCI_HCD=y -- 2.43.2

2 1

[PATCH 0/2] rockchip: add support for Theobroma Systems SOM-RK3588-Q7 Tiger module
by Quentin Schulz 23 Apr '24

23 Apr '24

The RK3588-Q7 SoM is a Qseven-compatible (70mm x 70mm, MXM-230 connector) system-on-module from Theobroma Systems, featuring the Rockchip RK3588. It provides the following feature set: * up to 16GB LPDDR4x * on-module eMMC * SD card (on a baseboard) via edge connector * Gigabit Ethernet with on-module GbE PHY * HDMI/eDP * MIPI-DSI * 4x MIPI-CSI (3x on FPC connectors, 1x over Q7) * HDMI input over FPC connector * CAN * USB - 1x USB 3.0 dual-role (direct connection) - 2x USB 3.0 host + 1x USB 2.0 host * PCIe - 1x PCIe 2.1 Gen3, 4 lanes - 2xSATA / 2x PCIe 2.1 Gen1, 2 lanes * on-module ATtiny816 companion controller, implementing: - low-power RTC functionality (ISL1208 emulation) - fan controller (AMC6821 emulation) * on-module Secure Element with Global Platform 2.2.1 compliant JavaCard environment The support is added for Tiger on Haikou devkit, similarly to RK3399 Puma and PX30 Ringneck. The DTS and DTSI are taken from upstream Linux kernel v6.9-rc4. Because Tiger doesn't use the same mux for the debug console as all other RK3588 devices currently supported in U-Boot, an additional patch is required to be able to interact with the device properly. This has a light dependency on https://lore.kernel.org/u-boot/20240415-rk35xx-dram-atags-v3-0-5bc5475b3c0d… (the Tiger defconfig can be updated to remove the dependency if required) Signed-off-by: Quentin Schulz <quentin.schulz(a)theobroma-systems.com> --- Quentin Schulz (2): rockchip: rk3588: add support for UART2 M1 and M2 in SPL rockchip: add support for Theobroma Systems SOM-RK3588-Q7 Tiger module arch/arm/dts/Makefile | 1 + arch/arm/dts/rk3588-tiger-haikou-u-boot.dtsi | 54 ++ arch/arm/dts/rk3588-tiger-haikou.dts | 266 ++++++++ arch/arm/dts/rk3588-tiger.dtsi | 690 +++++++++++++++++++++ arch/arm/mach-rockchip/rk3588/Kconfig | 41 ++ arch/arm/mach-rockchip/rk3588/rk3588.c | 36 ++ board/theobroma-systems/tiger_rk3588/Kconfig | 16 + board/theobroma-systems/tiger_rk3588/MAINTAINERS | 13 + board/theobroma-systems/tiger_rk3588/Makefile | 10 + .../theobroma-systems/tiger_rk3588/tiger_rk3588.c | 53 ++ configs/tiger-rk3588_defconfig | 114 ++++ doc/board/rockchip/rockchip.rst | 1 + doc/board/theobroma-systems/index.rst | 1 + doc/board/theobroma-systems/tiger_rk3588.rst | 102 +++ include/configs/tiger_rk3588.h | 15 + 15 files changed, 1413 insertions(+) --- base-commit: 5fb840ed8339cae3915ea1528a4bfa3e587540e6 change-id: 20240418-tiger-d1531308c9a0 Best regards, -- Quentin Schulz <quentin.schulz(a)theobroma-systems.com>

4 9

[PATCH v2 00/14] rockchip: rk3308: Sync DT with linux v6.8 and update defconfigs
by Jonas Karlman 23 Apr '24

23 Apr '24

This series adds support for new clocks used in linux v6.8 device trees, enables use of FIT signature check for checksum validation and fixes loading FIT from SD-card when loading FIT from eMMC fails. It should be possible to move RK3308 boards to use OF_UPSTREAM in a future series after this has been applied. I have runtime tested this series on a Radxa ROCK Pi S v1.3 having a RK3308B SoC. Following was tested and now working after this: SD-card, eMMC (SD NAND), Ethernet, USB host and USB gadget (RockUSB and UMS). Changes in v2: - Add clocks and resets props to otp node - Add bootph-some-ram to emmc and sdmmc pinctrl nodes - Sort bootph-all prop after compatible and reg props - Fix rk3308-evb debug uart - New patch to move cru and grf include files to arch-rockchip Finley Xiao (1): clk: rockchip: rk3308: Add support for SCLK_RTC32K clock Jonas Karlman (13): board: rockchip: rk3308: Add device tree files and myself to MAINTAINERS rockchip: rk3308: Sort imply statements alphabetically rockchip: rk3308: Enable ARMv8 crypto and FIT checksum validation rockchip: rk3308: Generate ethaddr based on cpu id rockchip: rk3308: Enable random generator rockchip: rk3308: Fix loading FIT from SD-card when booting from eMMC clk: rockchip: rk3308: Add dummy support for USB480M clock phy: rockchip-inno-usb2: Add support for RK3308 rockchip: rk3308: Sync device tree from linux v6.8 rockchip: rk3308-evb: Update defconfig rockchip: rk3308-roc-cc: Update defconfig rockchip: rk3308-rock-pi-s: Update defconfig rockchip: rk3308: Move cru and grf include files to arch-rockchip arch/arm/dts/rk3308-evb-u-boot.dtsi | 11 +- arch/arm/dts/rk3308-evb.dts | 104 +- arch/arm/dts/rk3308-roc-cc-u-boot.dtsi | 30 +- arch/arm/dts/rk3308-roc-cc.dts | 83 +- arch/arm/dts/rk3308-rock-pi-s-u-boot.dtsi | 45 +- arch/arm/dts/rk3308-rock-pi-s.dts | 100 +- arch/arm/dts/rk3308-u-boot.dtsi | 120 +- arch/arm/dts/rk3308.dtsi | 1205 +++++++++-------- .../cru_rk3308.h | 14 + .../grf_rk3308.h | 0 arch/arm/mach-rockchip/Kconfig | 19 +- arch/arm/mach-rockchip/rk3308/Kconfig | 3 - arch/arm/mach-rockchip/rk3308/clk_rk3308.c | 2 +- arch/arm/mach-rockchip/rk3308/rk3308.c | 2 +- board/firefly/firefly-rk3308/MAINTAINERS | 1 + board/firefly/firefly-rk3308/roc_cc_rk3308.c | 2 +- board/rockchip/evb_rk3308/MAINTAINERS | 5 +- configs/evb-rk3308_defconfig | 40 +- configs/roc-cc-rk3308_defconfig | 40 +- configs/rock-pi-s-rk3308_defconfig | 35 +- drivers/clk/rockchip/clk_rk3308.c | 101 +- drivers/net/gmac_rockchip.c | 4 +- drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 20 + drivers/ram/rockchip/sdram_rk3308.c | 2 +- 24 files changed, 1177 insertions(+), 811 deletions(-) rename arch/arm/include/asm/{arch-rk3308 => arch-rockchip}/cru_rk3308.h (95%) rename arch/arm/include/asm/{arch-rk3308 => arch-rockchip}/grf_rk3308.h (100%) -- 2.43.2

5 39

[PATCH] efi_loader: address coverity report 492766 for dead code
by Ilias Apalodimas 23 Apr '24

23 Apr '24

The check of the return code is already done a few lines above. Although it doesn't cause any functional issues, remove the superfluous checks Addresses-Coverity-ID: 492766 Control flow issues (DEADCODE) Signed-off-by: Ilias Apalodimas <ilias.apalodimas(a)linaro.org> --- lib/efi_loader/efi_var_mem.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/efi_loader/efi_var_mem.c b/lib/efi_loader/efi_var_mem.c index 940ab6638823..139e16aad7c6 100644 --- a/lib/efi_loader/efi_var_mem.c +++ b/lib/efi_loader/efi_var_mem.c @@ -232,8 +232,6 @@ efi_status_t efi_var_mem_init(void) efi_var_buf->length = (uintptr_t)efi_var_buf->var - (uintptr_t)efi_var_buf; - if (ret != EFI_SUCCESS) - return ret; ret = efi_create_event(EVT_SIGNAL_VIRTUAL_ADDRESS_CHANGE, TPL_CALLBACK, efi_var_mem_notify_virtual_address_map, NULL, NULL, &event); -- 2.43.0

2 1