February 2024 - U-Boot

[PATCH] imx9: clock: Fix board_interface_eth_init for FEC
by Primoz Fiser 08 Feb '24

08 Feb '24

Commit d5eae216d833 ("net: dwc_eth_qos: Add board_interface_eth_init() for i.MX93") implemented board_interface_eth_init for i.MX9 platforms. However it only accounted for the EQOS interface while any board using FEC as primary Ethernet interface was left out as return value -EINVAL is always returned from the function in such case. Fix this by returning 0 (success) when FEC interface is primarily used instead of EQOS interface on i.MX93. Fixes: d5eae216d833 ("net: dwc_eth_qos: Add board_interface_eth_init() for i.MX93") Signed-off-by: Primoz Fiser <primoz.fiser(a)norik.com> --- arch/arm/mach-imx/imx9/clock.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/arm/mach-imx/imx9/clock.c b/arch/arm/mach-imx/imx9/clock.c index 92c41e9a67bf..75d92af036a1 100644 --- a/arch/arm/mach-imx/imx9/clock.c +++ b/arch/arm/mach-imx/imx9/clock.c @@ -882,6 +882,11 @@ int board_interface_eth_init(struct udevice *dev, phy_interface_t interface_type device_is_compatible(dev, "nxp,imx93-dwmac-eqos")) return imx93_eqos_interface_init(dev, interface_type); + if (IS_ENABLED(CONFIG_IMX93) && + IS_ENABLED(CONFIG_FEC_MXC) && + device_is_compatible(dev, "fsl,imx93-fec")) + return 0; + return -EINVAL; } -- 2.25.1

3 2

[RFC] Drop md5sum, crc32 and sha1 cmds in favor of hash cmd
by Igor Opaniuk 08 Feb '24

08 Feb '24

Hello, I was playing a bit with different hash functions recently, and it turned out that md5sum, crc32, sha1 cmds just duplicate what is already covered by generic `hash` cmd. => sha1 0x60000000 0x200 sha1 for 60000000 ... 600001ff ==> 4ff5ffc91d00a95155518b920f46e2483d0e1437 => hash sha1 0x60000000 0x200 sha1 for 60000000 ... 600001ff ==> 4ff5ffc91d00a95155518b920f46e2483d0e1437 => crc32 0x60000000 0x200 crc32 for 60000000 ... 600001ff ==> 6fe352e8 => hash crc32 0x60000000 0x200 crc32 for 60000000 ... 600001ff ==> 6fe352e8 => md5sum 0x60000000 0x200 md5 for 60000000 ... 600001ff ==> e6bbbe95f5b41996f4a9b9af7bbd4050 => hash md5 0x60000000 0x200 md5 for 60000000 ... 600001ff ==> e6bbbe95f5b41996f4a9b9af7bbd4050 Considering that most of them (besides md5sum) are using the same int hash_command() function under the hood, but have a lot of duplicated code for handling params, does it make sense to do some cleanup and drop all them in favour `hash`? I also plan to extend usage info for `hash` by adding a list compiled-in algos based on hash related compiled flags (CONFIG_SHA1, CONFIG_CRC32 etc), so it's clear what algos are available for hash calculation. Comments/objections are welcome! Regards, Igor -- Best regards - Freundliche Grüsse - Meilleures salutations Igor Opaniuk mailto: igor.opaniuk(a)gmail.com skype: igor.opanyuk +48 666 108 041 http://ua.linkedin.com/in/iopaniuk

3 5

[PATCH 0/2] smbios: fill wake-up type
by Heinrich Schuchardt 08 Feb '24

08 Feb '24

We should not use the reserved value 0x00 for the wake up type but use 0x06 (Power Switch). Correctly display wake-up type in smbios command. Display SMBIOS type 1 field family in smbios command. Heinrich Schuchardt (2): cmd: smbios: type 1 wake-up time, family smbios: fill wake-up type cmd/smbios.c | 25 +++++++++++++++++++++++-- include/smbios.h | 2 ++ lib/smbios.c | 1 + 3 files changed, 26 insertions(+), 2 deletions(-) -- 2.43.0

2 3

[PATCH v1] vexpress_ca9x4: Enable DM_SERIAL
by Ole P. Orhagen 08 Feb '24

08 Feb '24

This commit enables support for DM_SERIAL in the vexpress_ca9x4 boards. When running the board with the DM_SERIAL driver, the board ran out of memory in SPL when initialising the DM serial driver. Thus this required an increase in the pre-allocated SRAM memory. I did increase it to 0x800, and it now works graciously. It could probably be set lower, but I do not see any reason not to use the available SRAM at this point. Also adds stdout-path to the 'chosen' node in the device tree. Signed-off-by: Ole P. Orhagen <ole.orhagen(a)northern.tech> --- arch/arm/Kconfig | 2 +- arch/arm/dts/vexpress-v2p-ca9.dts | 4 +++- configs/vexpress_ca9x4_defconfig | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index abd7c6c79a..8e9aaf70d2 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -678,7 +678,7 @@ config ARCH_BCMBCA config TARGET_VEXPRESS_CA9X4 bool "Support vexpress_ca9x4" select CPU_V7A - select PL011_SERIAL + select PL01X_SERIAL config TARGET_BCMNS bool "Support Broadcom Northstar" diff --git a/arch/arm/dts/vexpress-v2p-ca9.dts b/arch/arm/dts/vexpress-v2p-ca9.dts index bf00c62bcf..e5b86c0d67 100644 --- a/arch/arm/dts/vexpress-v2p-ca9.dts +++ b/arch/arm/dts/vexpress-v2p-ca9.dts @@ -20,7 +20,9 @@ #address-cells = <1>; #size-cells = <1>; - chosen { }; + chosen { + stdout-path = &v2m_serial0; + }; aliases { serial0 = &v2m_serial0; diff --git a/configs/vexpress_ca9x4_defconfig b/configs/vexpress_ca9x4_defconfig index 2601e55ebf..f8e93bef4e 100644 --- a/configs/vexpress_ca9x4_defconfig +++ b/configs/vexpress_ca9x4_defconfig @@ -2,7 +2,7 @@ CONFIG_ARM=y CONFIG_SYS_L2CACHE_OFF=y CONFIG_TARGET_VEXPRESS_CA9X4=y CONFIG_TEXT_BASE=0x60800000 -CONFIG_SYS_MALLOC_F_LEN=0x400 +CONFIG_SYS_MALLOC_F_LEN=0x800 CONFIG_NR_DRAM_BANKS=2 CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x60000f10 @@ -41,6 +41,7 @@ CONFIG_ARM_PL180_MMCI=y CONFIG_SYS_MMC_MAX_BLK_COUNT=127 CONFIG_MTD=y CONFIG_DM_MTD=y +CONFIG_DM_SERIAL=y CONFIG_MTD_NOR_FLASH=y CONFIG_SYS_FLASH_CFI_WIDTH_32BIT=y CONFIG_FLASH_SHOW_PROGRESS=0 -- 2.43.0

5 9

[PATCH v3] rng: Add Turris Mox rTWM RNG driver
by Max Resch 08 Feb '24

08 Feb '24

A RNG driver for Armada 3720 boards running the Turris Mox rWTM firmware from CZ.NIC in the secure processor. Signed-off-by: Max Resch <resch.max(a)gmail.com> --- Changes in v3: - More meaningful variable names in accordance with review Changes in v2: - Removed ring buffer implementation drivers/rng/turris_rwtm_rng.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/rng/turris_rwtm_rng.c b/drivers/rng/turris_rwtm_rng.c index 143fe0b47f..ec2cb0bca3 100644 --- a/drivers/rng/turris_rwtm_rng.c +++ b/drivers/rng/turris_rwtm_rng.c @@ -41,18 +41,19 @@ static int turris_rwtm_rng_fill_entropy(phys_addr_t entropy, size_t size) static int turris_rwtm_rng_random_read(struct udevice *dev, void *data, size_t count) { - phys_addr_t p; + struct turris_rwtm_rng_priv *priv = dev_get_priv(dev); + phys_addr_t phys; size_t size; int ret; - p = ((struct turris_rwtm_rng_priv *)dev_get_priv(dev))->buffer; + phys = priv->buffer; while (count) { size = min_t(size_t, RNG_BUFFER_SIZE, count); - ret = turris_rwtm_rng_fill_entropy(p, size); + ret = turris_rwtm_rng_fill_entropy(phys, size); - memcpy(data, (void *)p, size); + memcpy(data, (void *)phys, size); count -= size; data = (u8 *)data + size; } @@ -62,7 +63,7 @@ static int turris_rwtm_rng_random_read(struct udevice *dev, void *data, size_t c static int turris_rwtm_rng_probe(struct udevice *dev) { - struct turris_rwtm_rng_priv *priv; + struct turris_rwtm_rng_priv *priv = dev_get_priv(dev); u32 args[] = { 0 }; int ret; @@ -76,7 +77,6 @@ static int turris_rwtm_rng_probe(struct udevice *dev) return ret; /* entropy buffer */ - priv = (struct turris_rwtm_rng_priv *)dev_get_priv(dev); priv->buffer = 0; /* buffer address need to be aligned */ @@ -89,10 +89,10 @@ static int turris_rwtm_rng_probe(struct udevice *dev) static int turris_rwtm_rng_remove(struct udevice *dev) { - phys_addr_t p; + struct turris_rwtm_rng_priv *priv = dev_get_priv(dev); + phys_addr_t phys = priv->buffer; - p = ((struct turris_rwtm_rng_priv *)dev_get_priv(dev))->buffer; - dma_free_coherent((void *)p); + dma_free_coherent((void *)phys); return 0; } -- 2.43.0

2 1

[PATCH 00/10] ECC Series
by Santhosh Kumar K 08 Feb '24

08 Feb '24

This series is to: 1. Enable ECC priming with BIST engine (Patch 1) 2. Add a function to store base address and size of RAM's banks in a 64 bit device private data (Patch 2) 3. Setup the ECC region start and range (Patch 3) 4. Enable ECC 1 bit error, 2 bit error and multiple bit error interrupts (Patch 4) 5. Add CONFIG_K3_INLINE_ECC (Patch 5) 6. Pull the redundant DDR functions to a common location (Patch 6) 7. Remove redundant DDR functions (Patch 7, 8) 8. Fixup DDR size when ECC is enabled (Patch 9) 9. Add ss_cfg reg entry (Patch 10) Tested on AM62X and AM62A, results: AM62X: https://gist.github.com/santhosh21/c5f07cd921bd2b12d12385f22c698ee6 AM62A: https://gist.github.com/santhosh21/e5fa684d890d65b4034346435213ec8b Things to look in the test log: 1. Time-taken for priming 2. Fixed up DDR size (RAM size =- ECC reserved space). Thanks and Regards, Santhosh. Georgi Vlaev (1): ram: k3-ddrss: Use the DDR controller BIST engine for ECC priming Neha Malcom Francis (1): drivers: ram: Kconfig: Add CONFIG_K3_INLINE_ECC Santhosh Kumar K (8): ram: k3-ddrss: Add k3_ddrss_ddr_bank_base_size_calc() to solve 'calculations restricted to 32 bits' issue ram: k3-ddrss: Setup ECC region start and range ram: k3-ddrss: Enable ECC interrupts board: ti: common: k3-ddr-init: Pull redundant DDR functions to a common location board: ti: am64x: evm: Remove redundant DDR functions board: ti: am62x: evm: Remove redundant DDR functions board: ti: am62ax: evm: Fixup DDR size when ECC is enabled arm: dts: k3-am62a-ddr: Add ss_cfg reg entry arch/arm/dts/k3-am62a-ddr.dtsi | 7 +- board/ti/am62ax/evm.c | 16 +-- board/ti/am62x/evm.c | 61 +--------- board/ti/am64x/evm.c | 71 +---------- board/ti/common/k3-ddr-init.c | 75 ++++++++++++ board/ti/common/k3-ddr-init.h | 15 +++ drivers/ram/Kconfig | 11 ++ drivers/ram/k3-ddrss/k3-ddrss.c | 209 +++++++++++++++++++++++++++----- 8 files changed, 307 insertions(+), 158 deletions(-) create mode 100644 board/ti/common/k3-ddr-init.c create mode 100644 board/ti/common/k3-ddr-init.h -- 2.34.1

1 11

[PATCH v2 0/3] usb: ehci-generic: setup a bulk of phy when possible
by Yang Xiwen via B4 Relay 07 Feb '24

07 Feb '24

one USB controller can have multiple ports specified in dts, all of them should be setup to make use of all possible ports. Signed-off-by: Yang Xiwen <forbidden405(a)outlook.com> --- Changes in v2: - Rewrite generic_phy_setup_bulk(): Actually v1 is doing things completely wrong. This series should work and it's tested on a real machine. - Link to v1: https://lore.kernel.org/r/20240201-ehci-v1-0-bb506cb0f64d@outlook.com --- Yang Xiwen (3): phy: add generic_setup(shutdown)_phy_bulk() test: phy: test generic_setup(shutdown)_phy_bulk() usb: ehci: Make usage of generic_{setup,shutdown}_phy_bulk() helpers drivers/phy/phy-uclass.c | 41 +++++++++++++++++++++++++++++++++++++++++ drivers/usb/host/ehci-generic.c | 8 ++++---- include/generic-phy.h | 29 +++++++++++++++++++++++++++++ test/dm/phy.c | 4 ++++ 4 files changed, 78 insertions(+), 4 deletions(-) --- base-commit: b6d8969bcb94321dfed1399f2eaa8768ba42caaa change-id: 20240201-ehci-6c3aa7d97932 Best regards, -- Yang Xiwen <forbidden405(a)outlook.com>

1 3

imx93-var-som: ahab: U-boot is hanging
by Mathieu Othacehe 07 Feb '24

07 Feb '24

Hello, I am using the imx93-var-som_defconfig configuration on commit v2024.04-rc1. When producing signed or unsigned images on an unclosed board everything works fine. However, once the board is closed (ahab_close command is issued), u-boot hangs this way: --8<---------------cut here---------------start------------->8--- U-Boot SPL 2024.04-rc1-00004-g8494a62b246-dirty (Feb 06 2024 - 15:24:49 +0100) SOC: 0xa0009300 LC: 0x40040 M33 prepare ok Normal Boot Trying to boot from BOOTROM Boot Stage: USB boot NOTICE: BL31: v2.6(release):d8bc791fb NOTICE: BL31: Built : 18:11:44, Mar 15 2023 U-Boot 2024.04-rc1-00004-g8494a62b246-dirty (Feb 06 2024 - 15:24:49 +0100) U-Boot code: 80200000 -> 802B4328 BSS: -> 802BA420 CPU: i.MX93 rev1.0 Model: Variscite VAR-SOM-MX93 on Symphony evaluation board DRAM: Monitor len: 000BA420 Ram size: 80000000 Ram top: 100000000 Reserving 745k for U-Boot at: fff25000 Reserving 32784k for malloc() at: fdf21000 Reserving 152 Bytes for Board Info at: fdf20f60 Reserving 480 Bytes for Global Data at: fdf20d80 Reserving 24832 Bytes for FDT at: fdf1ac80 RAM Configuration: Bank #0: 80000000 2 GiB Bank #1: 0 0 Bytes DRAM: 2 GiB New Stack Pointer is: fdf1ac70 Relocation Offset is: 7fd25000 Relocating to fff25000, new gd at fdf20d80, sp at fdf1ac70 Added memory mapping (5): 80000000 80000000 Pre-reloc malloc() used 0x17478 bytes (93 KB) before mem_malloc_init --8<---------------cut here---------------end--------------->8--- It seems that signature checking is OK because both the SPL and regular u-boot are started. However, something seems to cause u-boot to hang. Here I am hanging in initr_malloc function, right in the mem_malloc_init call: --8<---------------cut here---------------start------------->8--- static int initr_malloc(void) { ulong start; #if CONFIG_IS_ENABLED(SYS_MALLOC_F) debug("Pre-reloc malloc() used %#lx bytes (%ld KB)\n", gd->malloc_ptr, gd->malloc_ptr / 1024); #endif /* The malloc area is immediately below the monitor copy in DRAM */ /* * This value MUST match the value of gd->start_addr_sp in board_f.c: * reserve_noncached(). */ start = gd->relocaddr - TOTAL_MALLOC_LEN; gd_set_malloc_start(start); debug("before mem_malloc_init\n"); mem_malloc_init((ulong)map_sysmem(start, TOTAL_MALLOC_LEN), TOTAL_MALLOC_LEN); debug("after mem_malloc_init\n"); return 0; } --8<---------------cut here---------------end--------------->8--- If I add initcall traces, then I'm not going that far: --8<---------------cut here---------------start------------->8--- U-Boot SPL 2024.04-rc1-00004-g8494a62b246-dirty (Feb 06 2024 - 15:06:54 +0100) SOC: 0xa0009300 LC: 0x40040 M33 prepare ok Normal Boot Trying to boot from BOOTROM Boot Stage: USB boot NOTICE: BL31: v2.6(release):d8bc791fb NOTICE: BL31: Built : 18:11:44, Mar 15 2023 initcall: 000000008027189c U-Boot 2024.04-rc1-00004-g8494a62b246-dirty (Feb 06 2024 - 15:06:54 +0100) initcall: 000000008022481c U-Boot code: 80200000 -> 802B43C0 BSS: -> 802BA4A0 initcall: 0000000080224654 initcall: 0000000080203844 CPU: i.MX93 rev1.0 initcall: 0000000080224fdc Model: Variscite VAR-SOM-MX93 on Symphony evaluation board initcall: event 8/(unknown) initcall: 0000000080224850 DRAM: initcall: 00000000802035a8 initcall: 0000000080224bb8 Monitor len: 000BA4A0 Ram size: 80000000 Ram top: 100000000 initcall: 0000000080224640 initcall: 00000000802248b8 initcall: 0000000080202e24 initcall: 00000000802248c0 initcall: 00000000802248c8 initcall: 00000000802247b4 Reserving 745k for U-Boot at: fff25000 initcall: 0000000080224968 Reserving 32784k for malloc() at: fdf21000 initcall: 0000000080224908 Reserving 152 Bytes for Board Info at: fdf20f60 initcall: 00000000802249a8 Reserving 480 Bytes for Global Data at: fdf20d80 initcall: 0000000080224744 Reserving 24832 Bytes for FDT at: fdf1ac80 initcall: 00000000802248d0 initcall: 00000000802248d8 initcall: 00000000802248f8 initcall: 0000000080224c30 initcall: 00000000802035e0 initcall: 00000000802249ec RAM Configuration: Bank #0: 80000000 2 GiB Bank #1: 0 0 Bytes DRAM: 2 GiB initcall: 0000000080224c44 initcall: 0000000080224720 New Stack Pointer is: fdf1ac70 initcall: 000000008022465c initcall: 00000000802248e0 initcall: 00000000802248e8 initcall: 00000000802246a0 Relocation Offset is: 7fd25000 Relocating to fff25000, new gd at fdf20d80, sp at fdf1ac70 initcall: 0000000080224900 initcall: 0000000080227704 initcall: 00000000fff49c8c initcall: 00000000fff49c94 initcall: 00000000fff4c8c0 initcall: 00000000fff49f54 Added memory mapping (5): 80000000 80000000 initcall: 00000000fff49f04 initcall: 00000000fff49f74 initcall: 00000000fff49ea4 Pre-r --8<---------------cut here---------------end--------------->8--- and I am stopping in the process of writing the "Pre-reloc ..." trace. All-in-all, fusing the board seems to change something causing the previously working images (on a non-closed board) to stop working. Does it ring a bell to anyone? Thanks, Mathieu

1 1

[PATCH 0/9] sysinfo: Expand sysinfo with some more banner information
by Simon Glass 07 Feb '24

07 Feb '24

The show_board_info() function was adjusted to weak so that it could be entirely replaced with a board-specific implementation. The intended way for boards to provide their own information is via a sysinfo driver. But currently there is no way to show anything other than the model name. This series adds support for showing a few more items, in a way that is easy for boards to extend. Since there is already a weak checkboard() function, we don't need to have two levels of weak function here. So this series drops the weak attribute from show_board_info() Existing boards will see a slight change in output, in that the model name will appear first, before any custom output. If that is a problem, then the solution is to implement a sysinfo driver for the board. Simon Glass (9): board: Move show_board_info() comment to header file meson: Use checkboard() instead of show_board_info() turris: Use checkboard() instead of show_board_info() solidrun: Use checkboard() instead of show_board_info() toradex: Use checkboard() instead of show_board_info() udoo: Use checkboard() instead of show_board_info() Revert "generic-board: make show_board_info a weak function" sysinfo: Allow displaying more info on startup x86: coreboot: Add a sysinfo driver arch/arm/mach-meson/board-info.c | 2 +- arch/x86/cpu/coreboot/Kconfig | 2 + arch/x86/dts/coreboot.dts | 4 + board/CZ.NIC/turris_mox/turris_mox.c | 2 +- board/CZ.NIC/turris_omnia/turris_omnia.c | 2 +- board/coreboot/coreboot/Makefile | 1 + board/coreboot/coreboot/coreboot.c | 44 --------- board/coreboot/coreboot/sysinfo.c | 89 +++++++++++++++++++ board/solidrun/mx6cuboxi/mx6cuboxi.c | 7 +- board/toradex/apalis-imx8/apalis-imx8.c | 2 +- board/toradex/apalis-tk1/apalis-tk1.c | 2 +- board/toradex/apalis_imx6/apalis_imx6.c | 3 +- board/toradex/apalis_t30/apalis_t30.c | 2 +- .../toradex/colibri-imx6ull/colibri-imx6ull.c | 2 +- board/toradex/colibri-imx8x/colibri-imx8x.c | 2 +- board/toradex/colibri_imx6/colibri_imx6.c | 3 +- board/toradex/colibri_imx7/colibri_imx7.c | 2 +- board/toradex/colibri_t20/colibri_t20.c | 2 +- board/toradex/colibri_t30/colibri_t30.c | 2 +- board/toradex/colibri_vf/colibri_vf.c | 2 +- board/toradex/common/tdx-common.c | 2 +- board/toradex/common/tdx-common.h | 1 + board/udoo/neo/neo.c | 2 +- common/board_info.c | 80 +++++++++++------ drivers/sysinfo/Kconfig | 7 ++ include/init.h | 11 +++ include/sysinfo.h | 3 + 27 files changed, 189 insertions(+), 94 deletions(-) create mode 100644 board/coreboot/coreboot/sysinfo.c -- 2.42.0.869.gea05f2083d-goog

4 16

[PATCH] blk: host_dev: Fix error code in host_sb_attach_file()
by Dan Carpenter 07 Feb '24

07 Feb '24

This error path should return -EINVAL instead of success. Fixes: e261fbf34785 ("blk: host_dev: Sanity check on the size of host backing file") Signed-off-by: Dan Carpenter <dan.carpenter(a)linaro.org> --- drivers/block/host_dev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/block/host_dev.c b/drivers/block/host_dev.c index 30c74157934a..52313435a0cb 100644 --- a/drivers/block/host_dev.c +++ b/drivers/block/host_dev.c @@ -61,6 +61,7 @@ static int host_sb_attach_file(struct udevice *dev, const char *filename) if (size % desc->blksz) { printf("The size of host backing file '%s' is not multiple of " "the device block size\n", filename); + ret = -EINVAL; goto err_fname; } desc->lba = size / desc->blksz; -- 2.43.0

2 1