February 2024 - U-Boot

[PATCH 0/2] net: ti: am65-cpsw / cpsw-mdio: Switch to DM MDIO
by Roger Quadros 27 Feb '24

27 Feb '24

Hi, This converts cpsw-mdio into a proper Driver Model driver and introduces the new Config symbol CONFIG_MDIO_TI_CPSW. It also cleans up the am65-cpsw driver so it porperly uses the DM PHY interface. It does not convert the legacy cpsw and keystone-net drivers. Tested on AM64-EVM and AM335x BeagleBone. AM64-EVM network doesn't work at 1G but only at 100M. This limitation exists prior to this patch. CI tests: https://github.com/u-boot/u-boot/pull/491 Signed-off-by: Roger Quadros <rogerq(a)kernel.org> --- Roger Quadros (2): net: mdio: Handle bus level GPIO Reset net: am65-cpsw: cpsw_mdio: Switch to proper DM_MDIO framework drivers/net/ti/Kconfig | 8 ++ drivers/net/ti/Makefile | 3 +- drivers/net/ti/am65-cpsw-nuss.c | 190 ++------------------------------------ drivers/net/ti/cpsw_mdio.c | 198 +++++++++++++++++++++++++++++++++++----- drivers/net/ti/cpsw_mdio.h | 2 + include/phy.h | 7 ++ net/mdio-uclass.c | 37 +++++++- 7 files changed, 239 insertions(+), 206 deletions(-) --- base-commit: e4013bcb10f604ec1dfe955634d57e1fc336b15f change-id: 20240216-for-2024-07-am65-cpsw-mdio-e3c15b297442 Best regards, -- Roger Quadros <rogerq(a)kernel.org>

2 5

[PATCH 0/6] USB keyboard improvements for asahi / desktop systems
by Janne Grunau via B4 Relay 27 Feb '24

27 Feb '24

Apple USB Keyboards from 2021 need quirks to be useable. The boot HID keyboard protocol is unfortunately not described in the first interface descriptor but the second. This needs several changes. The USB keyboard driver has to look at all (2) interface descriptors during probing. Since I didn't want to rebuild the USB driver probe code the Apple keyboards are bound to the keyboard driver via USB vendor and product IDs. To make the keyboards useable on Apple silicon devices the xhci driver needs to initializes rings for the endpoints of the first two interface descriptors. If this is causes concerns regarding regressions or memory use the USB_MAX_ACTIVE_INTERFACES define could be turned into a CONFIG option. Even after this changes the keyboards still do not probe successfully since they apparently do not behave HID standard compliant. They only generate reports on key events. This leads the final check whether the keyboard is operational to fail unless the user presses keys during the probe. Skip this check for known keyboards. Keychron seems to emulate Apple keyboards (some models even "re-use" Apple's USB vendor ID) so apply this quirk as well. Some devices like Yubikeys emulate a keyboard. since u-boot only binds a single keyboard block this kind of devices from the USB keyboard driver. Signed-off-by: Janne Grunau <j(a)jannau.net> --- Hector Martin (1): usb: kbd: Ignore Yubikeys Janne Grunau (5): usb: xhci: refactor xhci_set_configuration usb: xhci: Set up endpoints for the first 2 interfaces usb: xhci: Abort transfers with unallocated rings usb: kbd: support Apple Magic Keyboards (2021) usb: kbd: Add probe quirk for Apple and Keychron keyboards common/usb_kbd.c | 80 +++++++++++++++++++++++++-- drivers/usb/host/xhci-ring.c | 5 ++ drivers/usb/host/xhci.c | 126 +++++++++++++++++++++++++++---------------- include/usb.h | 6 +++ 4 files changed, 167 insertions(+), 50 deletions(-) --- base-commit: 37345abb97ef0dd9c50a03b2a72617612dcae585 change-id: 20240218-asahi-keyboards-f2ddaf0022b2 Best regards, -- Janne Grunau <j(a)jannau.net>

4 23

[PATCH] arm64: zynqmp: Add label to pmu fwnode
by lukas.funke-oss＠weidmueller.com 27 Feb '24

27 Feb '24

From: Lukas Funke <lukas.funke(a)weidmueller.com> Some zynqmp SoCs (the cg series) only have two cpus. Thus, for some cases the cpu-affinity has to adapted, because cpu3 and cpu4 are missing. By adding a label to the pmu fwnode the cpu affinity can be adapted in a device specific dt. Signed-off-by: Lukas Funke <lukas.funke(a)weidmueller.com> --- arch/arm/dts/zynqmp.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/dts/zynqmp.dtsi b/arch/arm/dts/zynqmp.dtsi index b50b83b772..457f8e394f 100644 --- a/arch/arm/dts/zynqmp.dtsi +++ b/arch/arm/dts/zynqmp.dtsi @@ -168,7 +168,7 @@ bootph-all; }; - pmu { + pmu: pmu { compatible = "arm,armv8-pmuv3"; interrupt-parent = <&gic>; interrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>, -- 2.39.2

3 3

[ANN] U-Boot v2024.04-rc3 released
by Tom Rini 27 Feb '24

27 Feb '24

Hey all, It's late in the day, but still release day and so here's -rc3. I've also pushed this to the next branch and that is now open. In terms of a changelog, git log --merges v2024.04-rc2..v2024.04-rc3 contains what I've pulled but as always, better PR messages and tags will provide better results here. I hope to get back on schedule and that means the rest of the rcs every other Monday, and with final release on Tuesday, April 2nd, 2024. Thanks all! -- Tom

1 0

[PATCH RESEND] serial: pl01x: set baudrate when probing
by Yang Xiwen via B4 Relay 27 Feb '24

27 Feb '24

From: Yang Xiwen <forbidden405(a)outlook.com> It is found that when DM is enabled, only generic init function is called in .probe(). Baudrate is never honored. Add a function call to .setbrg() when probing so that we can update the baudrate of the serial device. Signed-off-by: Yang Xiwen <forbidden405(a)outlook.com> --- drivers/serial/serial_pl01x.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/serial/serial_pl01x.c b/drivers/serial/serial_pl01x.c index 428a4d210de5..57bbcaf3b619 100644 --- a/drivers/serial/serial_pl01x.c +++ b/drivers/serial/serial_pl01x.c @@ -290,6 +290,7 @@ int pl01x_serial_probe(struct udevice *dev) { struct pl01x_serial_plat *plat = dev_get_plat(dev); struct pl01x_priv *priv = dev_get_priv(dev); + int ret; #if CONFIG_IS_ENABLED(OF_PLATDATA) struct dtd_serial_pl01x *dtplat = &plat->dtplat; @@ -301,10 +302,14 @@ int pl01x_serial_probe(struct udevice *dev) #endif priv->type = plat->type; - if (!plat->skip_init) - return pl01x_generic_serial_init(priv->regs, priv->type); - else + if (!plat->skip_init) { + ret = pl01x_generic_serial_init(priv->regs, priv->type); + if (!ret) + return ret; + return pl01x_serial_setbrg(dev, gd->baudrate); + } else { return 0; + } } int pl01x_serial_getc(struct udevice *dev) --- base-commit: f7cca7ccc5117eaafcc2bde91ad1bed6fee7cfc3 change-id: 20240123-b4-pl011-ee9575ff2a38 Best regards, -- Yang Xiwen <forbidden405(a)outlook.com>

3 2

[PATCH] efi_loader: Don't carve out memory reservations too early
by Mark Kettenis 26 Feb '24

26 Feb '24

Moving the efi_carve_out_dt_rsv() call in commit 1be415b21b2d ("efi_loader: create memory reservations in ACPI case") broke boards that create additional memory reservations in ft_board_setup() since it is now called before those additional memory reservations are made. This is the case for the rk3588 boards and breaks booting OpenBSD on those boards. Move the call back to its original location and add a call in the code path used for ACPI. Fixes: 1be415b21b2d ("efi_loader: create memory reservations in ACPI case") Signed-off-by: Mark Kettenis <kettenis(a)openbsd.org> --- lib/efi_loader/efi_helper.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/lib/efi_loader/efi_helper.c b/lib/efi_loader/efi_helper.c index 5dd9cc876e..58761fae78 100644 --- a/lib/efi_loader/efi_helper.c +++ b/lib/efi_loader/efi_helper.c @@ -456,11 +456,11 @@ efi_status_t efi_install_fdt(void *fdt) return EFI_LOAD_ERROR; } - /* Create memory reservations as indicated by the device tree */ - efi_carve_out_dt_rsv(fdt); - - if (CONFIG_IS_ENABLED(GENERATE_ACPI_TABLE)) + if (CONFIG_IS_ENABLED(GENERATE_ACPI_TABLE)) { + /* Create memory reservations as indicated by the device tree */ + efi_carve_out_dt_rsv(fdt); return EFI_SUCCESS; + } /* Prepare device tree for payload */ ret = copy_fdt(&fdt); @@ -474,6 +474,9 @@ efi_status_t efi_install_fdt(void *fdt) return EFI_LOAD_ERROR; } + /* Create memory reservations as indicated by the device tree */ + efi_carve_out_dt_rsv(fdt); + efi_try_purge_kaslr_seed(fdt); if (CONFIG_IS_ENABLED(EFI_TCG2_PROTOCOL_MEASURE_DTB)) { -- 2.43.0

3 4

[PATCH v2] efi_loader: Don't carve out memory reservations too early
by Mark Kettenis 26 Feb '24

26 Feb '24

Moving the efi_carve_out_dt_rsv() call in commit 1be415b21b2d ("efi_loader: create memory reservations in ACPI case") broke boards that create additional memory reservations in ft_board_setup() since it is now called before those additional memory reservations are made. This is the case for the rk3588 boards and breaks booting OpenBSD on those boards. Move the call back to its original location and add a call in the code path used for ACPI after calling image_setup_libfdt() such that memory reservations made by ft_board_setup() are applied when booting with ACPI too. Fixes: 1be415b21b2d ("efi_loader: create memory reservations in ACPI case") Signed-off-by: Mark Kettenis <kettenis(a)openbsd.org> --- ChangeLog: v2: - Call image_setup_libfdt() in the ACPI code path lib/efi_loader/efi_helper.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/lib/efi_loader/efi_helper.c b/lib/efi_loader/efi_helper.c index 5dd9cc876e..5f8d9a17fd 100644 --- a/lib/efi_loader/efi_helper.c +++ b/lib/efi_loader/efi_helper.c @@ -456,11 +456,16 @@ efi_status_t efi_install_fdt(void *fdt) return EFI_LOAD_ERROR; } - /* Create memory reservations as indicated by the device tree */ - efi_carve_out_dt_rsv(fdt); + if (CONFIG_IS_ENABLED(GENERATE_ACPI_TABLE)) { + if (image_setup_libfdt(&img, fdt, NULL)) { + log_err("ERROR: failed to process device tree\n"); + return EFI_LOAD_ERROR; + } - if (CONFIG_IS_ENABLED(GENERATE_ACPI_TABLE)) + /* Create memory reservations as indicated by the device tree */ + efi_carve_out_dt_rsv(fdt); return EFI_SUCCESS; + } /* Prepare device tree for payload */ ret = copy_fdt(&fdt); @@ -474,6 +479,9 @@ efi_status_t efi_install_fdt(void *fdt) return EFI_LOAD_ERROR; } + /* Create memory reservations as indicated by the device tree */ + efi_carve_out_dt_rsv(fdt); + efi_try_purge_kaslr_seed(fdt); if (CONFIG_IS_ENABLED(EFI_TCG2_PROTOCOL_MEASURE_DTB)) { -- 2.43.0

1 0

[PATCH] doc: develop: commands: Fix function prototype
by Alexander Dahl 26 Feb '24

26 Feb '24

When using the previous prototype you got a compiler warning like this: warning: initialization of 'int (*)(struct cmd_tbl *, int, int, char * const*)' from incompatible pointer type 'int (*)(struct cmd_tbl *, int, int, const char **)' [-Wincompatible-pointer-types] Fixes: 3d9640f55cb2 ("doc: expand README.commands") Signed-off-by: Alexander Dahl <ada(a)thorsis.com> --- doc/develop/commands.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/develop/commands.rst b/doc/develop/commands.rst index ede880d248c..5ad4e59c838 100644 --- a/doc/develop/commands.rst +++ b/doc/develop/commands.rst @@ -88,7 +88,7 @@ The command function pointer has to be of type .. code-block:: c - int (*cmd)(struct cmd_tbl *cmdtp, int flag, int argc, const char *argv[]); + int (*cmd)(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]); cmdtp Table entry describing the command (see above). base-commit: 1a66a7768af7e8106c2cd93a19f4013877fb85ae -- 2.39.2

1 0

Need help: alternative module inclusion - duplicate symbols
by Michael Lawnick 26 Feb '24

26 Feb '24

Hi group, hope you can help me: I have modules pci_fpga.c and pci_fpga_emul.c with same functions in them but different implementation, one for the real device, the other one is an emulation. What I now want is being able to include one of both versions through build command. I started with this: Makefile.core.def: ... module = { name = pci_fpga; common = startlib/board/pci_fpga.c; enable = efi; }; module = { name = pci_fpga_emul; common = startlib/board/pci_fpga_emul.c; enable = efi; }; ... and then give pci_fpga or pci_fpga_emu on the build but then I get duplicate symbols error. For using different packages than common like this module = { name = pci_fpga; pci_fpga = startlib/board/pci_fpga.c; enable = pci_fpga; }; I could not find means to get pci_fpga included. Same problem if trying to approach it via different enable flag: How to? Can anybody help? In docs I couldn't find usable hints. -- KR Michael

1 1

[PATCH v2 0/1] Agilex5 enablement
by Jit Loon Lim 26 Feb '24

26 Feb '24

V1: https://patchwork.ozlabs.org/project/uboot/patch/20240220143603.22091-1-jit… V2: Fixed Git auto-merge causing misalignment of code and insert/delete Jit Loon Lim (1): arch:arm: Agilex5 enablement arch/arm/Kconfig | 13 +- arch/arm/dts/Makefile | 1 + arch/arm/dts/socfpga_agilex5-u-boot.dtsi | 458 ++++++++++++ arch/arm/dts/socfpga_agilex5.dtsi | 654 ++++++++++++++++++ .../arm/dts/socfpga_agilex5_socdk-u-boot.dtsi | 144 ++++ arch/arm/dts/socfpga_agilex5_socdk.dts | 163 +++++ arch/arm/dts/socfpga_soc64_fit-u-boot.dtsi | 38 +- arch/arm/mach-socfpga/Kconfig | 69 +- arch/arm/mach-socfpga/Makefile | 4 +- arch/arm/mach-socfpga/board.c | 56 +- .../include/mach/base_addr_soc64.h | 44 +- board/intel/agilex5-socdk/MAINTAINERS | 8 + board/intel/agilex5-socdk/Makefile | 7 + configs/socfpga_agilex5_defconfig | 113 +++ include/configs/socfpga_agilex5_socdk.h | 12 + include/configs/socfpga_soc64_common.h | 209 +++++- 16 files changed, 1957 insertions(+), 36 deletions(-) create mode 100644 arch/arm/dts/socfpga_agilex5-u-boot.dtsi create mode 100644 arch/arm/dts/socfpga_agilex5.dtsi create mode 100644 arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi create mode 100644 arch/arm/dts/socfpga_agilex5_socdk.dts create mode 100644 board/intel/agilex5-socdk/MAINTAINERS create mode 100644 board/intel/agilex5-socdk/Makefile create mode 100644 configs/socfpga_agilex5_defconfig create mode 100644 include/configs/socfpga_agilex5_socdk.h -- 2.26.2

2 2