October 2024 - U-Boot

[PATCH v5] rockchip: board: Increase rng-seed size to make it sufficient for modern Linux
by Alex Shumsky 16 Oct '24

16 Oct '24

Increase rng-seed size to make Linux happy and initialize rng pool instantly. Linux 5.19+ requires 32 bytes of entropy to initialize random pool, but u-boot currently provides only 8 bytes. Linux 5.18 and probably some versions before it used to require 64 bytes. Bump min value to 64 bytes to be on a safe side. Boot with 8 byte rng-seed (Linux 6.11): # dmesg | grep crng [ 12.089286] random: crng init done Boot with 32 byte rng-seed (Linux 6.11): # dmesg | grep crng [ 0.000000] random: crng init done Linux source references: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/dri… https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/dri… Signed-off-by: Alex Shumsky <alexthreed(a)gmail.com> Fixes: d2048bafae40 ("rockchip: board: Add board_rng_seed() for all Rockchip devices") Reviewed-by: Dragan Simic <dsimic(a)manjaro.org> Reviewed-by: Marek Vasut <marex(a)denx.de> --- Changes in v5: - add docs Changes in v4: - fix typos and code style Changes in v3: - reword warning - increase default rng_seed_size to support older linux as well - reword commit message Changes in v2: - add env config knob rng_seed_size - add warning for small rng_seed_size - 12-character commit SHA in Fixes arch/arm/mach-rockchip/board.c | 11 ++++++++++- common/Kconfig | 3 +++ doc/usage/environment.rst | 5 +++++ include/fdt_support.h | 3 ++- 4 files changed, 20 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-rockchip/board.c b/arch/arm/mach-rockchip/board.c index 3fadf7e412..ca6404776f 100644 --- a/arch/arm/mach-rockchip/board.c +++ b/arch/arm/mach-rockchip/board.c @@ -472,9 +472,18 @@ __weak int misc_init_r(void) __weak int board_rng_seed(struct abuf *buf) { struct udevice *dev; - size_t len = 0x8; + ulong len = env_get_ulong("rng_seed_size", 10, 64); u64 *data; + if (len < 64) { + /* + * rng_seed_size should be at least 32 bytes for Linux 5.19+, + * or 64 for older Linux kernel versions + */ + log_warning("Value for rng_seed_size too low (%lu) and likely insufficient for the Linux RNG initialization\n", + len); + } + data = malloc(len); if (!data) { printf("Out of memory\n"); diff --git a/common/Kconfig b/common/Kconfig index 957de0c5c0..c1d06f5045 100644 --- a/common/Kconfig +++ b/common/Kconfig @@ -927,6 +927,9 @@ config BOARD_RNG_SEED new seed for use on subsequent boots, and whether or not the kernel should account any entropy from the given seed. + Default seed size (64 bytes) can be overridden by a decimal environment + variable rng_seed_size. + endmenu menu "Update support" diff --git a/doc/usage/environment.rst b/doc/usage/environment.rst index cc33d3ec0f..253b25a002 100644 --- a/doc/usage/environment.rst +++ b/doc/usage/environment.rst @@ -323,6 +323,11 @@ netretry Useful on scripts which control the retry operation themselves. +rng_seed_size + Size of random value added to device tree-node /chosen/rng-seed. + This variable is given as a hexadecimal number. + If unset, 64 bytes is used as the default. + silent_linux If set then Linux will be told to boot silently, by adding 'console=' to its command line. If "yes" it will be diff --git a/include/fdt_support.h b/include/fdt_support.h index 741e2360c2..02561eab15 100644 --- a/include/fdt_support.h +++ b/include/fdt_support.h @@ -202,7 +202,8 @@ int ft_board_setup(void *blob, struct bd_info *bd); * * This function is called if CONFIG_BOARD_RNG_SEED is set, and must * be provided by the board. It should return, via @buf, some suitable - * seed value to pass to the kernel. + * seed value to pass to the kernel. Seed size could be set in a decimal + * environment variable rng_seed_size and defaulted to 64 bytes. * * @param buf A struct abuf for returning the seed and its size. * @return 0 if ok, negative on error. -- 2.34.1

2 2

[PATCH 0/2] board: libre-computer: Add support for Libre Computer aml-a311d-cc & aml-s905d3-cc boards
by Neil Armstrong 16 Oct '24

16 Oct '24

Add support for the Libre Computer aml-a311d-cc "Alta" & aml-s905d3-cc "Solitude" boards: https://libre.computer/products/aml-a311d-cc/ https://libre.computer/products/aml-s905d3-cc/ The Alta & Solitude boards have a Credit Card form factor, similar to the the previous "Le Potato" card, but with the Amlogic A311D or S903D3 SoCS, MIPI DSI and CSI connectors. PoE header and a single USB2 Type-C connector replacing the microUSB one for power and USB 2.0. The boards have an embedded SPI NOR flash, and EFI Capsule support is added. Signed-off-by: Neil Armstrong <neil.armstrong(a)linaro.org> --- Neil Armstrong (2): ARM: meson: add support for Libre Computer aml-a311d-cc ARM: meson: add support for Libre Computer aml-s905d3-cc .../dts/meson-g12b-a311d-libretech-cc-u-boot.dtsi | 15 +++ .../dts/meson-sm1-s905d3-libretech-cc-u-boot.dtsi | 15 +++ board/libre-computer/aml-a311d-cc/MAINTAINERS | 7 ++ board/libre-computer/aml-a311d-cc/Makefile | 6 ++ board/libre-computer/aml-a311d-cc/aml-a311d-cc.c | 44 +++++++++ board/libre-computer/aml-s905d3-cc/MAINTAINERS | 7 ++ board/libre-computer/aml-s905d3-cc/Makefile | 6 ++ board/libre-computer/aml-s905d3-cc/aml-s905d3-cc.c | 44 +++++++++ configs/aml-a311d-cc_defconfig | 108 +++++++++++++++++++++ configs/aml-s905d3-cc_defconfig | 108 +++++++++++++++++++++ doc/board/amlogic/aml-a311d-cc.rst | 46 +++++++++ doc/board/amlogic/aml-s905d3-cc.rst | 46 +++++++++ doc/board/amlogic/index.rst | 2 + 13 files changed, 454 insertions(+) --- base-commit: 13fd7a17858e5f2555a1d68e4afa75fceda0dac0 change-id: 20240920-u-boot-topic-libre-computer-solitude-alta-c3b22cbd16df Best regards, -- Neil Armstrong <neil.armstrong(a)linaro.org>

2 5

imx8qxp: deneb board fails with current HEAD
by Heiko Schocher 16 Oct '24

16 Oct '24

Hello Peng, I just rebased my current work on siemens deneb board with current master: * d5cab0d6ad - (HEAD -> master, origin/master, origin/WIP/15Oct2024, origin/HEAD) Revert "Makefile: Drop SPL_FIT_GENERATOR / SPL_FIT_SOURCE support" changes (vor 3 Stunden) <Tom Rini> And see: """ U-Boot SPL 2024.10-01044-g91b1263d96d9 (Oct 16 2024 - 07:10:25 +0200) Normal Boot Trying to boot from MMC1 __imx8_clk_enable(Invalid clk ID #0) fsl_esdhc usdhc@5b010000: Failed to enable clks: -22 __imx8_clk_enable(Invalid clk ID #0) fsl_esdhc usdhc@5b010000: Failed to enable clks: -22 spl: could not initialize mmc. error: -22 SPL: failed to boot from all boot devices ### ERROR ### Please RESET the board ### """ Looking around the changes I found your commit: commit 76332fae769acbba49751827ce126b0cb1014b48 Author: Peng Fan <peng.fan(a)nxp.com> Date: Tue Oct 1 21:07:53 2024 +0800 mmc: fsl_esdhc_imx: Enable AHB/IPG clk with clk bulk API With partition reset supported for i.MX8QM/QXP/95 and etc, when linux mmc runtime suspended, the mmc clks are gated off. While at same time system controller reset Cortex-A cores because of various reasons( WDOG timeout and etc), with SPL run again, only enable PER clk is not enough, also need to enable AHB/IPG clk, here use clk bulk API to enable all the clocks. Signed-off-by: Peng Fan <peng.fan(a)nxp.com> reverting it, and board boots fine again! May you have an idea? I try to look deeper soon. (A fast look as I wondered about clk id 0): ./include/dt-bindings/clock/imx8qxp-clock.h #define IMX8QXP_CLK_DUMMY 0 and ./arch/arm/dts/fsl-imx8dx.dtsi 512 usdhc2: usdhc@5b020000 { 513 compatible = "fsl,imx8qm-usdhc", "fsl,imx6sl-usdhc"; [...] 517 clocks = <&clk IMX8QXP_SDHC1_IPG_CLK>, 518 <&clk IMX8QXP_SDHC1_CLK>, 519 <&clk IMX8QXP_CLK_DUMMY>; 520 clock-names = "ipg", "per", "ahb"; So this explains ID 0 ... and with drivers/clk/imx/clk-imx8qxp.c 242 int __imx8_clk_enable(struct clk *clk, bool enable) 243 { [...] 250 switch (clk->id) { 251 case IMX8QXP_I2C0_CLK: no entry for IMX8QXP_CLK_DUMMY ... So I wonder how this can work ... Thanks! bye, Heiko [1] U-Boot SPL 2024.10-01045-g0a08358303ba (Oct 16 2024 - 07:18:23 +0200) Normal Boot Trying to boot from MMC1 Primary set selected Load image from MMC/SD 0x47800 U-Boot 2024.10-01045-g0a08358303ba (Oct 16 2024 - 07:18:23 +0200) ##v01.06 CPU: NXP i.MX8QXP RevC A35 at 1200 MHz at 31C Model: Siemens CXG3 Board: Capricorn Build: SCFW 042ba867, SECO-FW c9de51c0, ATF 2ba2c83 Boot: MMC0 Reset cause: POR DRAM: 2 GiB HW Version: v04.03 Core: 94 devices, 23 uclasses, devicetree: separate WDT: Started scu-wdt without servicing (60s timeout) MMC: FSL_SDHC: 0 Loading Environment from MMC... *** Warning - bad CRC, using default environment Reading from MMC(0)... In: serial@5a080000 Out: serial@5a080000 Err: serial@5a080000 ERROR: PCA9552 probe failed I2C LED init failed Net: eth1: ethernet@5b050000 [PRIME] Autobooting in 3 seconds, press "<Esc><Esc>" to stop U-Boot# U-Boot# -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs(a)denx.de

2 4

[PATCH] Revert "Makefile: Drop SPL_FIT_GENERATOR / SPL_FIT_SOURCE support" changes
by Tom Rini 16 Oct '24

16 Oct '24

:hile we had hoped to be able to remove these options finally, it was missed that zynq still requires these currently. This reverts commit 5b9261fb0b1ed087387f2036d279fd3f4bb20a61 and commit 099b6df556c95f5d06864612e9199eab7ba50ed3. Reported-by: Jonas Karlman <jonas(a)kwiboo.se> Signed-off-by: Tom Rini <trini(a)konsulko.com> --- Makefile | 24 ++++++++++++++++++++++++ boot/Kconfig | 23 +++++++++++++++++++++++ doc/usage/fit/howto.rst | 9 +++++++++ 3 files changed, 56 insertions(+) diff --git a/Makefile b/Makefile index 0005e999a657..3267fb1c469a 100644 --- a/Makefile +++ b/Makefile @@ -1145,6 +1145,13 @@ ifeq ($(CONFIG_OF_EMBED)$(CONFIG_EFI_APP),y) @echo >&2 "CONFIG_OF_SEPARATE for boards in mainline." @echo >&2 "See doc/develop/devicetree/control.rst for more info." @echo >&2 "====================================================" +endif +ifneq ($(CONFIG_SPL_FIT_GENERATOR),) + @echo >&2 "===================== WARNING ======================" + @echo >&2 "This board uses CONFIG_SPL_FIT_GENERATOR. Please migrate" + @echo >&2 "to binman instead, to avoid the proliferation of" + @echo >&2 "arch-specific scripts with no tests." + @echo >&2 "====================================================" endif $(call deprecated,CONFIG_WDT,DM watchdog,v2019.10,\ $(CONFIG_WATCHDOG)$(CONFIG_HW_WATCHDOG)) @@ -1412,6 +1419,23 @@ OBJCOPYFLAGS_u-boot.ldr.srec := -I binary -O srec u-boot.ldr.hex u-boot.ldr.srec: u-boot.ldr FORCE $(call if_changed,objcopy) +# Boards with more complex image requirements can provide an .its source file +# or a generator script +# NOTE: Please do not use this. We are migrating away from Makefile rules to use +# binman instead. +ifneq ($(CONFIG_SPL_FIT_SOURCE),"") +U_BOOT_ITS := u-boot.its +$(U_BOOT_ITS): $(subst ",,$(CONFIG_SPL_FIT_SOURCE)) + $(call if_changed,copy) +else +ifneq ($(CONFIG_USE_SPL_FIT_GENERATOR),) +U_BOOT_ITS := u-boot.its +$(U_BOOT_ITS): $(U_BOOT_ITS_DEPS) FORCE + $(srctree)/$(CONFIG_SPL_FIT_GENERATOR) \ + $(patsubst %,$(dt_dir)/%.dtb,$(subst ",,$(CONFIG_OF_LIST))) > $@ +endif +endif + ifdef CONFIG_SPL_LOAD_FIT MKIMAGEFLAGS_u-boot.img = -f auto -A $(ARCH) -T firmware -C none -O u-boot \ -a $(CONFIG_TEXT_BASE) -e $(CONFIG_SYS_UBOOT_START) \ diff --git a/boot/Kconfig b/boot/Kconfig index 4314227d5f86..925afe06a19f 100644 --- a/boot/Kconfig +++ b/boot/Kconfig @@ -282,6 +282,29 @@ config SPL_FIT_IMAGE_POST_PROCESS injected into the FIT creation (i.e. the blobs would have been pre- processed before being added to the FIT image). +config SPL_FIT_SOURCE + string ".its source file for U-Boot FIT image" + depends on SPL_FIT + help + Specifies a (platform specific) FIT source file to generate the + U-Boot FIT image. This could specify further image to load and/or + execute. + +config USE_SPL_FIT_GENERATOR + bool "Use a script to generate the .its script" + depends on SPL_FIT + default y if SPL_FIT && ARCH_ZYNQMP + +config SPL_FIT_GENERATOR + string ".its file generator script for U-Boot FIT image" + depends on USE_SPL_FIT_GENERATOR + default "arch/arm/mach-zynqmp/mkimage_fit_atf.sh" if SPL_LOAD_FIT && ARCH_ZYNQMP + help + Specifies a (platform specific) script file to generate the FIT + source file used to build the U-Boot FIT image file. This gets + passed a list of supported device tree file stub names to + include in the generated image. + if VPL config VPL_FIT diff --git a/doc/usage/fit/howto.rst b/doc/usage/fit/howto.rst index 675c9aa5bb0f..b5097d4460bf 100644 --- a/doc/usage/fit/howto.rst +++ b/doc/usage/fit/howto.rst @@ -57,6 +57,15 @@ own subnode under the /images node, which should then be referenced from one or multiple /configurations subnodes. The required images must be enumerated in the "loadables" property as a list of strings. +If a platform specific image source file (.its) is shipped with the U-Boot +source, it can be specified using the CONFIG_SPL_FIT_SOURCE Kconfig symbol. +In this case it will be automatically used by U-Boot's Makefile to generate +the image. +If a static source file is not flexible enough, CONFIG_SPL_FIT_GENERATOR +can point to a script which generates this image source file during +the build process. It gets passed a list of device tree files (taken from the +CONFIG_OF_LIST symbol). + The SPL also records to a DT all additional images (called loadables) which are loaded. The information about loadables locations is passed via the DT node with fit-images name. -- 2.43.0

1 1

[PULL] u-boot-usb/master
by Marek Vasut 16 Oct '24

16 Oct '24

The following changes since commit c7aafb20ce9937f1e178ded46d8f22742f54c982: Merge tag 'u-boot-ufs-next-20241014' of https://source.denx.de/u-boot/custodians/u-boot-ufs (2024-10-14 08:15:15 -0600) are available in the Git repository at: git://source.denx.de/u-boot-usb.git master for you to fetch changes up to 3794bbf9e0e7ce2652935514cbfac49545c329a9: usb: xhci: Define 'XHCI_MAX_HALT_USEC' macro only once (2024-10-14 22:17:51 +0200) ---------------------------------------------------------------- Bhupesh Sharma (1): usb: xhci: Define 'XHCI_MAX_HALT_USEC' macro only once Godfrey Mwangi (1): usb: xhci: pet watchdog during transfers drivers/usb/host/xhci-ring.c | 3 +++ include/usb/xhci.h | 2 -- 2 files changed, 3 insertions(+), 2 deletions(-)

2 1

[PATCH 1/2] Makefile: Drop SPL_FIT_SOURCE support
by Marek Vasut 16 Oct '24

16 Oct '24

The SPL_FIT_SOURCE is long superseded by SPL_FIT_GENERATOR which is long superseded by binman, drop SPL_FIT_SOURCE support as there are no more users. Signed-off-by: Marek Vasut <marex(a)denx.de> --- Cc: AKASHI Takahiro <akashi.tkhro(a)gmail.com> Cc: Heinrich Schuchardt <xypron.glpk(a)gmx.de> Cc: Ilias Apalodimas <ilias.apalodimas(a)linaro.org> Cc: Marcel Ziswiler <marcel.ziswiler(a)toradex.com> Cc: Mattijs Korpershoek <mkorpershoek(a)baylibre.com> Cc: Patrice Chotard <patrice.chotard(a)foss.st.com> Cc: Patrick Delaunay <patrick.delaunay(a)foss.st.com> Cc: Peter Robinson <pbrobinson(a)gmail.com> Cc: Quentin Schulz <quentin.schulz(a)cherry.de> Cc: Rasmus Villemoes <rasmus.villemoes(a)prevas.dk> Cc: Sean Anderson <seanga2(a)gmail.com> Cc: Simon Glass <sjg(a)chromium.org> Cc: Sumit Garg <sumit.garg(a)linaro.org> Cc: Tom Rini <trini(a)konsulko.com> Cc: u-boot(a)dh-electronics.com Cc: u-boot(a)lists.denx.de Cc: uboot-stm32(a)st-md-mailman.stormreply.com --- NOTE: Depends on https://lore.kernel.org/u-boot/20241004225916.361000-1-marex@denx.de/ --- Makefile | 6 ------ boot/Kconfig | 8 -------- doc/usage/fit/howto.rst | 11 +++-------- 3 files changed, 3 insertions(+), 22 deletions(-) diff --git a/Makefile b/Makefile index af24de4165e..a70926ec2fa 100644 --- a/Makefile +++ b/Makefile @@ -1417,18 +1417,12 @@ u-boot.ldr.hex u-boot.ldr.srec: u-boot.ldr FORCE # or a generator script # NOTE: Please do not use this. We are migrating away from Makefile rules to use # binman instead. -ifneq ($(CONFIG_SPL_FIT_SOURCE),"") -U_BOOT_ITS := u-boot.its -$(U_BOOT_ITS): $(subst ",,$(CONFIG_SPL_FIT_SOURCE)) - $(call if_changed,copy) -else ifneq ($(CONFIG_USE_SPL_FIT_GENERATOR),) U_BOOT_ITS := u-boot.its $(U_BOOT_ITS): $(U_BOOT_ITS_DEPS) FORCE $(srctree)/$(CONFIG_SPL_FIT_GENERATOR) \ $(patsubst %,$(dt_dir)/%.dtb,$(subst ",,$(CONFIG_OF_LIST))) > $@ endif -endif ifdef CONFIG_SPL_LOAD_FIT MKIMAGEFLAGS_u-boot.img = -f auto -A $(ARCH) -T firmware -C none -O u-boot \ diff --git a/boot/Kconfig b/boot/Kconfig index 925afe06a19..51e6cd6cb1d 100644 --- a/boot/Kconfig +++ b/boot/Kconfig @@ -282,14 +282,6 @@ config SPL_FIT_IMAGE_POST_PROCESS injected into the FIT creation (i.e. the blobs would have been pre- processed before being added to the FIT image). -config SPL_FIT_SOURCE - string ".its source file for U-Boot FIT image" - depends on SPL_FIT - help - Specifies a (platform specific) FIT source file to generate the - U-Boot FIT image. This could specify further image to load and/or - execute. - config USE_SPL_FIT_GENERATOR bool "Use a script to generate the .its script" depends on SPL_FIT diff --git a/doc/usage/fit/howto.rst b/doc/usage/fit/howto.rst index b5097d4460b..280eff724f6 100644 --- a/doc/usage/fit/howto.rst +++ b/doc/usage/fit/howto.rst @@ -57,14 +57,9 @@ own subnode under the /images node, which should then be referenced from one or multiple /configurations subnodes. The required images must be enumerated in the "loadables" property as a list of strings. -If a platform specific image source file (.its) is shipped with the U-Boot -source, it can be specified using the CONFIG_SPL_FIT_SOURCE Kconfig symbol. -In this case it will be automatically used by U-Boot's Makefile to generate -the image. -If a static source file is not flexible enough, CONFIG_SPL_FIT_GENERATOR -can point to a script which generates this image source file during -the build process. It gets passed a list of device tree files (taken from the -CONFIG_OF_LIST symbol). +CONFIG_SPL_FIT_GENERATOR can point to a script which generates this image source +file during the build process. It gets passed a list of device tree files (taken +from the CONFIG_OF_LIST symbol). The SPL also records to a DT all additional images (called loadables) which are loaded. The information about loadables locations is passed via the DT node with -- 2.45.2

5 9

[PATCH] CI: Do not test "sleep" in QEMU
by Tom Rini 16 Oct '24

16 Oct '24

When we have platforms being emulated by QEMU we cannot rely on the "sleep" command running for the expected wall-clock amount of time. Even with our current allowance for deviation from expected time, it will still fail from time to time. Exclude the sleep test here. Signed-off-by: Tom Rini <trini(a)konsulko.com> --- .azure-pipelines.yml | 9 +++++++++ .gitlab-ci.yml | 9 +++++++++ 2 files changed, 18 insertions(+) diff --git a/.azure-pipelines.yml b/.azure-pipelines.yml index b66d49a62ba0..11f1d5ad20a1 100644 --- a/.azure-pipelines.yml +++ b/.azure-pipelines.yml @@ -400,12 +400,15 @@ stages: evb_ast2500: TEST_PY_BD: "evb-ast2500" TEST_PY_ID: "--id qemu" + TEST_PY_TEST_SPEC: "not sleep" evb_ast2600: TEST_PY_BD: "evb-ast2600" TEST_PY_ID: "--id qemu" + TEST_PY_TEST_SPEC: "not sleep" vexpress_ca9x4: TEST_PY_BD: "vexpress_ca9x4" TEST_PY_ID: "--id qemu" + TEST_PY_TEST_SPEC: "not sleep" integratorcp_cm926ejs: TEST_PY_BD: "integratorcp_cm926ejs" TEST_PY_ID: "--id qemu" @@ -464,21 +467,27 @@ stages: r2dplus_i82557c: TEST_PY_BD: "r2dplus" TEST_PY_ID: "--id i82557c_qemu" + TEST_PY_TEST_SPEC: "not sleep" r2dplus_pcnet: TEST_PY_BD: "r2dplus" TEST_PY_ID: "--id pcnet_qemu" + TEST_PY_TEST_SPEC: "not sleep" r2dplus_rtl8139: TEST_PY_BD: "r2dplus" TEST_PY_ID: "--id rtl8139_qemu" + TEST_PY_TEST_SPEC: "not sleep" r2dplus_tulip: TEST_PY_BD: "r2dplus" TEST_PY_ID: "--id tulip_qemu" + TEST_PY_TEST_SPEC: "not sleep" sifive_unleashed_sdcard: TEST_PY_BD: "sifive_unleashed" TEST_PY_ID: "--id sdcard_qemu" + TEST_PY_TEST_SPEC: "not sleep" sifive_unleashed_spi-nor: TEST_PY_BD: "sifive_unleashed" TEST_PY_ID: "--id spi-nor_qemu" + TEST_PY_TEST_SPEC: "not sleep" xilinx_zynq_virt: TEST_PY_BD: "xilinx_zynq_virt" TEST_PY_ID: "--id qemu" diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 2a52e15d0fe7..d938c7f31d68 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -306,12 +306,14 @@ sandbox trace_test.py: evb-ast2500 test.py: variables: TEST_PY_BD: "evb-ast2500" + TEST_PY_TEST_SPEC: "not sleep" TEST_PY_ID: "--id qemu" <<: *buildman_and_testpy_dfn evb-ast2600 test.py: variables: TEST_PY_BD: "evb-ast2600" + TEST_PY_TEST_SPEC: "not sleep" TEST_PY_ID: "--id qemu" <<: *buildman_and_testpy_dfn @@ -323,6 +325,7 @@ sandbox_flattree test.py: vexpress_ca9x4 test.py: variables: TEST_PY_BD: "vexpress_ca9x4" + TEST_PY_TEST_SPEC: "not sleep" TEST_PY_ID: "--id qemu" <<: *buildman_and_testpy_dfn @@ -432,36 +435,42 @@ qemu-xtensa-dc233c test.py: r2dplus_i82557c test.py: variables: TEST_PY_BD: "r2dplus" + TEST_PY_TEST_SPEC: "not sleep" TEST_PY_ID: "--id i82557c_qemu" <<: *buildman_and_testpy_dfn r2dplus_pcnet test.py: variables: TEST_PY_BD: "r2dplus" + TEST_PY_TEST_SPEC: "not sleep" TEST_PY_ID: "--id pcnet_qemu" <<: *buildman_and_testpy_dfn r2dplus_rtl8139 test.py: variables: TEST_PY_BD: "r2dplus" + TEST_PY_TEST_SPEC: "not sleep" TEST_PY_ID: "--id rtl8139_qemu" <<: *buildman_and_testpy_dfn r2dplus_tulip test.py: variables: TEST_PY_BD: "r2dplus" + TEST_PY_TEST_SPEC: "not sleep" TEST_PY_ID: "--id tulip_qemu" <<: *buildman_and_testpy_dfn sifive_unleashed_sdcard test.py: variables: TEST_PY_BD: "sifive_unleashed" + TEST_PY_TEST_SPEC: "not sleep" TEST_PY_ID: "--id sdcard_qemu" <<: *buildman_and_testpy_dfn sifive_unleashed_spi-nor test.py: variables: TEST_PY_BD: "sifive_unleashed" + TEST_PY_TEST_SPEC: "not sleep" TEST_PY_ID: "--id spi-nor_qemu" <<: *buildman_and_testpy_dfn -- 2.43.0

1 1

[PATCH v12 00/21] Introduce the lwIP network stack
by Jerome Forissier 16 Oct '24

16 Oct '24

This is a rework of a patch series by Maxim Uvarov: "net/lwip: add lwip library for the network stack" [1]. The goal is to introduce the lwIP TCP/IP stack [2] [3] as an alternative to the current implementation in net/, selectable with Kconfig, and ultimately keep only lwIP if possible. Some reasons for doing so are: - Make the support of HTTPS in the wget command easier. Javier T. and Raymond M. (CC'd) have some additional lwIP and Mbed TLS patches to do so. With that it becomes possible to fetch and launch a distro installer such as Debian etc. using a secure, authenticated connection directly from the U-Boot shell. Several use cases: * Authentication: prevent MITM attack (third party replacing the binary with a different one) * Confidentiality: prevent third parties from grabbing a copy of the image as it is being downloaded * Allow connection to servers that do not support plain HTTP anymore (this is becoming more and more common on the Internet these days) - Possibly benefit from additional features implemented in lwIP - Less code to maintain in U-Boot Prior to applying this series, the lwIP stack needs to be added as a Git subtree with the following command: $ git subtree add --squash --prefix lib/lwip/lwip \ https://github.com/lwip-tcpip/lwip.git STABLE-2_2_0_RELEASE Notes 1. A number of features are currently incompatible with NET_LWIP: DFU_TFTP, FASTBOOT, SPL_NET, ETH_SANDBOX, ETH_SANDBOX_RAW, DM_ETH. They all make assumptions on how the network stack is implemented and/or pull sybols that are not trivially exported from lwIP. Some interface rework may be needed. 2. Due to the above, and in order to provide some level of testing of the lwIP code in CI even when the legacy NET is the default, a new QEMU configuration is introduced (qemu_arm64_lwip_defconfig) which is based on qemu_arm64_defconfig with NET_LWIP and CMD_*_LWIP enabled. In addition to that, this series has some [TESTING] patches which make NET_LWIP the default. [1] https://lore.kernel.org/all/20231127125726.3735-1-maxim.uvarov@linaro.org/ [2] https://www.nongnu.org/lwip/ [3] https://en.wikipedia.org/wiki/LwIP Changes in v12: - Rebase onto master - Combine "net: split include/net.h into net{, -common, -legacy, -lwip}.h" and "net: move copy_filename() to new file net/net-common.c" (Ilias A.) - Fold "net-lwip: lwIP wget supports user defined port in the uri, so allow it." into parent patch "net-lwip: add wget command" - CI: update .gitlab-ci.yml too (Tom R.) - Fold "configs: replace '# CONFIG_NET is not set' with CONFIG_NO_NET=y" into "net: introduce alternative implementation as net-lwip/" - bootflow_cmd_label test: use 'if CONFIG_IS_ENABLED(DSA_SANDBOX)' - Drop the "[TESTING]" patches: * "[TESTING] Kconfig: enable NET_LWIP by default" * "[TESTING] configs: set CONFIG_NET=y for FTGMAC100" - Drop the patches sent separately: * "net: recv(): return -EAGAIN instead of 0 when no cleanup is expected" * "Make AVB_VERIFY depend on FASTBOOT" * "linker_lists: set LINKER_LIST_ALIGN to 8 if 64BIT" - Fix "configs: use syntax CONFIG_FOO=n in tools-only_defconfig": 'CONFIG_NET=n' was inadvertently forgotten. - Fix "net: introduce alternative implementation as net-lwip/": set CONFIG_NO_NET=y in tools-only_defconfig. - Add the "git subtree add" command to the patch description in "net-lwip: build lwIP". - All patches: use "net: lwip:" as a subsystem prefix rather than "net-lwip:". - Apply review tags Changes in v11: - Rebased onto next - "Miscellaneous fixes" removed (patches were merged in next). The series still begins with small fixes posted separately [1] [2] [3]. - Add (some) support for CMD_PXE and therefore drop patch "[TESTING] configs: set CONFIG_NET=y when PXE is enabled". This is build-tested only and it is very likely that some work is needed to make it useful. For example, adding the code for DHCP option 209 to lwIP so that BOOTP_PXE_DHCP_OPTION can be supported. - SANDBOX is now supported, but with the dm eth and wget tests disabled. - Move eth_set_enable_bootdevs() declaration to net-common.h Fixes warning with snow_defconfig: test/test-main.c:310:17: warning: implicit declaration of function ‘eth_set_enable_bootdevs’ [....] - Do eth_init() and eth_init_rings() only once, and do not forget lwip_init()! Fixes TFTP stalls on TI K3 (reported by Tom R. and tested by Ilias A.) - Set MEM_ALIGNMENT to 8 in lib/lwip/u-boot/lwipopts.h. Fixes TFTP random crashes on TI K3 (Ilias A.) - net_lwip_rx(): call free_pkt() even when recv() has returned 0, as required by the driver model documentation (and imx8mp_evk). Fixes a regression introduced in v9. Goes together with patch [2]. - Add "lwip: tftp: bind to TFTP port only when in server mode" to fix an issue with interrupted tftp commands (the tftp command hangs if it is interrupted with Ctrl-C and started again). - TFTP: fix uninitialized "ret" variable in do_tftpb(); print "Abort" on Ctrl-C. - MAINTAINERS: remove README and add sandbox ethernet driver to the list of maintained files. - AFAICT, CI should be all good except qemu_xtensa_dc233c which is broken when NET_LWIP=y (QEMU just hangs with no output). I could not find or build a suitable GDB binary to debug that. [1] https://patchwork.ozlabs.org/project/uboot/patch/20241002144845.1439316-1-j… [2] https://patchwork.ozlabs.org/project/uboot/patch/20240927142038.879037-1-je… [3] https://patchwork.ozlabs.org/project/uboot/patch/20241003142030.1610222-1-j… Changes in v10: - Rebase onto next - URL for lwIP changed in cover letter: using GitHub now since all tags have suddenly disappeared from the repository on gnu.org. - Post fixes as a separate series [1] or individual patches [2] [3] - Add "if NET_LWIP" to net/lwip/Kconfig to fix a kconfig warning when doing the full branch build with buildman ("[NEW]") - net/ is added to libs-y only when NET or NET_LWIP, not NO_NET - Apply review tags [1] http://patchwork.ozlabs.org/project/uboot/list/?series=422079 https://lists.denx.de/pipermail/u-boot/2024-September/563904.html [2] http://patchwork.ozlabs.org/project/uboot/list/?series=421962 [3] http://patchwork.ozlabs.org/project/uboot/list/?series=421959 Changes in v9: - Rebased onto master, reordered commits to put some fixes that are not strictly related to lwIP first. - New commit "test/py: test_efi_loader: add missing dependency on cmd_tftpboot" (Tom R.) - test_efi_loader.py: add missing dependency on cmd_wget (Tom R.) - wget: fix divide by zero when transfer takes less than 1ms (Tom R.) - New commit "configs: use syntax CONFIG_FOO=n in tools-only_defconfig" (Tom R.) - Make TCP_WND configurable (via CONFIG_LWIP_TCP_WND) because a large value is needed for good performance especially with latency but transfers stall in QEMU (-net user) when the value is larger than a few KB (Anton A., offlist) - Added [TESTING] commits to run CI with NET_LWIP enabled by default except for SANDBOX and platforms that enable PXE, and fixed a number of issues: * coreboot_defconfig: 'implicit declaration' warnings on ip_checksum_ok() and compute_ip_checksum() * Fix EFI net tests (bootefi selftest) by adding missing push_packed() call to net_process_received_packet() * qemu_arm64: fix test_efi_loader.py failures (skip HTTP test by default since it needs a HTTP server; fix a bug in the dhcp command which would not set the "serverip" variable) * QEMU CI tests for r2dplus_i82557c, r2dplus_rtl8139: Fixed receive errors due to calling free_pkt() with a length of zero. r2dplus_tulip: fixed "dm_pci_phys_to_bus: invalid physical address" caused by too late eth_init_rings(). With that the CI status is all GREEN: https://dev.azure.com/u-boot/u-boot/_build/results?buildId=9225&view=results Changes in v8: - Fix bootefi with tftp and wget. It would previously fail with an error message: "No UEFI binary known at 200000". Tested on Raspberry 3B+. Also fix the legacy wget. (Tom R.) - wget: add "Bytes transferred =" message and accept legacy syntax for better compatibility which also makes it easier to add a test to the test suite - wget: When no server name or address is supplied, use ${httpserverip} then ${serverip}. - wget: start the timer used for measuring throughput when the first data block is received. In other words: do not include DNS resolution and TCP connection time in measurement. It gives better numbers ;) but more importantly is how the legacy code works. - wget: handle non-200 result codes from the server as errors. - tftp: when no server name or ip is supplied, use ${tftpserverip} then fall back to ${serverip}. - New commit: "test/py: add HTTP (wget) test" - New commit: "net: wget: removed unused function wget_success()" - Change back all !CONFIG_IS_ENABLED(NO_NET) tests to (CONFIG_IS_ENABLED(NET) || CONFIG_IS_ENABLED(NET_LWIP)) since the NO_NET case is wrong when CONFIG_SPL_BUILD or CONFIG_TPL_BUILD is defined (Tom R.) Changes in v7: - Rebased onto master - Updated binary size comparisons in this cover letter. Note that the increase for imx8mp_evk_defconfig was wrong due to a configuration error. Changes in v6: - Rebased on next - "flash: prefix error codes with FL_" Update drivers/mtd/altera_qspi.c too (Tom R.) - "net: introduce alternative implementation as net-lwip/" Introduce a "Networking" top-level menu in the main Kconfig. Avoids having a lot of network-related symbols on the first screen of menuconfig. The "Networking stack" choice as well as the applicable symbols (depending on the selected choice) are now all inside this "Networking" menu. (Michal S.) For PROT_DHCP_LWIP and PROT_DNS_LWIP, use "select" PROT_UDP_LWIP rather than "depends on". Move NET_RANDOM_ETHADDR to the common ('if NET || NET_LWIP') block. Move SYS_RX_ETH_BUFFER out of 'if NET || NET_LWIP' since it is used unguarded in some code (e.g., am62x_beagleplay_r5) (Tom R.). - "net: split include/net.h into net{,-common,-legacy,-lwip}.h" Move net_random_ethaddr() to net-common.h. - "net: eth-uclass: add function eth_start_udev()" Fix typo and apply Tom R.'s R-b. - "net-lwip: add DHCP support and dhcp commmand" Convert !CONFIG_IS_ENABLED(NET) to CONFIG_IS_ENABLED(NO_NET) in board/xilinx/common/board.c to fix an issue with device having no MAC address (thanks Michal S.). Do the same at other places (icore_mx8mp.c, imx8mp_debix_model_a.c, board/ti/am335x/board.c, tiny-printf.c). Move CMD_MII and CMD_MDIO into 'if NET || NET_LWIP'. - "net-lwip: add TFTP support and tftpboot command": Fix help string. - "net: split cmd/net.c into cmd/net.c and cmd/net-common.c": Apply Ilias' R-b. - "net-lwip: add TFTP_BLOCKSIZE" Apply Ilias' R-b. I moved the TFTP_BLOCKSIZE Kconfig into this commit where it belongs (it was previously in "net" split ... net.h"). Changes in v5: - Rebased on next - Refactor Kconfig options to avoid duplicates - Library functions use a more consistent naming (dhcp_loop(), ping_loop() etc.) and take a struct udevice * parameter (Heinrich S.) - Do not use net_process_receive_packet() for input anymore. Instead of calling eth_rx() which would invoke net_process_receive_packet(), we call a new net_lwip_rx(udev) function which invokes the device recv() and pushes the packets up the lwIP stack. Thus everything is tied to a udevice now. (Heinrich S.) - Add "configs: replace '# CONFIG_NET is not set' with CONFIG_NO_NET=y" (Tom R.) - tftp: unify display with legacy command: add throughput, 65 hashes per line, one every 10 blocks received (Tom R.) - Moved net-lwip/* to net/lwip/* (Simon G.) - Rename static function low_level_output() to linkoutput() since it is the name used in the lwIP netif struct. - Fixed off-by-one in parse_url() which could cause wget to fail when passed a URL with a host name (as opposed to a URL with an IP address). - Improved TFTP performance by adding support for the blksize option (patches "lwip: tftp: add support of blksize option to client" and "net-lwip: add TFTP_BLOCKSIZE) (Tom R.) - Add an optional port number to the tftp command for easier testing (syntax: tftp [[ip:[port:]]filename]) - wget: display an "unsupported URI" error if uri is not http:// (Jon H.) - Adjusted the lwIP TCP options in lib/lwip/u-boot/lwipopts.h for better performance, in particular TCP_WND. - Add "net: fec_mxc_init(): do not ignore return status of fec_open()" - Set the proper environment variables when DHCP succeeds (ipaddr%d etc.) and read the proper ones for the given device in new_netif(), allowing correct behavior when several adapters are available (tested on i.MX8M Plus). - Fix an alignment issue with outgoing packets (see the linkoutput() function). With that the i.MX8M Plus ENET1 interface works properly. (reported by Tim H.). - Add review tags Changes in v4: - Fixed the DHCP algorithm which was missing a sys_timeout() call in the "fine timer" callback. This should close the issue that Tom R. reported with his Raspberry Pi 3 (it does fix it on mine). - The DHCP exchange timeout is increased from 2 to 10 seconds - The DHCP exchange can be interrupted with Ctrl-C. - "net: introduce alternative implementation as net-lwip/": rework dependencies. A few symbols have 'depends on !NET_LWIP' and in addition 'NET_LWIP depends on !SANDBOX'. Sandbox, DSA and fastboot are unsupported, because they are deeply welded to the current stack. - All network commands (dns, ping, tftp and wget): * Get rid of global variables (Ilias A.) * Use printf() rather than log_info() - "net-lwip: add ping command": use packet count instead of timeout, fix code style (Ilias A.) - Add "net: split cmd/net.c into cmd/net.c and cmd/net-common.c" extracted from the wget patch (Ilias A.). - Add "net: split include/net.h into net{,-common,-legacy,-lwip}.h" (Ilias A.) - Add "flash: prefix error codes with FL_" which is required to avoid name clashes when splitting net.h - Reworked the initialization of the lwIP stack. One and only one network interface (struct netif) is added for the duration of the command that uses that interface. That's commit "net-lwip: add DHCP support and dhcp commmand". - Drop "test: dm: dsa, eth: disable tests when CONFIG_NET_LWIP=y", not needed now that NET_LWIP depend on !SANDBOX. - qemu_arm64_lwip_defconfig now enables CMD_DNS and CMD_WGET (so that all the supported network commands are available). Changes in v3: - Make NET_LWIP a Kconfig choice in patch "net: introduce alternative implementation as net-lwip/" (Tom R.) - Drop the patch introducing lwIP as a Git subtree and document the git command in the cover letter instead (Tom R.) - "net-lwip: add TFTP support and tftpboot command": use the same "Bytes transferred =" message as in the legacy implementation (Tom R., Maxim U.) - Drop "test/py: net: add _lwip variants of dhcp, ping and tftpboot tests" which is not needed anymore. - Add missing kfree() calls in cmd/net-common.c and fix the parsing of decimal address in net-lwip/wget.c (patch "net-lwip: add wget command") (Maxim U.) - "net-lwip: add ping command": drop the ICMP payload (Ilias A.). Set the sequence number to zero when entering ping_loop(). Changes in v2: ** Address comments from Ilias A. - "net-lwip: add wget command" Implement the wget_with_dns() function to do most of the wget work and call it from do_wget(). This allows to simplify patch "net-lwip: add support for EFI_HTTP_BOOT". - "net-lwip: import net command from cmd/net.c" Move a few functions from cmd/net.c to a new file cmd/net-common.c rather than duplicating then in cmd/net-lwip.c. - "net-lwip: add support for EFI_HTTP_BOOT" Since wget_with_dns() is now implemented in "net-lwip: add wget command", just enable the wget command when the lwIP stack is enabled and EFI_HTTP_BOOT is requested. ** Address comments from Tom R. - "net-lwip: add DHCP support and dhcp commmand", "net-lwip: add TFTP support and tftpboot command", "net-lwip: add ping command", "net-lwip: add dns command", "net-lwip: add wget command" Do not introduce new CMD_XXX_LWIP symbols and use existing CMD_XXX instead. - "configs: add qemu_arm64_lwip_defconfig" Use #include <configs/qemu_arm64_defconfig>. - "net-lwip: import lwIP library under lib/lwip" Patch removed and replaced by the introduction of a Git subtree: "Squashed 'lib/lwip/lwip/' content from commit 0a0452b2c3". Note that I have not yet addressed your comments on "test: dm: dsa, eth: disable tests when CONFIG_NET_LWIP=y"). I need some more time for that and I think running CI on this v2 will help better understand what is needed for v3. ** Miscellaneous improvements - "net: introduce alternative implementation as net-lwip/": * Make DFU_OVER_TFTP not DFU_TFTP incompatible with NET_LWIP. It seems quite natural to supplement "depends on NET" with "&& !NET_LWIP". * Make PROT_*_LWIP not visible by removing the Kconfig prompt. Jerome Forissier (21): configs: use syntax CONFIG_FOO=n in tools-only_defconfig sandbox: add dummy driver ETH_SANDBOX_LWIP test: boot: fix bootdev_test_any for when DSA_SANDBOX is disabled test: boot: fix bootflow_cmd_label for when DSA_SANDBOX is disabled net: introduce alternative implementation as net/lwip/ net: split net into net{,-common,-legacy,-lwip} net: eth-uclass: add function eth_start_udev() net: lwip: build lwIP net: lwip: add DHCP support and dhcp commmand net: lwip: tftp: bind to TFTP port only when in server mode net: lwip: add TFTP support and tftpboot command net: lwip: add ping command net: lwip: add dns command net: split cmd/net.c into cmd/net.c and cmd/net-common.c net: lwip: add wget command cmd: bdinfo: enable -e when CONFIG_CMD_NET_LWIP=y configs: add qemu_arm64_lwip_defconfig net: lwip: tftp: add support of blksize option to client net: lwip: add TFTP_BLOCKSIZE CI: add qemu_arm64_lwip to the test matrix MAINTAINERS: net: lwip: add myself as a maintainer .azure-pipelines.yml | 7 + .gitlab-ci.yml | 9 + Kconfig | 29 + MAINTAINERS | 11 + Makefile | 6 +- board/engicam/imx8mp/icore_mx8mp.c | 2 +- .../imx8mp_debix_model_a.c | 2 +- board/ti/am335x/board.c | 3 +- board/xilinx/common/board.c | 3 +- boot/Kconfig | 4 +- cmd/Kconfig | 140 +-- cmd/Makefile | 9 +- cmd/bdinfo.c | 5 +- cmd/elf.c | 2 +- cmd/net-common.c | 109 ++ cmd/net-lwip.c | 45 + cmd/net.c | 115 --- common/Kconfig | 2 +- common/board_r.c | 4 +- common/spl/Kconfig | 1 + common/usb_kbd.c | 2 +- configs/LicheePi_Zero_defconfig | 2 +- configs/M5249EVB_defconfig | 2 +- configs/am335x_pdu001_defconfig | 2 +- configs/am62ax_evm_r5_defconfig | 2 +- configs/am62px_evm_r5_defconfig | 2 +- configs/am62x_beagleplay_r5_defconfig | 2 +- configs/amcore_defconfig | 2 +- configs/amd_versal2_mini_defconfig | 2 +- configs/amd_versal2_mini_emmc_defconfig | 2 +- configs/amd_versal2_mini_ospi_defconfig | 2 +- configs/amd_versal2_mini_qspi_defconfig | 2 +- configs/anbernic-rgxx3-rk3566_defconfig | 2 +- configs/ap143_defconfig | 2 +- configs/ap152_defconfig | 2 +- configs/apple_m1_defconfig | 2 +- configs/astro_mcf5373l_defconfig | 2 +- configs/at91sam9rlek_dataflash_defconfig | 2 +- configs/at91sam9rlek_mmc_defconfig | 2 +- configs/at91sam9rlek_nandflash_defconfig | 2 +- configs/bcm7260_defconfig | 2 +- configs/bcm7445_defconfig | 2 +- configs/bcm968380gerg_ram_defconfig | 2 +- configs/bcmns_defconfig | 2 +- configs/chromebook_samus_tpl_defconfig | 2 +- configs/cortina_presidio-asic-base_defconfig | 2 +- configs/cortina_presidio-asic-pnand_defconfig | 2 +- configs/durian_defconfig | 2 +- configs/e850-96_defconfig | 2 +- configs/ea-lpc3250devkitv2_defconfig | 2 +- configs/efi-x86_app32_defconfig | 2 +- configs/efi-x86_app64_defconfig | 2 +- configs/emsdp_defconfig | 2 +- configs/evb-px5_defconfig | 2 +- configs/generic-rk3568_defconfig | 2 +- configs/generic-rk3588_defconfig | 2 +- configs/hc2910_2aghd05_defconfig | 2 +- configs/igep00x0_defconfig | 2 +- configs/imx6q_bosch_acc_defconfig | 2 +- configs/imx6ulz_smm_m2_defconfig | 2 +- configs/iot_devkit_defconfig | 2 +- configs/j722s_evm_r5_defconfig | 2 +- configs/legoev3_defconfig | 2 +- configs/mk808_defconfig | 2 +- configs/mx23evk_defconfig | 2 +- configs/mx28evk_defconfig | 2 +- configs/mx6memcal_defconfig | 2 +- configs/mx6ulz_14x14_evk_defconfig | 2 +- configs/mx7ulp_com_defconfig | 2 +- configs/mx7ulp_evk_defconfig | 2 +- configs/mx7ulp_evk_plugin_defconfig | 2 +- configs/netgear_cg3100d_ram_defconfig | 2 +- configs/nsim_700_defconfig | 2 +- configs/nsim_700be_defconfig | 2 +- configs/nsim_hs38be_defconfig | 2 +- configs/openpiton_riscv64_defconfig | 2 +- configs/openpiton_riscv64_spl_defconfig | 2 +- configs/origen_defconfig | 2 +- configs/pe2201_defconfig | 2 +- configs/pinecube_defconfig | 2 +- configs/pm9261_defconfig | 2 +- configs/qemu_arm64_lwip_defconfig | 9 + configs/s5p4418_nanopi2_defconfig | 2 +- configs/s5p_goni_defconfig | 2 +- configs/s5pc210_universal_defconfig | 2 +- configs/sama5d27_giantboard_defconfig | 2 +- configs/sama5d29_curiosity_mmc1_defconfig | 2 +- configs/sama5d29_curiosity_mmc_defconfig | 2 +- .../sama5d29_curiosity_qspiflash_defconfig | 2 +- configs/sama7g54_curiosity_mmc_defconfig | 2 +- .../sama7g54_curiosity_nandflash_defconfig | 2 +- .../sama7g54_curiosity_qspiflash_defconfig | 2 +- configs/sipeed_maix_bitm_defconfig | 2 +- configs/sipeed_maix_smode_defconfig | 2 +- configs/stemmy_defconfig | 2 +- configs/stm32f429-discovery_defconfig | 2 +- configs/stm32f429-evaluation_defconfig | 2 +- configs/stm32f469-discovery_defconfig | 2 +- configs/stm32h743-disco_defconfig | 2 +- configs/stm32h743-eval_defconfig | 2 +- configs/stm32h750-art-pi_defconfig | 2 +- configs/stm32mp25_defconfig | 2 +- configs/stmark2_defconfig | 2 +- configs/th1520_lpi4a_defconfig | 2 +- configs/thunderx_88xx_defconfig | 2 +- configs/tools-only_defconfig | 40 +- configs/topic_miami_defconfig | 2 +- configs/topic_miamilite_defconfig | 2 +- configs/topic_miamiplus_defconfig | 2 +- configs/total_compute_defconfig | 2 +- configs/trats2_defconfig | 2 +- configs/trats_defconfig | 2 +- configs/xenguest_arm64_defconfig | 2 +- configs/xenguest_arm64_virtio_defconfig | 2 +- configs/xilinx_versal_mini_defconfig | 2 +- configs/xilinx_versal_mini_emmc0_defconfig | 2 +- configs/xilinx_versal_mini_emmc1_defconfig | 2 +- configs/xilinx_versal_mini_ospi_defconfig | 2 +- configs/xilinx_versal_mini_qspi_defconfig | 2 +- configs/xilinx_versal_net_mini_defconfig | 2 +- configs/xilinx_versal_net_mini_emmc_defconfig | 2 +- configs/xilinx_versal_net_mini_ospi_defconfig | 2 +- configs/xilinx_versal_net_mini_qspi_defconfig | 2 +- configs/xilinx_zynqmp_mini_defconfig | 2 +- configs/xilinx_zynqmp_mini_emmc0_defconfig | 2 +- configs/xilinx_zynqmp_mini_emmc1_defconfig | 2 +- configs/xilinx_zynqmp_mini_nand_defconfig | 2 +- .../xilinx_zynqmp_mini_nand_single_defconfig | 2 +- configs/xilinx_zynqmp_mini_qspi_defconfig | 2 +- configs/zynq_cse_nand_defconfig | 2 +- configs/zynq_cse_nor_defconfig | 2 +- configs/zynq_cse_qspi_defconfig | 2 +- drivers/dfu/Kconfig | 1 + drivers/fastboot/Kconfig | 1 + drivers/net/Kconfig | 16 +- drivers/net/Makefile | 1 + drivers/net/phy/Kconfig | 2 +- drivers/net/sandbox-lwip.c | 85 ++ drivers/usb/gadget/Kconfig | 2 +- include/net-common.h | 509 ++++++++++ include/net-legacy.h | 541 ++++++++++ include/net-lwip.h | 41 + include/net.h | 943 +----------------- lib/Makefile | 2 + lib/binman.c | 1 + lib/lwip/Makefile | 55 + lib/lwip/lwip/src/apps/tftp/tftp.c | 104 +- .../lwip/src/include/lwip/apps/tftp_client.h | 1 + lib/lwip/u-boot/arch/cc.h | 45 + lib/lwip/u-boot/arch/sys_arch.h | 0 lib/lwip/u-boot/limits.h | 0 lib/lwip/u-boot/lwipopts.h | 157 +++ lib/tiny-printf.c | 3 +- net/Kconfig | 81 +- net/Makefile | 20 +- net/eth-uclass.c | 38 +- net/lwip/Kconfig | 49 + net/lwip/Makefile | 8 + net/lwip/dhcp.c | 139 +++ net/lwip/dns.c | 127 +++ net/lwip/eth_internal.h | 35 + net/lwip/net-lwip.c | 305 ++++++ net/lwip/ping.c | 177 ++++ net/lwip/tftp.c | 290 ++++++ net/lwip/wget.c | 357 +++++++ net/net-common.c | 13 + net/net.c | 12 - test/boot/bootdev.c | 11 +- test/boot/bootflow.c | 12 +- test/cmd/Makefile | 2 + test/dm/Makefile | 2 + 171 files changed, 3626 insertions(+), 1339 deletions(-) create mode 100644 cmd/net-common.c create mode 100644 cmd/net-lwip.c create mode 100644 configs/qemu_arm64_lwip_defconfig create mode 100644 drivers/net/sandbox-lwip.c create mode 100644 include/net-common.h create mode 100644 include/net-legacy.h create mode 100644 include/net-lwip.h create mode 100644 lib/lwip/Makefile create mode 100644 lib/lwip/u-boot/arch/cc.h create mode 100644 lib/lwip/u-boot/arch/sys_arch.h create mode 100644 lib/lwip/u-boot/limits.h create mode 100644 lib/lwip/u-boot/lwipopts.h create mode 100644 net/lwip/Kconfig create mode 100644 net/lwip/Makefile create mode 100644 net/lwip/dhcp.c create mode 100644 net/lwip/dns.c create mode 100644 net/lwip/eth_internal.h create mode 100644 net/lwip/net-lwip.c create mode 100644 net/lwip/ping.c create mode 100644 net/lwip/tftp.c create mode 100644 net/lwip/wget.c create mode 100644 net/net-common.c -- 2.40.1

3 30

modify live DT with OF_LIVE breaking phy_connect?
by Tim Harvey 15 Oct '24

15 Oct '24

Greetings, I have a need to adjust the U-Boot device-tree live with some board revision specific fixups. It would seem I need to enable OF_LIVE to do so but when I do this on imx8mm U-Boot proper seems to fail phy_connect() called from the network device probe. The board I'm working with is an imx8mm-venice board and using imx8mm_venice_defconfig (without OF_LIVE) results in: U-Boot 2024.10-00735-gc530f6079c70 (Oct 07 2024 - 12:58:38 -0700) CPU: Freescale i.MX8MMQ rev1.0 1600 MHz (running at 1200 MHz) CPU: Industrial temperature grade (-40C to 105C) at 44C Reset cause: POR Model: Gateworks Venice GW73xx-0x i.MX8MM Development Kit DRAM: 4 GiB Core: 226 devices, 32 uclasses, devicetree: separate WDT: Started watchdog@30280000 with servicing every 1000ms (60s timeout) MMC: FSL_SDHC: 0, FSL_SDHC: 1, FSL_SDHC: 2 Loading Environment from MMC... Reading from redundant MMC(2)... OK In: serial@30890000 Out: serial@30890000 Err: serial@30890000 SEC0: RNG instantiated Net: GPY111 eth0: ethernet@30be0000 [PRIME] GSC : boot watchdog disabled Thermal protection:enabled at 96C Hit any key to stop autoboot: 0 Yet as soon as I enable OF_LIVE: U-Boot 2024.10-00735-gc530f6079c70 (Oct 07 2024 - 12:59:35 -0700) CPU: Freescale i.MX8MMQ rev1.0 1600 MHz (running at 1200 MHz) CPU: Industrial temperature grade (-40C to 105C) at 49C Reset cause: POR Model: Gateworks Venice GW73xx-0x i.MX8MM Development Kit DRAM: 4 GiB Core: 214 devices, 32 uclasses, devicetree: separate WDT: Started watchdog@30280000 with servicing every 1000ms (60s timeout) MMC: FSL_SDHC: 0, FSL_SDHC: 1, FSL_SDHC: 2 Loading Environment from MMC... Reading from redundant MMC(2)... OK In: serial@30890000 Out: serial@30890000 Err: serial@30890000 SEC0: RNG instantiated Net: Could not get PHY for mdio: addr 0 Could not get PHY for FEC0: addr 0 Could not get PHY for mdio: addr 0 Could not get PHY for FEC0: addr 0 No ethernet found. ^^^ phy_connect failing Any idea what I'm missing here? Are there other ways I should be modifying the live dt in U-Boot? Best Regards, Tim

2 4

Assistance required - U-boot not working on Radxa Rock
by wulfgarfr+ubdlist＠gmail.com 15 Oct '24

15 Oct '24

Hi, A little time ago I acquired a Radxa Rock (RK3188 SoC). While it is an aging board, it is still quite capable and yet low-power. However, the board I have is coming with a very old Linaro version on the built-in flash. Radxa does not really provide any recent builds, and the way the flash is setup it can't easily be upgraded to a newer kernel or distribution. The SD images provided on their website suffer the same problem. The SBC is supported according to https://docs.u-boot.org/en/stable/board/rockchip/rockchip.html#rockchip-boa… So I set out to build the latest U-boot release. And it build just fine. But when written to SD card, the board just boots to flash instead. It is capable of booting directly from SD (prioritized over flash boot), as tested with an old Radxa SD image that I downloaded. Apparently the built U-boot 2024.10 as written to SD is not recognized at all by the board. I would really appreciate any suggestions how to start troubleshooting, or how to adapt the build. Regards, Wolf [1] U-boot SDcard build setup: $ export CROSS_COMPILE=arm-linux-gnueabihf- $ make rock_defconfig $ make CROSS_COMPILE=arm-linux-gnueabihf- $ export SDCARD=/dev/mmcblk0 $ sudo dd if=/dev/zero of=$SDCARD bs=1M count=1 $ sudo dd if=u-boot-rockchip.bin of=SDCARD seek=64 [2] Boot log with inserted U-boot 2024.10 SD card: $ picocom /dev/ttyUSB0 -b 115200 -e w q �� @� B�DDR Version 1.04 20130517 In DDR3 300MHz Bus Width=32 Col=10 Bank=8 Row=15 CS=2 Die Bus-Width=16 Size=2048MB Memory OK OUT BUILD=====2 SdmmcInit=0 0 FwPartOffset=0 , 0 No.1 FLASH ID:2c 64 44 4b a9 0 OK! 226110 unsigned! SecureBootEn = 0 0 Boot ver: 2013-12-02#2.08 start_linux=====230997 3431345 Starting kernel...@0x60408000 [ 0.000000] Initializing cgroup subsys cpu [ 0.000000] Linux version 3.0.36+ (build@radxa-x1) (gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5) ) #10 SMP PREEMPT Sat Aug 23 16:11:52 CST 2014 [ 0.000000] CPU: ARMv7 Processor [413fc090] revision 0 (ARMv7), cr=10c5387d ...

1 0