June 2023 - U-Boot

RE: compile error
by Chan Kim 12 Jun '23

12 Jun '23

Earlier I found this error occurs because during the tool build, it uses list.h file not in the include/linux directory of u-boot but in my host computer's /usr/local/include/linux directory. So if I temporarily rename the /usr/local/include/linux/list.h, u-boot compiles ok. >From https://lists.denx.de/pipermail/u-boot/2015-June/217687.html I found it is correct to use the include path in my host system during the tool build. (because it happend during tools/lib/sha1.c.) But I don't have that hlist_node_list definition in my system header file. What is wrong with my system? (ubuntu 20.04). Chan Kim >-----Original Message----- >From: Chan Kim <ckim(a)etri.re.kr> >Sent: Sunday, June 4, 2023 11:41 PM >To: U-Boot Mailing List <u-boot(a)lists.denx.de> >Subject: compile error > >Hello all, >For commit 26659d42654 (Fri Jun 2 12:13:01 2023 -0400) > >When I do 'make qemu_arm64_defconfig' and 'make', I get this compile error. > >ckim@ckim-ubuntu:~/u-boot-test/u-boot$ make -j28 > ENVC include/generated/env.txt > UPD include/generated/timestamp_autogenerated.h > ENVP include/generated/env.in > ENVT include/generated/environment.h > HOSTCC tools/lib/sha1.o > HOSTCC tools/lib/sha256.o > HOSTCC tools/lib/sha512.o >In file included from include/watchdog.h:13, > from ./tools/../lib/sha512.c:20, > from tools/lib/sha512.c:1: >include/cyclic.h:40:20: error: field ??list?? has incomplete type > 40 | struct hlist_node list; > | ^~~~ >In file included from include/watchdog.h:13, > from ./tools/../lib/sha1.c:25, > from tools/lib/sha1.c:1: >include/cyclic.h:40:20: error: field ??list?? has incomplete type > 40 | struct hlist_node list; > | ^~~~ >In file included from include/watchdog.h:13, > from ./tools/../lib/sha256.c:14, > from tools/lib/sha256.c:1: >include/cyclic.h:40:20: error: field ??list?? has incomplete type > 40 | struct hlist_node list; > | ^~~~ >make[1]: *** [scripts/Makefile.host:112: tools/lib/sha512.o] Error 1 >make[1]: *** Waiting for unfinished jobs.... >make[1]: *** [scripts/Makefile.host:112: tools/lib/sha1.o] Error 1 >make[1]: *** [scripts/Makefile.host:112: tools/lib/sha256.o] Error 1 >make: *** [Makefile:1853: tools] Error 2 > >Can anyone please fix it? > >Thank you! > >Chan Kim

2 1

compile error
by Chan Kim 12 Jun '23

12 Jun '23

Hello all, For commit 26659d42654 (Fri Jun 2 12:13:01 2023 -0400) When I do 'make qemu_arm64_defconfig' and 'make', I get this compile error. ckim@ckim-ubuntu:~/u-boot-test/u-boot$ make -j28 ENVC include/generated/env.txt UPD include/generated/timestamp_autogenerated.h ENVP include/generated/env.in ENVT include/generated/environment.h HOSTCC tools/lib/sha1.o HOSTCC tools/lib/sha256.o HOSTCC tools/lib/sha512.o In file included from include/watchdog.h:13, from ./tools/../lib/sha512.c:20, from tools/lib/sha512.c:1: include/cyclic.h:40:20: error: field ??list?? has incomplete type 40 | struct hlist_node list; | ^~~~ In file included from include/watchdog.h:13, from ./tools/../lib/sha1.c:25, from tools/lib/sha1.c:1: include/cyclic.h:40:20: error: field ??list?? has incomplete type 40 | struct hlist_node list; | ^~~~ In file included from include/watchdog.h:13, from ./tools/../lib/sha256.c:14, from tools/lib/sha256.c:1: include/cyclic.h:40:20: error: field ??list?? has incomplete type 40 | struct hlist_node list; | ^~~~ make[1]: *** [scripts/Makefile.host:112: tools/lib/sha512.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make[1]: *** [scripts/Makefile.host:112: tools/lib/sha1.o] Error 1 make[1]: *** [scripts/Makefile.host:112: tools/lib/sha256.o] Error 1 make: *** [Makefile:1853: tools] Error 2 Can anyone please fix it? Thank you! Chan Kim

2 1

[PATCH v3 00/17] x86: Various fixes for chromebooks
by Simon Glass 12 Jun '23

12 Jun '23

This adds some fixes for x86-based Chromebook builds which have picked up a few problems recently. With this, chromebook_link/64, chromebook_samus and chromebook_coral work correctly. Changes in v3: - Fix 'intend' typo - Fix 'returns' typo - Fix 'somtimes' typo - Fix 'propblem' typo - Squash in patch 'Set up LPC only after relocation' - Fix 'build' typo - Fix 'boot' typo - Drop change to memset() - Fix invalid commit IDs obtained from another branch - Fix 'require' typo - Add more detail about why it might be hanging - Fix 'call' typo Changes in v2: - Add new patch to set up LPC only after relocation - Add new patch to tidy up address for loading U-Boot from SPL - Drop patch "x86: Add on to existing MTRRs in SPL" - Add various patches to resolve problems with chromebook_link64 Simon Glass (17): dm: Emit the arch_cpu_init_dm() even only before relocation binman: Support writing symbols for ucode etypes sf: Guard against zero erasesize sf: Rename spi-nor-tiny functions x86: ivybridge: Ensure LPC is available for GPIO base x86: samus: Drop EFI_LOADER x86: Support debug UART in 64-bit mode x86: Tidy up availability of string functions x86: mrc: Correct SPL debug message x86: spl: Show debugging for BSS x86: Tidy up address for loading U-Boot from SPL x86: Return mtrr_add_request() to its old purpose x86: spl: Avoid using init_cache_f_r() from SPL spl: Commit MTRRs only in board_init_f_r() x86: Simplify cpu_jump_to_64bit_uboot() x86: samus: Don't include audio and SATA in TPL x86: samus: Adjust TPL start and pre-reloc memory size arch/arm/mach-imx/imx8/cpu.c | 2 +- arch/arm/mach-imx/imx8m/soc.c | 2 +- arch/arm/mach-imx/imx8ulp/soc.c | 2 +- arch/arm/mach-imx/imx9/soc.c | 2 +- arch/arm/mach-omap2/am33xx/board.c | 2 +- arch/arm/mach-omap2/hwinit-common.c | 2 +- arch/mips/mach-pic32/cpu.c | 2 +- arch/nios2/cpu/cpu.c | 2 +- arch/riscv/cpu/cpu.c | 2 +- arch/x86/cpu/baytrail/cpu.c | 2 +- arch/x86/cpu/broadwell/Makefile | 4 +-- arch/x86/cpu/broadwell/cpu.c | 2 +- arch/x86/cpu/i386/cpu.c | 32 +++---------------- arch/x86/cpu/ivybridge/bd82x6x.c | 17 +++++----- arch/x86/cpu/ivybridge/cpu.c | 2 +- arch/x86/cpu/mtrr.c | 6 +++- arch/x86/cpu/quark/quark.c | 2 +- arch/x86/cpu/x86_64/cpu.c | 7 ++++ arch/x86/include/asm/string.h | 6 +++- arch/x86/lib/Makefile | 4 ++- arch/x86/lib/fsp2/fsp_init.c | 2 +- arch/x86/lib/mrccache.c | 2 +- arch/x86/lib/spl.c | 19 ++++------- configs/chromebook_samus_defconfig | 1 + configs/chromebook_samus_tpl_defconfig | 4 +-- doc/develop/event.rst | 6 ++-- drivers/core/root.c | 4 +-- drivers/cpu/microblaze_cpu.c | 2 +- drivers/mtd/spi/sf_probe.c | 3 +- drivers/mtd/spi/spi-nor-tiny.c | 16 +++++----- drivers/sysreset/sysreset_x86.c | 9 ++++-- include/event.h | 2 +- .../binman/etype/u_boot_spl_with_ucode_ptr.py | 2 +- .../binman/etype/u_boot_tpl_with_ucode_ptr.py | 2 +- tools/binman/etype/u_boot_with_ucode_ptr.py | 4 +-- 35 files changed, 89 insertions(+), 91 deletions(-) -- 2.40.1.521.gf1e218fcd8-goog

3 26

[PATCH] doc: event: Correct EVT_DM_POST_INIT_F description
by Bin Meng 12 Jun '23

12 Jun '23

EVT_DM_POST_INIT_F only works in U-Boot proper, not SPL. Signed-off-by: Bin Meng <bmeng(a)tinylab.org> --- doc/develop/event.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/develop/event.rst b/doc/develop/event.rst index 1c1c9ef7f1..f0ee6bc4cc 100644 --- a/doc/develop/event.rst +++ b/doc/develop/event.rst @@ -29,7 +29,7 @@ To declare a spy, use something like this:: EVENT_SPY(EVT_DM_POST_INIT_F, snow_setup_cpus); Your function is called when EVT_DM_POST_INIT_F is emitted, i.e. after driver -model is inited (in SPL, or in U-Boot proper before and after relocation). +model is inited (in U-Boot proper before and after relocation). Debugging -- 2.25.1

2 1

[PATCH V2 0/8] Update SPL splashscreen framework for AM62x
by Nikhil M Jain 12 Jun '23

12 Jun '23

This patch series aims at updating SPL splashscreen framework for AM62x. This patch series depends on https://lore.kernel.org/u-boot/20230504225829.2537050-1-sjg@chromium.org/ This series: - Fixes compilation issues in case splash related configs are not defined in SPL. - Does page table setup, dram initialisation and dcache enabling in one function call spl_enable_dcache. - Allows passing of framebuffer from spl to u-boot, eliminating flicker. V2: - Update cover letter. - Fix commit message. Nikhil M Jain (8): common: spl: spl: Update stack pointer address arch: arm: mach-k3: common: Return a pointer after setting page table board: ti: am62x: evm: Update function calls for splash screen include: video: Reserve video using blob common: board_f: Pass frame buffer info from SPL to u-boot drivers: video: Kconfig: Add config remove video common: spl: spl: Remove video driver configs: am62x_evm_a53: Add bloblist address arch/arm/mach-k3/am625_init.c | 1 + arch/arm/mach-k3/common.c | 2 ++ board/ti/am62x/evm.c | 41 ++++++++++++--------------------- common/board_f.c | 12 +++++++++- common/spl/spl.c | 3 ++- configs/am62x_evm_a53_defconfig | 1 + drivers/video/Kconfig | 13 +++++++++++ drivers/video/video-uclass.c | 23 ++++++++++++++++++ include/video.h | 9 ++++++++ 9 files changed, 77 insertions(+), 28 deletions(-) -- 2.34.1

4 13

[PATCH] efi_loader: fix sphinx conformance for efi_disk_remove()
by Ilias Apalodimas 12 Jun '23

12 Jun '23

The function does not to conform to the Sphinx style documentation. Add the missing bits Signed-off-by: Ilias Apalodimas <ilias.apalodimas(a)linaro.org> --- Heinrich, this only applies on top of my rework for the function lib/efi_loader/efi_disk.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/efi_loader/efi_disk.c b/lib/efi_loader/efi_disk.c index 62ca8d7fa516..48440221f4f0 100644 --- a/lib/efi_loader/efi_disk.c +++ b/lib/efi_loader/efi_disk.c @@ -690,10 +690,10 @@ int efi_disk_probe(void *ctx, struct event *event) return 0; } -/* - * Delete an efi_disk object for a block device +/** + * efi_disk_remove - Delete an efi_disk object for a block device or partition * - * @dev uclass device (UCLASS_BLK or UCLASS_PARTITION) + * @dev: uclass device (UCLASS_BLK or UCLASS_PARTITION) * * Delete an efi_disk object which is associated with @dev. * The type of @dev must be either UCLASS_BLK or UCLASS_PARTITION. -- 2.39.2

1 0

[ANN] U-Boot v2023.07-rc4 released
by Tom Rini 12 Jun '23

12 Jun '23

Hey all, I've put out v2023.07-rc4 today, and I think it's a reasonable delta between -rc3 and this. There are a few patches I've put over in: https://patchwork.ozlabs.org/bundle/trini/dont-forget/ that I'll take probably mid-week as they seem like regression fixes (or obviously correct changes) that really shouldn't slip in to the release itself, which is coming up in 3 weeks. In terms of a changelog, git log --merges v2023.07-rc3..v2023.07-rc4 contains what I've pulled but as always, better PR messages and tags will provide better results here. I plan to do one more -rc on June 26th and then final release on July 3rd, 2023. Thanks all! -- Tom

1 0

Pull Request / Patch: Enable Usage of ECC with DDR on AM654x
by Roytburd, Benjamin 12 Jun '23

12 Jun '23

Hello, Recently, when working with the AM65x_GP_EVM development board, I found that the U-boot source code (specifically the SPL), does not properly initialize the DDRSS ram drivers for the AM6548. There are missing register writes that are required from DDR to function with ECC on. I validated this by comparing what U-boot source code does to Texas Instrument DDR test scripts (known as GEL scripts), and these GEL scripts could properly initialize DDR with ECC while U-boot could not, this is due to the missing register writes. The changes are shown here in this pull request: https://github.com/u-boot/u-boot/pull/289 (made just to check CI). Should I submit a patch for this? I have not contributed to U-boot before and would like to know if such a change would be accepted, or even reviewed, as a submission. Thanks, Ben

3 6

Trouble building sandbox
by Sergei Antonov 12 Jun '23

12 Jun '23

Hello! I get a build error with sandbox and sandbox64 configurations in the latest master. Using gcc version 12.2.0 (Ubuntu 12.2.0-3ubuntu1). In file included from .../u-Boot-Zlib/u-boot/include/test/test.h:156, from .../u-boot/include/test/lib.h:9, from .../u-boot/test/lib/test_crc8.c:8: .../u-boot/arch/sandbox/include/asm/test.h: In function ‘sandbox_sdl_set_bpp’: .../u-boot/arch/sandbox/include/asm/test.h:323:17: error: ‘ENOSYS’ undeclared (first use in this function) 323 | return -ENOSYS; | ^~~~~~ It is fixed by adding #include <errno.h> to arch/sandbox/include/asm/test.h Should I submit a patch? Or is it fixed somewhere else?

2 1

[PATCH v2] efi_loader: simplify efi_disk_remove
by Ilias Apalodimas 12 Jun '23

12 Jun '23

Instead of discovering the ID of the device and call two different functions for a block device or a partition, we can rewrite efi_disk_remove() and handle the minor differences between the two variants internally. As a results we can simplify efi_disk_remove() a lot and get rid of the extra efi_disk_delete_raw/blk calls. Signed-off-by: Ilias Apalodimas <ilias.apalodimas(a)linaro.org> --- - Fix CI issues. dev_tag_get_ptr() is called for UCLASS_BLK or UCLASS_PARTITION only lib/efi_loader/efi_disk.c | 80 ++++++++++----------------------------- 1 file changed, 19 insertions(+), 61 deletions(-) diff --git a/lib/efi_loader/efi_disk.c b/lib/efi_loader/efi_disk.c index d2256713a8e7..62ca8d7fa516 100644 --- a/lib/efi_loader/efi_disk.c +++ b/lib/efi_loader/efi_disk.c @@ -691,90 +691,48 @@ int efi_disk_probe(void *ctx, struct event *event) } /* - * Delete an efi_disk object for a whole raw disk + * Delete an efi_disk object for a block device * - * @dev uclass device (UCLASS_BLK) + * @dev uclass device (UCLASS_BLK or UCLASS_PARTITION) * * Delete an efi_disk object which is associated with @dev. - * The type of @dev must be UCLASS_BLK. + * The type of @dev must be either UCLASS_BLK or UCLASS_PARTITION. + * This function is expected to be called at EV_PM_PRE_REMOVE. * * @return 0 on success, -1 otherwise */ -static int efi_disk_delete_raw(struct udevice *dev) +int efi_disk_remove(void *ctx, struct event *event) { + enum uclass_id id; + struct udevice *dev = event->data.dm.dev; efi_handle_t handle; struct blk_desc *desc; - struct efi_disk_obj *diskobj; + struct efi_disk_obj *diskobj = NULL; + + id = device_get_uclass_id(dev); + if (id != UCLASS_BLK && id != UCLASS_PARTITION) + return 0; if (dev_tag_get_ptr(dev, DM_TAG_EFI, (void **)&handle)) return -1; - desc = dev_get_uclass_plat(dev); - if (desc->uclass_id != UCLASS_EFI_LOADER) { + if (id == UCLASS_BLK) { + desc = dev_get_uclass_plat(dev); + if (desc && desc->uclass_id != UCLASS_EFI_LOADER) + diskobj = container_of(handle, struct efi_disk_obj, header); + } else if (id == UCLASS_PARTITION) { diskobj = container_of(handle, struct efi_disk_obj, header); - efi_free_pool(diskobj->dp); } - efi_delete_handle(handle); - dev_tag_del(dev, DM_TAG_EFI); - - return 0; -} - -/* - * Delete an efi_disk object for a disk partition - * - * @dev uclass device (UCLASS_PARTITION) - * - * Delete an efi_disk object which is associated with @dev. - * The type of @dev must be UCLASS_PARTITION. - * - * @return 0 on success, -1 otherwise - */ -static int efi_disk_delete_part(struct udevice *dev) -{ - efi_handle_t handle; - struct efi_disk_obj *diskobj; - - if (dev_tag_get_ptr(dev, DM_TAG_EFI, (void **)&handle)) - return -1; - - diskobj = container_of(handle, struct efi_disk_obj, header); + if (diskobj) + efi_free_pool(diskobj->dp); - efi_free_pool(diskobj->dp); efi_delete_handle(handle); dev_tag_del(dev, DM_TAG_EFI); return 0; } -/* - * Delete an efi_disk object for a block device - * - * @dev uclass device (UCLASS_BLK or UCLASS_PARTITION) - * - * Delete an efi_disk object which is associated with @dev. - * The type of @dev must be either UCLASS_BLK or UCLASS_PARTITION. - * This function is expected to be called at EV_PM_PRE_REMOVE. - * - * @return 0 on success, -1 otherwise - */ -int efi_disk_remove(void *ctx, struct event *event) -{ - enum uclass_id id; - struct udevice *dev; - - dev = event->data.dm.dev; - id = device_get_uclass_id(dev); - - if (id == UCLASS_BLK) - return efi_disk_delete_raw(dev); - else if (id == UCLASS_PARTITION) - return efi_disk_delete_part(dev); - else - return 0; -} - /** * efi_disk_get_device_name() - get U-Boot device name associated with EFI handle * -- 2.39.2

1 0