December 2023 - U-Boot

[PATCH v4 0/5] Implement fastboot multiresponce
by Svyatoslav Ryhel 05 Dec '23

05 Dec '23

Currently u-boot fastboot can only send one message back to host, so if there is a need to print more than one line messages must be kept sending until all the required data is obtained. This behavior can be adjusted using multiresponce ability (getting multiple lines of response) proposed in this patch set. Implementation of multiresponce leads to ability to dump content of console buffer which, with use of "oem run", allows to entirely avoid need in UART. --- Changes from v3: - adjust membuff_readline behavior with overflow Changes from v2: - fix missing function calls if CONFIG_CONSOLE_RECORD is not enabled Changes from v1: - changed variables to static - fixed multiresponce for udp - documented use of "MORE" - converted #if to if (...) --- Ion Agorria (5): fastboot: multiresponse support fastboot: implement "getvar all" common: console: introduce overflow and isempty calls lib: membuff: fix readline not returning line in case of overflow fastboot: add oem console command support common/console.c | 15 ++++-- doc/android/fastboot-protocol.rst | 3 ++ doc/android/fastboot.rst | 1 + drivers/fastboot/Kconfig | 7 +++ drivers/fastboot/fb_command.c | 52 +++++++++++++++++++++ drivers/fastboot/fb_getvar.c | 77 +++++++++++++++++++++++++------ drivers/usb/gadget/f_fastboot.c | 29 ++++++++++++ include/console.h | 26 +++++++++++ include/fastboot-internal.h | 7 +++ include/fastboot.h | 19 ++++++++ lib/membuff.c | 10 ---- net/fastboot_udp.c | 29 +++++++++--- test/ut.c | 9 ++-- 13 files changed, 247 insertions(+), 37 deletions(-) -- 2.40.1

2 7

[ANN] U-Boot v2024.01-rc4 released
by Tom Rini 04 Dec '23

04 Dec '23

Hey all, It's release day and here is -rc4. There's just a few fixes I know of outstanding at this point, and only one of them (NAND for AM335x platforms) I think isn't something that can be said to be provably correct, to try and borrow mathematical terms. In terms of a changelog, git log --merges v2024.01-rc3..v2024.01-rc4 contains what I've pulled but as always, better PR messages and tags will provide better results here. I hope to remain on schedule and that means the rest of the rcs every other Monday, and with final release on January 8th, 2024. Thanks all! -- Tom

1 0

[PATCH 1/1] efi_loader: generated SMBIOS table below 4 GiB
by Heinrich Schuchardt 04 Dec '23

04 Dec '23

We currently use an outdated format 32-bit format for SMBIOS tables. So we must allocate SMBIOS tables below 4 GiB. Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt(a)canonical.com> --- lib/efi_loader/efi_smbios.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/lib/efi_loader/efi_smbios.c b/lib/efi_loader/efi_smbios.c index 48446f654d..0fbf51b98d 100644 --- a/lib/efi_loader/efi_smbios.c +++ b/lib/efi_loader/efi_smbios.c @@ -49,25 +49,27 @@ efi_status_t efi_smbios_register(void) static int install_smbios_table(void) { - ulong addr; - void *buf; + u64 addr; + efi_status_t ret; if (!IS_ENABLED(CONFIG_GENERATE_SMBIOS_TABLE) || IS_ENABLED(CONFIG_X86)) return 0; - /* Align the table to a 4KB boundary to keep EFI happy */ - buf = memalign(SZ_4K, TABLE_SIZE); - if (!buf) + addr = SZ_4G; + ret = efi_allocate_pages(EFI_ALLOCATE_MAX_ADDRESS, + EFI_RUNTIME_SERVICES_DATA, + efi_size_in_pages(TABLE_SIZE), &addr); + if (ret != EFI_SUCCESS) return log_msg_ret("mem", -ENOMEM); - addr = map_to_sysmem(buf); + addr = map_to_sysmem((void *)(uintptr_t)addr); if (!write_smbios_table(addr)) { log_err("Failed to write SMBIOS table\n"); return log_msg_ret("smbios", -EINVAL); } /* Make a note of where we put it */ - log_debug("SMBIOS tables written to %lx\n", addr); + log_debug("SMBIOS tables written to %llx\n", addr); gd->arch.smbios_start = addr; return 0; -- 2.40.1

3 2

[PATCH 0/2] serial: msm-geni: rework oversampling and fix clk API bug
by Caleb Connolly 04 Dec '23

04 Dec '23

These patches improve GENI UART support during init by implementing the parent property read directly rather than via a misc device, and fixing the error path when the clock can't be found. In my testing, the first few lines of UART output on platforms with non-default oversampling values is often garbled, this is because the parent misc device hasn't yet probed and so the clock rate is incorrect. It is simpler to just access the geni-se parent device directly rather than via a misc device, especially as we only need to read a single register for now. Additionally, this series makes it a hard requirement that the GENI UART node is a child of the generic geni-se controller. This allows us to print a useful error if DTS is incorrect rather than attempting to continue without reading the oversampling value could result in a lot of confusion during platform bringup. --- Caleb Connolly (2): serial: msm-geni: don't rely on parent misc device serial: msm-geni: handle devm_clk_get() errors drivers/misc/Kconfig | 7 ------- drivers/misc/Makefile | 1 - drivers/misc/qcom-geni-se.c | 41 ---------------------------------------- drivers/serial/Kconfig | 2 -- drivers/serial/serial_msm_geni.c | 40 ++++++++++++++++++++++++++------------- 5 files changed, 27 insertions(+), 64 deletions(-) --- base-commit: f3fc930d775ef5c1b7b74b1427491a17680e66ae // Caleb (they/them)

1 4

[PATCH 0/4] Support StarFive Watchdog driver
by Chanho Park 04 Dec '23

04 Dec '23

This patchset adds to support StarFive Watchdog driver which is based on Linux kernel's starfive-wdt driver. Actually, the original driver supports both JH7100 and JH7110 with variant coding but this removes the JH7100 part of codes because JH7100 isn't supported in u-boot yet. However, this patch tries to keep the variant coding style for future work of JH7100 and have a consistency with the Linux driver. Chanho Park (4): clk: starfive: jh7110: Add watchdog clocks watchdog: Add StarFive Watchdog driver riscv: dts: jh7110: Add watchdog device tree node configs: visionfive2: Enable watchdog driver arch/riscv/dts/jh7110.dtsi | 10 + configs/starfive_visionfive2_defconfig | 5 + drivers/clk/starfive/clk-jh7110.c | 9 + drivers/watchdog/Kconfig | 7 + drivers/watchdog/Makefile | 1 + drivers/watchdog/starfive_wdt.c | 329 +++++++++++++++++++++++++ 6 files changed, 361 insertions(+) create mode 100644 drivers/watchdog/starfive_wdt.c -- 2.39.2

3 9

[PATCH V3 0/3] doc: falcon: riscv: Falcon Mode boot on RISC-V
by Randolph 04 Dec '23

04 Dec '23

Changes in v3: - Change by suggestions in falcon.rst - Move the board-related code to arch-specific code, its the issue when enabling LOAD_FIT_OPENSBI_OS_BOOT - Add SPL_PAYLOAD_ARGS_ADDR to defconfig. This is the address that SPL copies into defconfig. Randolph (3): doc: falcon: riscv: Falcon Mode boot on RISC-V spl: riscv: falcon: move fdt blob to specified address configs: andes: add the fdt blob address for SPL copy to board/AndesTech/ae350/ae350.c | 25 ---- common/spl/Kconfig | 2 +- common/spl/spl_opensbi.c | 16 +++ configs/ae350_rv32_falcon_defconfig | 1 + configs/ae350_rv32_falcon_xip_defconfig | 1 + configs/ae350_rv64_falcon_defconfig | 1 + configs/ae350_rv64_falcon_xip_defconfig | 1 + doc/develop/falcon.rst | 171 ++++++++++++++++++++++++ 8 files changed, 192 insertions(+), 26 deletions(-) -- 2.34.1

2 6

[PATCH] starfive: visionfive2: add device tree overlay support
by John Clark 04 Dec '23

04 Dec '23

device tree overlay support requires fdtoverlay_addr_r to be set before ~~~~~~ Invalid fdtoverlay_addr_r for loading overlays after ~~~~~ Retrieving file: /boot/overlay/rtc-ds3231.dtbo Signed-off-by: John Clark <inindev(a)gmail.com> --- include/configs/starfive-visionfive2.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/configs/starfive-visionfive2.h b/include/configs/starfive-visionfive2.h index ff43113f24..29c74470c7 100644 --- a/include/configs/starfive-visionfive2.h +++ b/include/configs/starfive-visionfive2.h @@ -40,6 +40,7 @@ "kernel_comp_addr_r=0x88000000\0" \ "kernel_comp_size=0x4000000\0" \ "fdt_addr_r=0x46000000\0" \ + "fdtoverlay_addr_r=0x45800000\0" \ "scriptaddr=0x43900000\0" \ "pxefile_addr_r=0x45900000\0" \ "ramdisk_addr_r=0x46100000\0" \ -- 2.42.0

2 2

[PATCH v2] watchdog: Correct watchdog timeout print message
by Chanho Park 04 Dec '23

04 Dec '23

The wdt_start function takes timeout_ms as a parameter and starts the watchdog with this value. However, when you output the message, it shows the default timeout value for the watchdog device. So this patch fixes that part to output the correct timeout value. Before --> StarFive # wdt start 3000 WDT: Started watchdog@13070000 without servicing (60s timeout) After --> StarFive # wdt start 3000 WDT: Started watchdog@13070000 without servicing (3s timeout) Fixes: c2fd0ca1a822 ("watchdog: Integrate watchdog triggering into the cyclic framework") Signed-off-by: Chanho Park <chanho61.park(a)samsung.com> --- Change from v1: - Use lldiv to fix a build error of m68k arch drivers/watchdog/wdt-uclass.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/watchdog/wdt-uclass.c b/drivers/watchdog/wdt-uclass.c index ed329284decb..417e8d7eef95 100644 --- a/drivers/watchdog/wdt-uclass.c +++ b/drivers/watchdog/wdt-uclass.c @@ -7,6 +7,7 @@ #include <common.h> #include <cyclic.h> +#include <div64.h> #include <dm.h> #include <errno.h> #include <hang.h> @@ -141,7 +142,7 @@ int wdt_start(struct udevice *dev, u64 timeout_ms, ulong flags) printf("WDT: Started %s with%s servicing %s (%ds timeout)\n", dev->name, IS_ENABLED(CONFIG_WATCHDOG) ? "" : "out", - str, priv->timeout); + str, (u32)lldiv(timeout_ms, 1000)); } return ret; -- 2.39.2

2 2

[PATCH v1 0/3] Add T114 video support
by Svyatoslav Ryhel 04 Dec '23

04 Dec '23

T114 is not that different from T30 and all T30 drivers will work on T114 as well with some minor adjustments. Commits pass buildman for tegra and U-Boot tests. Svyatoslav Ryhel (3): video: tegra20: dc: add T114 support video: tegra20: add MIPI calibration driver video: tegra20: dsi: add T114 support arch/arm/dts/tegra114-u-boot.dtsi | 9 + arch/arm/include/asm/arch-tegra/dsi.h | 235 +++++++++++++++++++ arch/arm/include/asm/arch-tegra114/display.h | 28 +++ arch/arm/include/asm/arch-tegra114/pwm.h | 13 + arch/arm/include/asm/arch-tegra30/dsi.h | 211 +---------------- drivers/video/tegra20/Makefile | 2 +- drivers/video/tegra20/tegra-dc.c | 1 + drivers/video/tegra20/tegra-dsi.c | 78 +++++- drivers/video/tegra20/tegra-mipi.c | 185 +++++++++++++++ 9 files changed, 550 insertions(+), 212 deletions(-) create mode 100644 arch/arm/include/asm/arch-tegra/dsi.h create mode 100644 arch/arm/include/asm/arch-tegra114/display.h create mode 100644 arch/arm/include/asm/arch-tegra114/pwm.h create mode 100644 drivers/video/tegra20/tegra-mipi.c -- 2.40.1

1 3

[PATCH] mmc: Poll CD in case cyclic framework is enabled
by Marek Vasut 04 Dec '23

04 Dec '23

In case the cyclic framework is enabled, poll the card detect of already initialized cards and deinitialize them in case they are removed. Since the card initialization is a longer process and card initialization is done on first access to an uninitialized card anyway, avoid initializing newly detected uninitialized cards in the cyclic callback. Signed-off-by: Marek Vasut <marek.vasut+renesas(a)mailbox.org> --- Cc: Jaehoon Chung <jh80.chung(a)samsung.com> Cc: Peng Fan <peng.fan(a)nxp.com> --- drivers/mmc/mmc-uclass.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c index cdead044177..c4c9881c40b 100644 --- a/drivers/mmc/mmc-uclass.c +++ b/drivers/mmc/mmc-uclass.c @@ -8,6 +8,7 @@ #define LOG_CATEGORY UCLASS_MMC #include <common.h> +#include <cyclic.h> #include <bootdev.h> #include <log.h> #include <mmc.h> @@ -343,8 +344,23 @@ struct blk_desc *mmc_get_blk_desc(struct mmc *mmc) return desc; } +static void mmc_cyclic_cd_poll(void *ctx) +{ + struct mmc *m = ctx; + + if (!m->has_init) + return; + + if (mmc_getcd(m)) + return; + + mmc_deinit(m); + m->has_init = 0; +} + void mmc_do_preinit(void) { + struct cyclic_info *cyclic; struct udevice *dev; struct uclass *uc; int ret; @@ -362,6 +378,17 @@ void mmc_do_preinit(void) if (m->preinit) mmc_start_init(m); + + if (!CONFIG_IS_ENABLED(CYCLIC)) + continue; + + /* Register cyclic function for card detect polling */ + cyclic = cyclic_register(mmc_cyclic_cd_poll, 100 * 1000, + m->cfg->name, m); + if (cyclic) + continue; + + printf("Failed to register %s CD poll function\n", m->cfg->name); } } -- 2.42.0

4 6