January 2023 - U-Boot

[PATCH 0/6] Add u-boot splash screen support for AM62x
by Nikhil M Jain 26 Jan '23

26 Jan '23

Enable TI Display Subsystem(TIDSS) driver as UCLASS_VIDEO. Enable splash screen support, to display TI logo during boot-up. Tested on microtips panel (Model No: 13-101HIEBCAF0-S) supported by AM62x. The changes in patch 4 depends on the patch sent for addition of am62x.env file to set environment variables for AM62x. link: https://lore.kernel.org/u-boot/20230123063018.6061-1-n-jain1@ti.com/T/#u Nikhil M Jain (6): drivers: core: ofnode: Add panel timing decode. drivers: video: simple_panel: make simple panel independent of backlight drivers: video: tidss: TIDSS video driver support for AM62x board: ti: am62x: am62x: Add splash screen env variables board: ti: am62x: evm: Add splash screen support tools: logos: Add TI logo files MAINTAINERS | 1 + board/ti/am62x/am62x.env | 5 + board/ti/am62x/evm.c | 31 + drivers/core/ofnode.c | 53 ++ drivers/video/Kconfig | 2 + drivers/video/Makefile | 1 + drivers/video/simple_panel.c | 7 +- drivers/video/tidss/Kconfig | 18 + drivers/video/tidss/Makefile | 12 + drivers/video/tidss/tidss_drv.c | 960 +++++++++++++++++++++++++++++++ drivers/video/tidss/tidss_drv.h | 152 +++++ drivers/video/tidss/tidss_regs.h | 292 ++++++++++ include/dm/ofnode.h | 12 + tools/logos/ti.bmp | Bin 0 -> 447258 bytes tools/logos/ti.gz | Bin 0 -> 19604 bytes 15 files changed, 1544 insertions(+), 2 deletions(-) create mode 100644 drivers/video/tidss/Kconfig create mode 100644 drivers/video/tidss/Makefile create mode 100644 drivers/video/tidss/tidss_drv.c create mode 100644 drivers/video/tidss/tidss_drv.h create mode 100644 drivers/video/tidss/tidss_regs.h create mode 100644 tools/logos/ti.bmp create mode 100644 tools/logos/ti.gz -- 2.17.1

3 13

[PATCH 00/14] fdt: Improvements for fdt and tracing
by Simon Glass 26 Jan '23

26 Jan '23

This series aims to make it easier to measure boot performance, particularly aimed at rockpro64. It includes the following: - enabling bootstage on rockpro64 (TPL, SPL, U-Boot proper) - minor fixes and tidy-ups for tracing - minor FDT code tidy-ups It also reverts a patch which slows down the boot by 30ms. This revert was requested some time ago but with this series we have the data showing the impact. Changes in v1: - Add detail of impact Simon Glass (14): trace: Use notrace for short arm: Support trace on armv8 tpm: Add a proper Kconfig option for crc8 in SPL fdt: Avoid exporting fdtdec_prepare_fdt() fdt: Drop ifdefs in fdtdec_prepare_fdt() fdt: Pass the device tree to fdtdec_prepare_fdt() fdt: Check for overlapping data and FDT trace: Move trace pointer to data section mkimage: Add a few more messages for FIT failures trace: Adjust flags in proftool trace: Update trace-format generator for newer version trace: Don't require TIMER_EARLY rockchip: Enable bootstage on rockpro64 Revert "fdtdec: drop needlessly convoluted CONFIG_PHANDLE_CHECK_SEQ" arch/arm/cpu/armv7/s5p-common/timer.c | 2 +- arch/arm/cpu/armv8/generic_timer.c | 6 +- arch/arm/mach-exynos/include/mach/cpu.h | 6 +- arch/arm/mach-rockchip/tpl.c | 18 ++++- arch/x86/include/asm/global_data.h | 2 +- arch/x86/include/asm/msr.h | 2 +- arch/x86/include/asm/u-boot-x86.h | 2 +- common/spl/spl.c | 2 +- common/spl/spl_fit.c | 1 + configs/am65x_evm_a53_defconfig | 1 + configs/evb-ast2600_defconfig | 1 + configs/rockpro64-rk3399_defconfig | 8 +++ configs/sama7g5ek_mmc1_defconfig | 1 + configs/sama7g5ek_mmc_defconfig | 1 + doc/develop/trace.rst | 2 +- include/fdtdec.h | 9 --- lib/Kconfig | 26 ++++++- lib/Makefile | 3 +- lib/efi_loader/efi_freestanding.c | 4 +- lib/fdtdec.c | 92 ++++++++++++++++--------- lib/trace.c | 29 ++++---- tools/fit_image.c | 4 +- tools/image-host.c | 6 +- tools/proftool.c | 43 +++++++----- 24 files changed, 175 insertions(+), 96 deletions(-) -- 2.39.0.314.g84b9a713c41-goog

3 30

[PATCH 1/1] usb: move CONFIG_USB_HUB_DEBOUNCE_TIMEOUT to USB
by Heinrich Schuchardt 25 Jan '23

25 Jan '23

This configuration setting is only relevant if the board supports USB. It should not be in the main menu but in the USB menu. Fixes: 5454dea3137d ("usb: hub: allow to increase HUB_DEBOUNCE_TIMEOUT") Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt(a)canonical.com> --- common/Kconfig | 12 ------------ drivers/usb/Kconfig | 11 +++++++++++ 2 files changed, 11 insertions(+), 12 deletions(-) diff --git a/common/Kconfig b/common/Kconfig index e3a5e1be1e..0afc01b759 100644 --- a/common/Kconfig +++ b/common/Kconfig @@ -1106,15 +1106,3 @@ config FDT_SIMPLEFB config IO_TRACE bool - -config USB_HUB_DEBOUNCE_TIMEOUT - int "Timeout in milliseconds for USB HUB connection" - depends on USB - default 1000 - help - Value in milliseconds of the USB connection timeout, the max delay to - wait the hub port status to be connected steadily after being powered - off and powered on in the usb hub driver. - This define allows to increase the HUB_DEBOUNCE_TIMEOUT default - value = 1s because some usb device needs around 1.5s to be initialized - and a 2s value should solve detection issue on problematic USB keys. diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig index ebe6bf9498..8b957793ff 100644 --- a/drivers/usb/Kconfig +++ b/drivers/usb/Kconfig @@ -53,6 +53,17 @@ config SPL_DM_USB default n if ARCH_MVEBU default y +config USB_HUB_DEBOUNCE_TIMEOUT + int "Timeout in milliseconds for USB HUB connection" + default 1000 + help + Value in milliseconds of the USB connection timeout, the max delay to + wait the hub port status to be connected steadily after being powered + off and powered on in the usb hub driver. + This define allows to increase the HUB_DEBOUNCE_TIMEOUT default + value = 1s because some usb device needs around 1.5s to be initialized + and a 2s value should solve detection issue on problematic USB keys. + config DM_USB_GADGET bool "Enable driver model for USB Gadget" depends on DM_USB -- 2.38.1

2 3

[PATCH] bootstd: Replicate the dtb-filename quirks of distroboot
by Simon Glass 25 Jan '23

25 Jan '23

For EFI, the distro boot scripts search in three different directories for the .dtb file. The SOC-based filename fallback is supported only for 32-bit ARM. Adjust the code to mirror this behaviour. Signed-off-by: Simon Glass <sjg(a)chromium.org> Suggested-by: Mark Kettenis <kettenis(a)openbsd.org> --- boot/bootmeth_efi.c | 63 ++++++++++++++++++++++++++++++++++++++------- 1 file changed, 54 insertions(+), 9 deletions(-) diff --git a/boot/bootmeth_efi.c b/boot/bootmeth_efi.c index 67c972e3fe4..f9544846e68 100644 --- a/boot/bootmeth_efi.c +++ b/boot/bootmeth_efi.c @@ -147,25 +147,57 @@ static int distro_efi_check(struct udevice *dev, struct bootflow_iter *iter) return 0; } -static void distro_efi_get_fdt_name(char *fname, int size) +/** + * distro_efi_get_fdt_name() - Get the filename for reading the .dtb file + * + * @fname: Place to put filename + * @size: Max size of filename + * @seq: Sequence number, to cycle through options (0=first) + * Returns: 0 on success, -ENOENT if the "fdtfile" env var does not exist, + * -EINVAL if there are no more options + */ +static int distro_efi_get_fdt_name(char *fname, int size, int seq) { const char *fdt_fname; + const char *prefix; + + /* select the prefix */ + switch (seq) { + case 0: + /* this is the default */ + prefix = "/dtb"; + break; + case 1: + prefix = ""; + break; + case 2: + prefix = "/dtb/current"; + break; + default: + return log_msg_ret("pref", -EINVAL); + } fdt_fname = env_get("fdtfile"); if (fdt_fname) { - snprintf(fname, size, "dtb/%s", fdt_fname); + snprintf(fname, size, "%s/%s", prefix, fdt_fname); log_debug("Using device tree: %s\n", fname); - } else { + + /* Use this fallback only for 32-bit ARM */ + } else if (IS_ENABLED(CONFIG_ARM) && !IS_ENABLED(CONFIG_ARM64)) { const char *soc = env_get("soc"); const char *board = env_get("board"); const char *boardver = env_get("boardver"); /* cf the code in label_boot() which seems very complex */ - snprintf(fname, size, "dtb/%s%s%s%s.dtb", + snprintf(fname, size, "%s/%s%s%s%s.dtb", prefix, soc ? soc : "", soc ? "-" : "", board ? board : "", boardver ? boardver : ""); log_debug("Using default device tree: %s\n", fname); + } else { + return log_msg_ret("env", -ENOENT); } + + return 0; } static int distro_efi_read_bootflow_file(struct udevice *dev, @@ -174,7 +206,7 @@ static int distro_efi_read_bootflow_file(struct udevice *dev, struct blk_desc *desc = NULL; ulong fdt_addr, size; char fname[256]; - int ret; + int ret, seq; /* We require a partition table */ if (!bflow->part) @@ -196,13 +228,22 @@ static int distro_efi_read_bootflow_file(struct udevice *dev, if (ret) return log_msg_ret("read", -EINVAL); - distro_efi_get_fdt_name(fname, sizeof(fname)); + fdt_addr = env_get_hex("fdt_addr_r", 0); + + /* try the various available names */ + ret = -ENOENT; + for (seq = 0; ret; seq++) { + ret = distro_efi_get_fdt_name(fname, sizeof(fname), seq); + if (ret) + return log_msg_ret("nam", ret); + ret = bootmeth_common_read_file(dev, bflow, fname, fdt_addr, + &size); + } + bflow->fdt_fname = strdup(fname); if (!bflow->fdt_fname) return log_msg_ret("fil", -ENOMEM); - fdt_addr = env_get_hex("fdt_addr_r", 0); - ret = bootmeth_common_read_file(dev, bflow, fname, fdt_addr, &size); if (!ret) { bflow->fdt_size = size; bflow->fdt_addr = fdt_addr; @@ -277,7 +318,11 @@ static int distro_efi_read_bootflow_net(struct bootflow *bflow) fdt_addr = hextoul(fdt_addr_str, NULL); sprintf(file_addr, "%lx", fdt_addr); - distro_efi_get_fdt_name(fname, sizeof(fname)); + /* We only allow the first prefix with PXE */ + ret = distro_efi_get_fdt_name(fname, sizeof(fname), 0); + if (ret) + return log_msg_ret("nam", ret); + bflow->fdt_fname = strdup(fname); if (!bflow->fdt_fname) return log_msg_ret("fil", -ENOMEM); -- 2.39.1.405.gd4c25cc71f-goog

3 4

Pull request: u-boot-sunxi/master for 2023.04
by Andre Przywara 25 Jan '23

25 Jan '23

Hi Tom, please pull the first part of the sunxi pull request for this cycle. This contains some fixes, and the first bunch of some clean up patches to get rid of legacy GPIO and PMIC code. Highlight is the DM AXP PMIC driver, which is required to convert some drivers over to use DM regulators, and also is required to get rid of some less optimal PMIC setup code in Trusted Firmware. This isn't enabled by any defconfig yet, but can be enabled manually and works. For the full glory some patches are still missing, and this requires more testing, which would be simpler if the core code is upstream. I couldn't get the gitlab CI to pass, it seemed to time out in the last step, when building all ARM(32) boards. I built all sunxi boards with buildman locally, without issues, so this should be fine. Tested on an H3, A64, R40, A20 and H6 board. If everything goes well, I will send a second part later this week, some patches still need some review and testing. Thanks, Andre ======================== The following changes since commit dd31cd58b02729807934cb699b164b1f8736620f: Merge tag 'efi-2023-04-rc1-2' of https://source.denx.de/u-boot/custodians/u-boot-efi (2023-01-20 14:23:20 -0500) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-sunxi.git master for you to fetch changes up to cd108f2795777d3cca1d0f00c50bb92f766f6591: video: sunxi: dw-hdmi: Read address from DT node (2023-01-23 01:18:31 +0000) ---------------------------------------------------------------- Andre Przywara (9): sunxi: f1c100s: re-enable SYSRESET sunxi: f1c100s: Drop no-MMC hack sunxi: armv8: fel: load only 32-bit values sunxi: h616: lower SPL stack address to avoid BROM data sunxi: fel: drop redundant "control register" save/restore sunxi: mmc: ignore card detect in SPL sunxi: mmc: group non-DM specific functions sunxi: remove CONFIG_MMC?_CD_PIN sunxi: eMMC: support TOC0 on boot partitions Jernej Skrabec (2): video: sunxi: dw-hdmi: Probe driver by compatible video: sunxi: dw-hdmi: Read address from DT node Samuel Holland (4): power: pmic: axp: Provide a variant ID in the driver data power: regulator: Add a driver for AXP PMIC regulators power: pmic: axp: Bind regulators from the DT clk: sunxi: Add DE2 display-related clocks/resets arch/arm/cpu/armv7/sunxi/fel_utils.S | 4 - arch/arm/cpu/armv8/fel_utils.S | 8 +- arch/arm/dts/sunxi-u-boot.dtsi | 2 - arch/arm/mach-sunxi/Kconfig | 27 --- arch/arm/mach-sunxi/board.c | 12 +- configs/A10-OLinuXino-Lime_defconfig | 1 - configs/A10s-OLinuXino-M_defconfig | 2 - configs/A13-OLinuXinoM_defconfig | 1 - configs/A13-OLinuXino_defconfig | 1 - configs/A20-OLinuXino-Lime2-eMMC_defconfig | 1 - configs/A20-OLinuXino-Lime2_defconfig | 1 - configs/A20-OLinuXino-Lime_defconfig | 1 - configs/A20-OLinuXino_MICRO-eMMC_defconfig | 1 - configs/A20-OLinuXino_MICRO_defconfig | 2 - configs/A20-Olimex-SOM-EVB_defconfig | 2 - configs/A20-Olimex-SOM204-EVB-eMMC_defconfig | 1 - configs/A20-Olimex-SOM204-EVB_defconfig | 1 - configs/A33-OLinuXino_defconfig | 1 - configs/Ainol_AW1_defconfig | 1 - configs/Ampe_A76_defconfig | 1 - configs/Bananapi_M2_Ultra_defconfig | 1 - configs/Bananapi_m2m_defconfig | 1 - configs/Cubieboard2_defconfig | 1 - configs/Cubieboard4_defconfig | 1 - configs/Cubieboard_defconfig | 1 - configs/Cubietruck_defconfig | 1 - configs/Empire_electronix_d709_defconfig | 1 - configs/Empire_electronix_m712_defconfig | 1 - configs/Itead_Ibox_A20_defconfig | 1 - configs/Lamobo_R1_defconfig | 1 - configs/Mele_M3_defconfig | 1 - configs/Mele_M5_defconfig | 1 - configs/Merrii_A80_Optimus_defconfig | 1 - configs/Orangepi_mini_defconfig | 2 - configs/Sinlinx_SinA31s_defconfig | 1 - configs/Sinlinx_SinA33_defconfig | 1 - configs/Sunchip_CX-A99_defconfig | 1 - configs/UTOO_P66_defconfig | 1 - configs/Wobo_i5_defconfig | 1 - configs/Yones_Toptech_BD1078_defconfig | 2 - configs/Yones_Toptech_BS1078_V2_defconfig | 1 - configs/bananapi_m2_berry_defconfig | 1 - configs/bananapi_m2_zero_defconfig | 1 - configs/bananapi_m64_defconfig | 1 - configs/beelink_gs1_defconfig | 1 - configs/colorfly_e708_q1_defconfig | 1 - configs/difrnce_dit4350_defconfig | 1 - configs/dserve_dsrv9703c_defconfig | 1 - configs/gt90h_v4_defconfig | 1 - configs/iNet_3F_defconfig | 1 - configs/iNet_3W_defconfig | 1 - configs/iNet_D978_rev2_defconfig | 1 - configs/icnova-a20-swac_defconfig | 1 - configs/inet86dz_defconfig | 1 - configs/inet98v_rev2_defconfig | 1 - configs/inet_q972_defconfig | 1 - configs/licheepi_nano_defconfig | 1 - configs/nanopi_m1_plus_defconfig | 1 - configs/oceanic_5205_5inmfd_defconfig | 1 - configs/orangepi_3_defconfig | 1 - configs/orangepi_lite2_defconfig | 1 - configs/orangepi_one_plus_defconfig | 1 - configs/orangepi_zero2_defconfig | 1 - configs/orangepi_zero_plus2_defconfig | 1 - configs/orangepi_zero_plus2_h3_defconfig | 1 - configs/parrot_r16_defconfig | 1 - configs/pine64-lts_defconfig | 1 - configs/pine_h64_defconfig | 1 - configs/polaroid_mid2407pxe03_defconfig | 1 - configs/polaroid_mid2809pxe04_defconfig | 1 - configs/q8_a13_tablet_defconfig | 1 - configs/q8_a23_tablet_800x480_defconfig | 1 - configs/q8_a33_tablet_1024x600_defconfig | 1 - configs/q8_a33_tablet_800x480_defconfig | 1 - configs/sopine_baseboard_defconfig | 1 - configs/tanix_tx6_defconfig | 1 - configs/x96_mate_defconfig | 1 - drivers/clk/sunxi/clk_a64.c | 22 ++ drivers/clk/sunxi/clk_a83t.c | 22 ++ drivers/clk/sunxi/clk_h3.c | 17 ++ drivers/clk/sunxi/clk_h6.c | 21 ++ drivers/clk/sunxi/clk_h616.c | 21 ++ drivers/clk/sunxi/clk_r40.c | 29 +++ drivers/clk/sunxi/clk_v3s.c | 9 + drivers/mmc/sunxi_mmc.c | 152 ++++++------- drivers/power/pmic/axp.c | 36 +++- drivers/power/regulator/Kconfig | 14 ++ drivers/power/regulator/Makefile | 1 + drivers/power/regulator/axp_regulator.c | 312 +++++++++++++++++++++++++++ drivers/video/sunxi/sunxi_dw_hdmi.c | 57 +++-- include/axp_pmic.h | 12 ++ include/configs/sunxi-common.h | 2 +- 92 files changed, 617 insertions(+), 240 deletions(-) create mode 100644 drivers/power/regulator/axp_regulator.c

2 1

Re: [PATCH 1/7] board: rockchip: Add rk3588 evb board support
by Jagan Teki 25 Jan '23

25 Jan '23

On Wed, 25 Jan 2023 at 21:14, "瘦橘猫" <19983723760(a)189.cn> wrote: > > Hi > > The board configuration file for the rk3588 evb does not contain atf, or even tpl and spl. What I am going to do now is add some configuration items for rk3588s based on rk3588, if successful, to verify that the ATF is available. Thank you for your comments For your information, ATF can be part of rkbin and export BL31 in u-boot in order to build as part of it. are you checking this step? Jagan.

1 0

[PATCH 1/2 v2] tpm: add a function that performs selftest + startup
by Ilias Apalodimas 25 Jan '23

25 Jan '23

As described in [0] if a command requires use of an untested algorithm or functional module, the TPM performs the test and then completes the command actions. Since we don't check for TPM_RC_NEEDS_TEST (which is the return code of the TPM in that case) and even if we would, it would complicate our TPM code for no apparent reason, add a wrapper function that performs both the selftest and the startup sequence of the TPM. It's worth noting that this is implemented on TPMv2.0. The code for 1.2 would look similar, but I don't have a device available to test. [0] https://trustedcomputinggroup.org/wp-content/uploads/TPM-Rev-2.0-Part-1-Arc… §12.3 Self-test modes Signed-off-by: Ilias Apalodimas <ilias.apalodimas(a)linaro.org> --- Changes since v1: - Remove a superfluous if statement - Move function comments to the header file include/tpm-v2.h | 19 +++++++++++++++++++ include/tpm_api.h | 8 ++++++++ lib/tpm-v2.c | 17 +++++++++++++++++ lib/tpm_api.c | 8 ++++++++ 4 files changed, 52 insertions(+) diff --git a/include/tpm-v2.h b/include/tpm-v2.h index 737e57551d73..60031edd275b 100644 --- a/include/tpm-v2.h +++ b/include/tpm-v2.h @@ -688,4 +688,23 @@ u32 tpm2_report_state(struct udevice *dev, uint vendor_cmd, uint vendor_subcmd, u32 tpm2_enable_nvcommits(struct udevice *dev, uint vendor_cmd, uint vendor_subcmd); +/** + * tpm2_auto_start() - start up the TPM and perform selftests. + * If a testable function has not been tested and is + * requested the TPM2 will return TPM_RC_NEEDS_TEST. + * + * + * + * @param dev TPM device + * Return: TPM_RC_TESTING, if TPM2 self-test has been received and the tests are + * not complete. + * TPM_RC_SUCCESS, if testing of all functions is complete without + * functional failures. + * TPM2_RC_FAILURE, if any test failed. + * TPM2_RC_INITIALIZE, if the TPM has not gone through the Startup + * sequence + + */ +u32 tpm2_auto_start(struct udevice *dev); + #endif /* __TPM_V2_H */ diff --git a/include/tpm_api.h b/include/tpm_api.h index 8979d9d6df7e..022a8bbaeca6 100644 --- a/include/tpm_api.h +++ b/include/tpm_api.h @@ -331,4 +331,12 @@ static inline bool tpm_is_v2(struct udevice *dev) return IS_ENABLED(CONFIG_TPM_V2) && tpm_get_version(dev) == TPM_V2; } +/** + * tpm_auto_start() - start up the TPM and perform selftests + * + * @param dev TPM device + * Return: return code of the operation (0 = success) + */ +u32 tpm_auto_start(struct udevice *dev); + #endif /* __TPM_API_H */ diff --git a/lib/tpm-v2.c b/lib/tpm-v2.c index 697b982e079f..9ab5b46df177 100644 --- a/lib/tpm-v2.c +++ b/lib/tpm-v2.c @@ -44,6 +44,23 @@ u32 tpm2_self_test(struct udevice *dev, enum tpm2_yes_no full_test) return tpm_sendrecv_command(dev, command_v2, NULL, NULL); } +u32 tpm2_auto_start(struct udevice *dev) +{ + u32 rc; + + rc = tpm2_self_test(dev, TPMI_YES); + + if (rc == TPM2_RC_INITIALIZE) { + rc = tpm2_startup(dev, TPM2_SU_CLEAR); + if (rc) + return rc; + + rc = tpm2_self_test(dev, TPMI_YES); + } + + return rc; +} + u32 tpm2_clear(struct udevice *dev, u32 handle, const char *pw, const ssize_t pw_sz) { diff --git a/lib/tpm_api.c b/lib/tpm_api.c index 7e8df8795ef3..5b2c11a277cc 100644 --- a/lib/tpm_api.c +++ b/lib/tpm_api.c @@ -35,6 +35,14 @@ u32 tpm_startup(struct udevice *dev, enum tpm_startup_type mode) } } +u32 tpm_auto_start(struct udevice *dev) +{ + if (tpm_is_v2(dev)) + return tpm2_auto_start(dev); + + return -ENOSYS; +} + u32 tpm_resume(struct udevice *dev) { if (tpm_is_v1(dev)) -- 2.38.1

1 1

[PATCH] usb: host: ehci-generic: Handle DM_RESET=n case
by Marek Vasut 25 Jan '23

25 Jan '23

In case CONFIG_DM_RESET=n, reset_get_bulk() returns -ENOTSUPP. Do not fail in that case either. This is a valid use case, e.g. in case the reset driver is a no-op and would only waste space in the build. Fixes: 81755b8c20f ("usb: host: ehci-generic: Make resets and clocks optional") Signed-off-by: Marek Vasut <marek.vasut+renesas(a)mailbox.org> --- Cc: Andre Przywara <andre.przywara(a)arm.com> Cc: Patrice Chotard <patrice.chotard(a)foss.st.com> --- drivers/usb/host/ehci-generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-generic.c b/drivers/usb/host/ehci-generic.c index a765a307a32..83fe701ff67 100644 --- a/drivers/usb/host/ehci-generic.c +++ b/drivers/usb/host/ehci-generic.c @@ -81,7 +81,7 @@ static int ehci_usb_probe(struct udevice *dev) } err = reset_get_bulk(dev, &priv->resets); - if (err && err != -ENOENT) { + if (err && err != -ENOENT && err != -ENOTSUPP) { dev_err(dev, "Failed to get resets (err=%d)\n", err); goto clk_err; } -- 2.39.0

4 5

[PATCH 1/2] tpm: add a function that performs selftest + startup
by Ilias Apalodimas 25 Jan '23

25 Jan '23

As described in [0] if a command requires use of an untested algorithm or functional module, the TPM performs the test and then completes the command actions. Since we don't check for TPM_RC_NEEDS_TEST (which is the return code of the TPM in that case) and even if we would, it would complicate our TPM code for no apparent reason, add a wrapper function that performs both the selftest and the startup sequence of the TPM. It's worth noting that this is implemented on TPMv2.0. The code for 1.2 would look similar, but I don't have a device available to test. [0] https://trustedcomputinggroup.org/wp-content/uploads/TPM-Rev-2.0-Part-1-Arc… §12.3 Self-test modes Signed-off-by: Ilias Apalodimas <ilias.apalodimas(a)linaro.org> --- include/tpm-v2.h | 8 ++++++++ include/tpm_api.h | 8 ++++++++ lib/tpm-v2.c | 29 +++++++++++++++++++++++++++++ lib/tpm_api.c | 8 ++++++++ 4 files changed, 53 insertions(+) diff --git a/include/tpm-v2.h b/include/tpm-v2.h index 737e57551d73..3013f69a90ed 100644 --- a/include/tpm-v2.h +++ b/include/tpm-v2.h @@ -688,4 +688,12 @@ u32 tpm2_report_state(struct udevice *dev, uint vendor_cmd, uint vendor_subcmd, u32 tpm2_enable_nvcommits(struct udevice *dev, uint vendor_cmd, uint vendor_subcmd); +/** + * tpm2_auto_start() - start up the TPM and perform selftests + * + * @param dev TPM device + * Return: return code of the operation (0 = success) + */ +u32 tpm2_auto_start(struct udevice *dev); + #endif /* __TPM_V2_H */ diff --git a/include/tpm_api.h b/include/tpm_api.h index 8979d9d6df7e..022a8bbaeca6 100644 --- a/include/tpm_api.h +++ b/include/tpm_api.h @@ -331,4 +331,12 @@ static inline bool tpm_is_v2(struct udevice *dev) return IS_ENABLED(CONFIG_TPM_V2) && tpm_get_version(dev) == TPM_V2; } +/** + * tpm_auto_start() - start up the TPM and perform selftests + * + * @param dev TPM device + * Return: return code of the operation (0 = success) + */ +u32 tpm_auto_start(struct udevice *dev); + #endif /* __TPM_API_H */ diff --git a/lib/tpm-v2.c b/lib/tpm-v2.c index 697b982e079f..c34e158e2bb4 100644 --- a/lib/tpm-v2.c +++ b/lib/tpm-v2.c @@ -44,6 +44,35 @@ u32 tpm2_self_test(struct udevice *dev, enum tpm2_yes_no full_test) return tpm_sendrecv_command(dev, command_v2, NULL, NULL); } +/* + * - If a testable function has not been tested and is requested the TPM2 will return + * TPM_RC_NEEDS_TEST. + * - If TPM2 self-test has been received and the tests are not complete the + * result will be TPM_RC_TESTING. + * - If testing of all functions is complete without functional failures the result + * will be TPM_RC_SUCCESS. + * - If any test failed, the result will be TPM2_RC_FAILURE. + * - if the TPM hasn't started it will return TPM2_RC_INITIALIZE. + */ +u32 tpm2_auto_start(struct udevice *dev) +{ + u32 rc; + + rc = tpm2_self_test(dev, TPMI_YES); + if (rc && rc != TPM2_RC_INITIALIZE) + return rc; + + if (rc == TPM2_RC_INITIALIZE) { + rc = tpm2_startup(dev, TPM2_SU_CLEAR); + if (rc) + return rc; + + rc = tpm2_self_test(dev, TPMI_YES); + } + + return rc; +} + u32 tpm2_clear(struct udevice *dev, u32 handle, const char *pw, const ssize_t pw_sz) { diff --git a/lib/tpm_api.c b/lib/tpm_api.c index 7e8df8795ef3..5b2c11a277cc 100644 --- a/lib/tpm_api.c +++ b/lib/tpm_api.c @@ -35,6 +35,14 @@ u32 tpm_startup(struct udevice *dev, enum tpm_startup_type mode) } } +u32 tpm_auto_start(struct udevice *dev) +{ + if (tpm_is_v2(dev)) + return tpm2_auto_start(dev); + + return -ENOSYS; +} + u32 tpm_resume(struct udevice *dev) { if (tpm_is_v1(dev)) -- 2.38.1

2 2

Store U-Boot environnement in eMMC on i.MX8MPlus
by Joris OFFOUGA 25 Jan '23

25 Jan '23

Hi all, I try to store my U-Boot environment in eMMC on i.MX8MPlus, I then remove the CONFIG_ENV_IS_NOWHERE option, and I then put the following options: CONFIG_SYS_MMC_ENV_DEV=1 CONFIG_ENV_OFFSET=0x400000 CONFIG_ENV_SIZE=0x2000 CONFIG_SYS_MMC_ENV_PART=0 However during the boot sequence I get stuck here: U-Boot SPL 2023.01 (Jan 25 2023 - 08:23:12 +0100) DDRINFO: start DRAM init DDRINFO: DRAM rate 3000MTS DDRINFO:ddrphy calibration done DDRINFO: ddrmix config done NormalBoot Trying to boot from BOOTROM Boot Stage: USB boot Find img info 0x&48017200, size 872 Need continue download 1024 Download 1090688, Total size 1092224 NOTICE: BL31: v2.4(release):acddd624b NOTICE: BL31: Built: 08:21:46, Jan 24 2023 whereas if I have the option CONFIG_ENV_IS_NOWHERE=y U-Boot SPL 2023.01 (Jan 25 2023 - 08:41:47 +0100) DDRINFO: start DRAM init DDRINFO: DRAM rate 3000MTS DDRINFO:ddrphy calibration done DDRINFO: ddrmix config done NormalBoot Trying to boot from BOOTROM Boot Stage: USB boot Find img info 0x&48016e00, size 872 Need continue download 1024 Download 1089160, Total size 1090696 NOTICE: BL31: v2.4(release):acddd624b NOTICE: BL31: Built: 08:21:46, Jan 24 2023 U-Boot 2023.01 (Jan 25 2023 - 08:41:47 +0100) CPU: i.MX8MP Lite[4] rev1.1 1600 MHz (running at 1200 MHz) CPU: Industrial temperature grade (-40C to 105C) at 52C Reset cause: POR Model: IMX8MPLUS DRAM: 1 GiB Core: 187 devices, 26 uclasses, devicetree: separate MMC:FSL_SDHC:0 Loading Environment from nowhere...OK In: serial Out: serial Err: serial BuildInfo: - ATF acddd62 do you have any idea about this? Best regards, Joris OFFOUGA

1 0