December 2022 - U-Boot

[PATCH v4 00/17] IPv6 support
by Viacheslav Mitrofanov 02 Dec '22

02 Dec '22

This patch set adds basic IPv6 support to U-boot. It is based on Chris's Packham patches (https://lists.denx.de/pipermail/u-boot/2017-January/279366.html) Chris's patches were taken as base. There were efforts to launch it on HiFive SiFive Unmatched board but the board didn't work well. The code was refactored, fixed some bugs as CRC for little-endian, some parts were implemented in our own way, something was taken from Linux. Finally we did manual tests and the board worked well. Testing was done on HiFive SiFive Unmatched board (RISC-V) Signed-off-by: Viacheslav Mitrofanov <v.v.mitrofanov(a)yadro.com> --- Changes in v2: - Split big patches into smaller - If an address in tftpboot is IPv6 than use IPv6 to boot - Add tests Changes in v3: - Added functions and structures description in whole patch-series - Removed memory allocation in on_ip6addr() - Some functions got return code from errno.h - Add to string_to_ip6() length parameter to avoid obligatory null termination - Add a lot of small decorative cnages Changes in v4: - Fixed funcs and structures style description - Added omitted tags Viacheslav Mitrofanov (17): net: ipv6: Add IPv6 basic primitives net: ipv6: Add IPv6 build options net: ipv6: Add callbacks declarations to get access to IPv6 variables net: ipv6: Add Neighbor Discovery Protocol (NDP) net: ipv6: Add string_to_ip6 converter net: ipv6: Enable IPv6 typeconversion specifier net: ipv6: Add ip6addr, gatewayip6, serverip6 variables callbacks net: ipv6: Add implementation of main IPv6 functions net: ipv6: Incorporate IPv6 support into u-boot net subsystem net: tftp: Add IPv6 support for tftpboot net: ping6: Add ping6 command test: dm: eth: Add string_to_ip6 test test: dm: eth: Add csum_ipv6_magic test test: dm: eth: Add ip6_addr_in_subnet test test: dm: eth: Add ip6_make_snma test test: dm: eth: Add ip6_make_lladdr test test/py: add a ping6 test cmd/Kconfig | 7 + cmd/net.c | 61 ++++++ include/env_callback.h | 10 + include/env_flags.h | 10 + include/ndisc.h | 102 +++++++++ include/net.h | 4 +- include/net6.h | 432 ++++++++++++++++++++++++++++++++++++ lib/net_utils.c | 109 ++++++++++ lib/vsprintf.c | 7 +- net/Kconfig | 10 + net/Makefile | 3 + net/ndisc.c | 289 +++++++++++++++++++++++++ net/net.c | 53 ++++- net/net6.c | 445 ++++++++++++++++++++++++++++++++++++++ net/ping6.c | 118 ++++++++++ net/tftp.c | 63 +++++- test/dm/eth.c | 146 +++++++++++++ test/py/tests/test_net.py | 15 ++ 18 files changed, 1865 insertions(+), 19 deletions(-) create mode 100644 include/ndisc.h create mode 100644 include/net6.h create mode 100644 net/ndisc.c create mode 100644 net/net6.c create mode 100644 net/ping6.c -- 2.25.1

6 39

[PATCH v2 0/8] imx8: switch missing boards to binman
by Oliver Graute 02 Dec '22

02 Dec '22

This patchsets switches the remaining imx8 boards to binman. Oliver Graute (8): imx: imx8qm-rom7720: switch to binman imx: imx8qm: cgtqmx8: switch to binman imx: imx8qxp: imx8qxp_mek switch to binman imx: imx8qm: imx8qm_mek switch to binman imx: imx8qxp: giedi switch to binman imx: imx8qxp: deneb switch to binman imx: imx8x: colibri: switch to binman imx: imx8: apalis: switch to binman arch/arm/dts/fsl-imx8qm-apalis-u-boot.dtsi | 2 + arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi | 2 + arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi | 2 + arch/arm/dts/fsl-imx8qxp-mek-u-boot.dtsi | 2 + arch/arm/dts/imx8qm-cgtqmx8.dts | 1 + arch/arm/dts/imx8qm-rom7720-a1.dts | 1 + arch/arm/dts/imx8qm-u-boot.dtsi | 135 ++++++++++++++++++ arch/arm/dts/imx8qxp-capricorn-u-boot.dtsi | 2 + arch/arm/dts/imx8qxp-u-boot.dtsi | 133 +++++++++++++++++ arch/arm/mach-imx/imx8/Kconfig | 8 ++ .../advantech/imx8qm_rom7720_a1/imximage.cfg | 4 +- board/congatec/cgtqmx8/imximage.cfg | 4 +- board/freescale/imx8qm_mek/README | 2 +- board/freescale/imx8qxp_mek/imximage.cfg | 3 +- board/siemens/capricorn/imximage.cfg | 2 +- configs/apalis-imx8_defconfig | 1 + configs/cgtqmx8_defconfig | 4 +- configs/colibri-imx8x_defconfig | 1 + configs/deneb_defconfig | 2 + configs/giedi_defconfig | 2 + configs/imx8qm_mek_defconfig | 2 + configs/imx8qm_rom7720_a1_4G_defconfig | 3 +- configs/imx8qxp_mek_defconfig | 2 + doc/board/advantech/imx8qm-rom7720-a1.rst | 3 +- doc/board/congatec/cgtqmx8.rst | 3 +- doc/board/nxp/imx8qxp_mek.rst | 2 +- 26 files changed, 313 insertions(+), 15 deletions(-) create mode 100644 arch/arm/dts/imx8qm-u-boot.dtsi create mode 100644 arch/arm/dts/imx8qxp-u-boot.dtsi -- 2.17.1

8 38

Re: Boot failure regression on 6.0.10 stable kernel on iMX7
by Francesco Dolcini 01 Dec '22

01 Dec '22

+ u-boot list On Thu, Dec 01, 2022 at 12:25:34PM +0100, Marek Vasut wrote: > On 12/1/22 12:03, Francesco Dolcini wrote: > > On Wed, Nov 30, 2022 at 11:59:04PM +0100, Marek Vasut wrote: > > > On 11/30/22 21:51, Francesco Dolcini wrote: > > > > On Wed, Nov 30, 2022 at 03:41:13PM +0100, Marek Vasut wrote: > > > > > On 11/30/22 14:52, Francesco Dolcini wrote: > > > > > > [ 0.000000] Booting Linux on physical CPU 0x0 > > > > > > [ 0.000000] Linux version 6.0.10 (francesco@francesco-nb) (arm-linux-gnueabihf-gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9. > > > > > > 4.0, GNU ld (GNU Binutils for Ubuntu) 2.34) #36 SMP Wed Nov 30 14:07:15 CET 2022 > > > > > > ... > > > > > > [ 4.407499] gpmi-nand: error parsing ofpart partition /soc/nand-controller@33002000/partition@0 (/soc/nand-controller > > > > > > @33002000) > > > > > > [ 4.438401] gpmi-nand 33002000.nand-controller: driver registered. > > > > > > ... > > > > > > [ 5.933906] VFS: Cannot open root device "ubi0:rootfs" or unknown-block(0,0): error -19 > > > > > > [ 5.946504] Please append a correct "root=" boot option; here are the available partitions: > > > > > > ... > > > > > > > > > > > > Any idea? I'm not familiar with the gpmi-nand driver and I would just revert it, but > > > > > > maybe you have a better idea. > > > > > > > > > ... > > > > OF partition are created by U-Boot from > > > > mtdparts=mtdparts=gpmi-nand:512k(mx7-bcb),1536k(u-boot1)ro,1536k(u-boot2)ro,512k(u-boot-env),-(ubi) > > > > env variables calling fdt_fixup_mtdparts from colibri_imx7.c > > > > > > > > This is generated by U-Boot, I would need to dump what he did generate > > > > from the standard fdt_fixup_mtdparts(). I will try to do it tomorrow > > > > unless what I wrote here is already enough to understand what's going > > > > on. > > > > > > Oh drat ... I see. It's the u-boot fdt_node_set_part_info() which checks the > > > current NAND controller #size-cells and uses that when generating MTD > > > partitions 'reg' properties. Since #size-cells is now zero, the reg > > > properties would be malformed. > > > > I think the issue is slightly different, the u-boot code checks it and > > if not set it defaults to #size-cells = <1>. Said that u-boot > > never set #size-cells anywhere. > > Which it really should, can you send a patch there too ? I guess that it is slightly more complicated. U-Boot directly updates the nand-controller root node with the partitions, unless there is already a partitions child node present. In the first case (legacy OF partition definition) setting the #size-cells does not seems that correct, while in the second case I agree it should really do it. I'll see what I can come-up with. > > diff --git a/drivers/mtd/parsers/ofpart_core.c b/drivers/mtd/parsers/ofpart_core.c > > index 192190c42fc8..fffd60acd926 100644 > > --- a/drivers/mtd/parsers/ofpart_core.c > > +++ b/drivers/mtd/parsers/ofpart_core.c > > @@ -122,6 +122,8 @@ static int parse_fixed_partitions(struct mtd_info *master, > > > > a_cells = of_n_addr_cells(pp); > > s_cells = of_n_size_cells(pp); > > + if (s_cells == 0) > > + s_cells = 1; // for backward compatibility > > if (len / 4 != a_cells + s_cells) { > > pr_debug("%s: ofpart partition %pOF (%pOF) error parsing reg property.\n", > > master->name, pp, > > You might want to print a warning too, so users would fix their DTs, since > once there is MTD partition > 4 GiB, this would break. Otherwise I like this > option. I tested it and it's working as expected, I'll send a proper patch soon. Francesco

2 1

[RFC PATCH] board: ti: common: board_detect: Fix EEPROM read quirk for 2-byte
by Neha Malcom Francis 01 Dec '22

01 Dec '22

EEPROM detection logic in ti_i2c_eeprom_get() involves figuring out whether addressing is 1-byte or 2-byte. There are currently different behaviours seen across boards as documented in commit bf6376642fe8 ("board: ti: common: board_detect: Fix EEPROM read quirk"). Adding to the list, we see that there are 2-byte EEPROMs that read properly with 1-byte addressing with no offset. For ti_i2c_eeprom_am6_get where eeprom parse operation is dynamic, the earlier commit d2ab2a2bafd5 ("board: ti: common: board_detect: Fix EEPROM read quirk for AM6 style data") tried to resolve this by running ti_i2c_eeprom_get() twice. However this commit along with its former commit fails on J7 platforms where EEPROM successfully return back the header on 1-byte addressing and continues to do so until an offset is introduced. So the second read incorrectly determines the EEPROM as 1-byte addressing. A more generic solution is introduced here to solve this issue: 1-byte read without offset and 1-byte read with offset. If both passes, it follows 1-byte addressing else we proceed with 2-byte addressing check. Tested on J721E, J7200, DRA7xx, AM64x Signed-off-by: Neha Malcom Francis <n-francis(a)ti.com> Fixes: d2ab2a2bafd5 (board: ti: common: board_detect: Fix EEPROM read quirk for AM6 style data) and bf6376642fe8 (board: ti: common: board_detect: Fix EEPROM read quirk) --- board/ti/common/board_detect.c | 29 ++++++++++++++++++----------- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/board/ti/common/board_detect.c b/board/ti/common/board_detect.c index c37629fe8a..b9f2ebf2a0 100644 --- a/board/ti/common/board_detect.c +++ b/board/ti/common/board_detect.c @@ -91,6 +91,8 @@ static int __maybe_unused ti_i2c_eeprom_get(int bus_addr, int dev_addr, #if CONFIG_IS_ENABLED(DM_I2C) struct udevice *dev; struct udevice *bus; + uint8_t offset_test; + bool one_byte_addressing = true; rc = uclass_get_device_by_seq(UCLASS_I2C, bus_addr, &bus); if (rc) @@ -114,8 +116,23 @@ static int __maybe_unused ti_i2c_eeprom_get(int bus_addr, int dev_addr, */ (void)dm_i2c_read(dev, 0, ep, size); + if (*((u32 *)ep) != header) + one_byte_addressing = false; + + /* + * Handle case of bad 2 byte eeproms that responds to 1 byte addressing + * but gets stuck in const addressing when read requests are performed + * on offsets. We perform an offset test to make sure it is not a 2 byte + * eeprom that works with 1 byte addressing but just without an offset + */ + + rc = dm_i2c_read(dev, 0x1, &offset_test, sizeof(offset_test)); + + if (*((u32 *)ep) != (header & 0xFF)) + one_byte_addressing = false; + /* Corrupted data??? */ - if (*((u32 *)ep) != header) { + if (!one_byte_addressing) { /* * read the eeprom header using i2c again, but use only a * 2 byte address (some newer boards need this..) @@ -444,16 +461,6 @@ int __maybe_unused ti_i2c_eeprom_am6_get(int bus_addr, int dev_addr, if (rc) return rc; - /* - * Handle case of bad 2 byte eeproms that responds to 1 byte addressing - * but gets stuck in const addressing when read requests are performed - * on offsets. We re-read the board ID to ensure we have sane data back - */ - rc = ti_i2c_eeprom_get(bus_addr, dev_addr, TI_EEPROM_HEADER_MAGIC, - sizeof(board_id), (uint8_t *)&board_id); - if (rc) - return rc; - if (board_id.header.id != TI_AM6_EEPROM_RECORD_BOARD_ID) { pr_err("%s: Invalid board ID record!\n", __func__); return -EINVAL; -- 2.34.1

4 8

[PATCH 1/1] efi_loader: fix handling of DHCP acknowledge
by Heinrich Schuchardt 01 Dec '22

01 Dec '22

The dhcp command may be executed after the first UEFI command. We should still update the EFI_PXE_BASE_CODE_PROTOCOL. Don't leak content of prior acknowledge packages. Handle out of memory. Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt(a)canonical.com> --- lib/efi_loader/efi_net.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/lib/efi_loader/efi_net.c b/lib/efi_loader/efi_net.c index 69276b275d..96a5bcca27 100644 --- a/lib/efi_loader/efi_net.c +++ b/lib/efi_loader/efi_net.c @@ -30,6 +30,7 @@ static uchar **receive_buffer; static size_t *receive_lengths; static int rx_packet_idx; static int rx_packet_num; +static struct efi_net_obj *netobj; /* * The notification function of this event is called in every timer cycle @@ -660,10 +661,16 @@ void efi_net_set_dhcp_ack(void *pkt, int len) { int maxsize = sizeof(*dhcp_ack); - if (!dhcp_ack) + if (!dhcp_ack) { dhcp_ack = malloc(maxsize); - + if (!dhcp_ack) + return; + } + memset(dhcp_ack, 0, maxsize); memcpy(dhcp_ack, pkt, min(len, maxsize)); + + if (netobj) + netobj->pxe_mode.dhcp_ack = *dhcp_ack; } /** @@ -853,7 +860,6 @@ static efi_status_t EFIAPI efi_pxe_base_code_set_packets( */ efi_status_t efi_net_register(void) { - struct efi_net_obj *netobj = NULL; efi_status_t r; int i; @@ -982,6 +988,7 @@ failure_to_add_protocol: return r; out_of_resources: free(netobj); + netobj = NULL; free(transmit_buffer); if (receive_buffer) for (i = 0; i < ETH_PACKETS_BATCH_RECV; i++) -- 2.37.2

2 5

unsubscribe
by Chan Kim 01 Dec '22

01 Dec '22

1 0